| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
Change-Id: Ia57685d8858e02e399ad5c75ce64d12609d340ac
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Squiz.WhiteSpace.LanguageConstructSpacing:
Language constructs must be followed by a single space;
expected "require_once expression" but found
"require_once(expression)"
It is a keyword (e.g. like `new`, `return` and `print`). As
such the parentheses don't make sense.
Per our code conventions, we use a space after keywords like
these. We appeared to have an unwritten exception for `require`
that doesn't make sense. About 60% of require/include usage
was missing the space and/or had superfluous parentheses.
It is as silly as print("foo") or return("foo"), it works
because keywords have no significance for whitespace between
it and the expression that follows, and since experessions can
be wrapped in parentheses for clarity (e.g. when doing string
concatenation or mathematical operations) the parenthesis
before and after basiclaly just ignored.
Change-Id: I2df2f80b8123714bea7e0771bf94b51ad5bb4b87
|
|
|
|
| |
Change-Id: I16a9b42651f1cfb1a70dffbb67b7b83dfeb90d03
|
|
|
|
| |
Change-Id: I71318eb7d8c00bfc1ce6d2fc636b498f7a695f42
|
|
|
|
|
|
| |
3 of n.
Change-Id: I62ad009018c54da6cf081c334e44eb98a3c72695
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) ParserTests::testParserTest with data set #468 ('pre-save transform:
Signature expansion', '* ~~~
* <noinclude>~~~</noinclude>
* <includeonly>~~~</includeonly>
* <onlyinclude>~~~</onlyinclude>', '*
[[Special:Contributions/127.0.0.1|127.0.0.1]]
* <noinclude>[[Special:Contributions/127.0.0.1|127.0.0.1]]</noinclude>
*
<includeonly>[[Special:Contributions/127.0.0.1|127.0.0.1]]</includeonly>
*
<onlyinclude>[[Special:Contributions/127.0.0.1|127.0.0.1]]</onlyinclude>',
'pst', '')
pre-save transform: Signature expansion
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'* [[Special:Contributions/127.0.0.1|127.0.0.1]]
-* <noinclude>[[Special:Contributions/127.0.0.1|127.0.0.1]]</noinclude>
-*
<includeonly>[[Special:Contributions/127.0.0.1|127.0.0.1]]</includeonly>
-*
<onlyinclude>[[Special:Contributions/127.0.0.1|127.0.0.1]]</onlyinclude>'
+'* [[User:Apitestsysop|Apitestsysop]] ([[User talk:Apitestsysop|talk]])
+* <noinclude>[[User:Apitestsysop|Apitestsysop]] ([[User
talk:Apitestsysop|talk]])</noinclude>
+* <includeonly>[[User:Apitestsysop|Apitestsysop]] ([[User
talk:Apitestsysop|talk]])</includeonly>
+* <onlyinclude>[[User:Apitestsysop|Apitestsysop]] ([[User
talk:Apitestsysop|talk]])</onlyinclude>'
Change-Id: Ia72f9242deb5c6109d38b56dd46ef92fa6386278
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That will let us tests all the API tests by using PHPUnit group
filtering such as:
php phpunit.php --group API
Also cleaned some whitespaces
Patchset-4: skipped files that had only whitespace changes
Change-Id: I51e03d910521b061f505e3a9b11a08c7b95f1538
|
|
|
|
|
|
|
|
|
|
|
| |
ApiUploadTest gives inconsistent results which trigger false alamrs to all
the ops team. We are disabling those tests for now.
See https://bugzilla.wikimedia.org/26169
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/110790
|
|
|
|
|
|
|
|
| |
Follow up r104687
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/107361
|
|
|
|
|
|
|
| |
changes SVN likes to sprinkle in (easy to spot from the change list). Did not add SwiftFileBackend.php as it still is in development.
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/106752
|
|
|
|
|
|
|
|
| |
tempnam() like, not the two-words filenames of RandomImageGenerator::getRandomFilenames()
They aren't produced by ApiTestCaseUpload::fakeUploadFile() either.
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/102458
|
|
|
|
|
|
|
|
|
|
| |
* Make tests work again
* Added ApiTestCase::doApiRequest() and related to pass it to the context and removed override of $wgUser where possible
* Fix ApiLogin to get the correct User object (i.e. the logged in one)
* Fix ApiBase to feed a RequestContext to setContext() so that ApiLogin can call setUser()
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/101024
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some reason, the ApiUploadTest::testLogin method no more returns a valid
session. Since most, if not all, of the ApiUploadTest tests depends on it
we want that testLogin method to fail so we can skip the rest of the tests.
Test command:
./phpunit.php --filter ApiUpload --tap
BEFORE:
=======
TAP version 13
array(0) {
}
ok 1 - ApiUploadTest::testLogin
ok 2 - ApiUploadTest::testUploadRequiresToken
not ok 3 - Error: ApiUploadTest::testUploadMissingParams
not ok 4 - Error: ApiUploadTest::testUpload
^C
AFTER:
======
TAP version 13
not ok 1 - Failure: ApiUploadTest::testLogin
---
message: 'API Login must return a session'
severity: fail
...
ok 1 - # SKIP This test depends on "ApiUploadTest::testLogin" to pass.
ok 1 - # SKIP This test depends on "ApiUploadTest::testLogin" to pass.
^C ... more skips
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/100959
|
|
|
|
|
|
|
|
| |
* Move Imagick check into getImageWriteMethod(), adjust exception catching. Previously this was bailing on the test if you have convert but not the PHP Imagick extension. Now all these tests are passing for me again.
* Rm unused member variable, whitespace, etc
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/93928
|
|
|
|
|
|
|
|
|
|
| |
metadata storage instead of the session, see bug 26179
Tweaked the UploadWizard to work properly with the new backend code, updated tests
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/92009
|
|
|
|
| |
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/91568
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) ApiUploadTest::testUploadStash
Failed asserting that <boolean:true> is false.
Did this by copying the correct stuff from $_SESSION to our local $session we're using for the test. Not sure if this is strictly correct, but hey it passes ;-)
Currently at: Tests: 1622, Assertions: 32090, Incomplete: 8, Skipped: 5.
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/91215
|
|
|
|
|
|
|
| |
tests to support extensions extending upload test case”
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/85566
|
|
|
|
| |
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/83144
|
|
|
|
|
|
|
|
| |
Added option request parameter to User::editToken() and User::matchEditToken() and use them where possible from the api.
Also removed $_SESSION usage since it's no longer needed
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/83080
|
|
|
|
| |
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/79569
|
|
|
|
|
|
|
|
|
|
|
| |
Old: ApiWatchTest not only tested the watch module, but also tested the login module,
and the login module test was also used to log in to the API for the other tests.
New: ApiWatchTest only contains watch-specific methods. The login testing has been moved
to ApiTest. The code used to log in and get tokens have been moved to ApiSetup. Nice,
organized, and much nicer than before. ApiUploadTest is still pretty fugly, though.
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/79476
|
|
|
|
|
|
|
| |
The SeleniumTestConstants class was added in r79437
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/79443
|
|
|
|
|
|
|
|
| |
* Make a bunch of tests subclass MediaWikiTestCase
* Parser tests and ResourceLoaderTest can't subclass it yet due to various issues
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/79117
|
|
|
|
| |
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/78493
|
|
They're not strictly maintenance scripts, and some people want to do a selective checkout that doesn't include the tests. There's still debate on whether we should include these in the release downloads, but we had a pretty firm consensus to move this.
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/78383
|