aboutsummaryrefslogtreecommitdiffstats
path: root/resources/src
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Merge "resourceloader: Remove creation of dynamic-styles marker"jenkins-bot2018-05-031-26/+19
|\ \ \ \
| * | | | resourceloader: Remove creation of dynamic-styles markerTimo Tijhof2018-04-261-26/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Firstly, this code is never used because the marker is unconditionally created by OutputPage. But, we may change that one day, and we want to reduce dependency on server-side specifics so that the loader can (in theory) work on any web page. So we want to keep some kind of fallback for now. It's a private getter used in two places: 1. addEmbeddedCSS (private): Call newStyleTag with nextNode=marker. The newStyleTag function already treats nextNode as optional, and falls back to doing the same thing getMarker() was doing, which is: append to document.head. 2. addLink (private, debug-mode only): Used the marker as insertion point for a new element. Basically the same as newStyleTag, except it was using the wrapper of `$().before()` instead of calling Node#insertBefore() directly. Made it optional, with as fallback appending to document.head. Same as newStyleTag. Also removed an unused jQuery object in addEmbeddedCSS, from passing result of newStyleTag() to $(), but not using it. Bug: T192623 Change-Id: If04c801c073b4cf74bf111d02ce3dc133bb862d1
* | | | | mediawiki.jqueryMsg: Remove deprecated window.gM() methodTimo Tijhof2018-05-031-14/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Deprecated with warnings since MediaWiki 1.23 (released 2013). * Zero results for 'gM(' in mwgrep (sitewide scripts on public WMF wikis). Bug: T135148 Change-Id: I3b97355012fc8741c7f4953f4b249d70beb96b01
* | | | | Merge "sortable tables/mw-collapsible no longer causes page jump"jenkins-bot2018-05-035-27/+149
|\ \ \ \ \
| * | | | | sortable tables/mw-collapsible no longer causes page jumpjdlrobson2018-05-025-27/+149
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Relatively straightforwardly - we move padding-right definition into top styles to avoid a reflow This turned out to be a little tricker than first imagined. The code in jquery.makeCollapsible.js finds elements marked up as collapsible and then 1) collapses them 2) inserts a toggle button. To avoid a reflow on the page, we have to make sure the collapsed content is collapsed prior to the code running and reserve space for the toggle button. The toggle button is tricky as it is subject to i18n. However we can access this label via a LESS variable and use a pseudo element (which is supported by the majority of modern browsers) to preserve the space we need. When the JavaScript has loaded there is no need for that CSS any more. Note on slow connections, collapsed content will not be accessible until the JavaScript has fully loaded, however this is arguably less of a problem then the existing reflows. Note, there are many many many usages of mw-collapsible, because of this this does not claim to address all reflows in all usages - but it does provide support for the more widespread usages. Follow up patches can be added for specific situations - for example table of contents toggle. Bug: T42792 Bug: T42812 Depends-On: I3388c3c4f91cdbab11e89cdc95973b688d3f1ce7 Change-Id: If9c8f0974e3a4b08e4a66d37f7f5adf67d73054e
* | | | | | Remove $wgExperimentalHtmlIds and related code, deprecated in 1.30James D. Forrester2018-05-011-7/+0
|/ / / / / | | | | | | | | | | | | | | | | | | | | Bug: T139744 Change-Id: Ia15d5ab6e7637fd40d5c3399822a3dbeb7b383b5
* | | | | mediawiki.api: Check that query exists in api.getToken() responseStephen Niedzielski2018-05-011-9/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's possible that response.query does not exist when requesting a token. This patch removes the assumption and handles the scenario in the same way as a missing token. Additionally, responses with a queryless response are now deleted from the cache. Corresponding console warning: > jQuery.Deferred exception: Cannot read property 'tokens' of undefined > at apiPromise.then.promise.abort (/w/resources/src/mediawiki/api.js) Change-Id: Ia29e0c0d657bf4b3d94f1d463b942451eebd68b4
* | | | | Merge "Fix selector to align all button types"jenkins-bot2018-05-011-1/+2
|\ \ \ \ \ | |_|_|_|/ |/| | | |
| * | | | Fix selector to align all button typesEd Sanders2018-05-011-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | Bug: T193474 Change-Id: I02dbe5d880567c6e7e59c867c3ab910600c667d0
* | | | | mediawiki.util: Remove deprecated wikiGetlink()Timo Tijhof2018-04-301-7/+0
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Deprecated since MediaWiki 1.22, with console warnings since 1.23 (released 5 years ago). * All uses in core, tarball components, and wmf-deployed components have been fixed. * All uses in sitewide and user scripts on public WMF wikis have been fixed (Wow!). Bug: T57764 Change-Id: I926966a83daadfee3adbb9a32acbb5b710a29686
* | | | Merge "Fix alignment of checkbox label in feedback dialog"jenkins-bot2018-04-301-0/+4
|\ \ \ \
| * | | | Fix alignment of checkbox label in feedback dialogEd Sanders2018-04-291-0/+4
| | | | | | | | | | | | | | | | | | | | Change-Id: I2af1fc716b1921928fa210f82d1b290be64142fd
* | | | | Merge "media: Rename files to match the name of the class they define"jenkins-bot2018-04-301-1/+1
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | media: Rename files to match the name of the class they defineTimo Tijhof2018-04-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will make jumping from file to file much easier in text editors when file name lookups will autocomplete naturally when looking for a class by name. Change-Id: I4b2e55a2e72674b619d5a592866c8a019a2b0224
* | | | | Merge "resourceloader: Use plain arrays instead of $.Callbacks() in ↵jenkins-bot2018-04-291-5/+8
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | addEmbeddedCSS"
| * | | | | resourceloader: Use plain arrays instead of $.Callbacks() in addEmbeddedCSSAaron Schulz2018-04-271-5/+8
| | |/ / / | |/| | | | | | | | | | | | | | | | | | Bug: T192623 Change-Id: I00c9571d353980d853cc8e92b2b508ad7271ab87
* | | | | Merge "resourceloader: Remove mwPerformance stub and rename mwLoadStart mark"jenkins-bot2018-04-282-8/+7
|\ \ \ \ \ | |_|/ / / |/| | | |
| * | | | resourceloader: Remove mwPerformance stub and rename mwLoadStart markTimo Tijhof2018-04-232-8/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove the private 'mwPerformance' stub, in favour of simply calling performance.mark() directly in a conditional, like we do elsewhere for web APIs that don't exist in all supported browsers. This mark (part of the W3C User Timing interface), was sometimes used to measure a delta to mwLoadEnd, whcih is a problem because startup loads asynchronously. The point it executes is intentionally variable. What matters is when the overall JS load process ends, which is composed of multiple requests. Keep the mark, but rename to 'mwStartup' which better describes its purpose and can remain useful. Bug: T160315 Bug: T192623 Change-Id: I6e2049e7252e5c2be3c5bc6617703b62e5edafb4
* | | | | Merge "Revert "wikibits: Remove redundant stubs for document.write""jenkins-bot2018-04-271-0/+12
|\ \ \ \ \ | |_|/ / / |/| | | |
| * | | | Revert "wikibits: Remove redundant stubs for document.write"Jforrester2018-04-261-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7f2c6c401644c06b0bd30e311c6247bcaebec1bc. Bug: T193191 Change-Id: Ia6bdc1e339fe0f6265094de6d3e0a5cea0919cd6
* | | | | ApiSandbox: Resize layout to fit content, and remove fullscreen modeEd Sanders2018-04-252-76/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoids unpleasant nested scrollbars, and hacky fullscren mode. Make toolbar position:sticky to keep buttons visible. Bug: T129157 Change-Id: Ia3c3176c1bd7cac6af2c35f53d820f1272df72a5
* | | | | Merge "Align to WikimediaUI themed widgets"jenkins-bot2018-04-253-105/+196
|\ \ \ \ \
| * | | | | Align to WikimediaUI themed widgetsVolker E2018-04-173-105/+196
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Aligning to WikimediaUI themed widgets. As of now, Calendar- & DateTimeInputWidget have been user-interface wise in limbo between WikimediaUI style and non-themed style. Let's align it to former and ensure theme-dependency in a future step. Also - massively cleaning up LESS, - removing duplicated, already inherited properties and - fixing little annoyances like `line-height` in fields being wrong or - `:focus` states being disconnected from the rest. Bug: T189352 Change-Id: Ia39254aec3535aed9e3d3e01b3fc01c25cd72c2e
* | | | | | Merge "Create Expiry Widget with Date Time Selector"jenkins-bot2018-04-244-6/+303
|\ \ \ \ \ \
| * | | | | | Create Expiry Widget with Date Time SelectorDavid Barratt2018-04-194-6/+303
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Special:Block needs a date time selector for easier selection of expiry. To accommodate this cleanly, a new Expiry Widget is created that handles this logic. Bug: T132220 Change-Id: I2853a2ca0ae6ccead3978f4bb50a77c2baa3a150
* | | | | | | Merge "Remove onhashchange fallback code"jenkins-bot2018-04-242-45/+11
|\ \ \ \ \ \ \
| * | | | | | | Remove onhashchange fallback codeEd Sanders2018-04-242-45/+11
| | |_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We no longer support any browsers that don't have the hashchange event. Change-Id: I5e6bfd1d5c634df21b6b3d06dcf007112cdf15fa
* | | | | | | mw.special.apisandbox: Offer to fill in token when not givenBartosz Dziewoński2018-04-241-18/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I53c414f0a80ce76907d3293971a47e87aa67fb06
* | | | | | | Merge "Fix width of OOUI TextInputWidget with .mw-editfont-... classes"jenkins-bot2018-04-242-19/+30
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | |
| * | | | | | Fix width of OOUI TextInputWidget with .mw-editfont-... classesEd Sanders2018-04-212-19/+30
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | Bug: T192373 Change-Id: I6a6757874a3502b42cff0a3edb55115a305ad609
* | | | | | Merge "wikibits: Remove redundant stubs for document.write"jenkins-bot2018-04-231-12/+0
|\ \ \ \ \ \ | | |_|/ / / | |/| | | |
| * | | | | wikibits: Remove redundant stubs for document.writeTimo Tijhof2018-04-211-12/+0
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The browser already warns for these, and our stubs were actually making it somewhat worse by appending to a weird place in the page instead of what the browser does (which is to either allow it properly, or ignore). Bug: T192623 Change-Id: I1924b252a8b986c4f1ad65f96149b8c06c1fad9b
* | | | | Merge "jquery.tablesorter: References ignored in sortkey."jenkins-bot2018-04-231-1/+5
|\ \ \ \ \
| * | | | | jquery.tablesorter: References ignored in sortkey.madd2018-04-231-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Text in elements with class='reference' excluded for sorting. Bug: T29745 Change-Id: If3969c00cbb7a74362fe85f4cad361da488526d5
* | | | | | Fix typo: bytePointLimit -> byteLimitEd Sanders2018-04-225-5/+5
| |/ / / / |/| | | | | | | | | | | | | | Change-Id: Ifafc4bdd6663e1ccfa6be938e5fc72fd1442a9a5
* | | | | jquery.makeCollapsible: Only add '[' ']' to autogenerated togglesBartosz Dziewoński2018-04-182-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These should not be added if a pre-generated toggle was provided in page HTML. Follow-up to 46a7aa7e3e8ea98b69ae4bd0aff51465da57bcd3. Bug: T192140 Change-Id: I4b7a7091c1db3559a474de94f8286c0df0af8a67
* | | | | Merge "mw.widgets.visibleLengthLimit: Apply number conversion to the limit"jenkins-bot2018-04-181-2/+6
|\ \ \ \ \ | | |_|_|/ | |/| | |
| * | | | mw.widgets.visibleLengthLimit: Apply number conversion to the limitBartosz Dziewoński2018-04-161-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In languages like Persian (fa) or Hindi (hi) this should probably use localised numerals. Change-Id: Iba40634038079deba1c26bacb515f4791b4d38db
* | | | | Merge "mw.widgets.UsersMultiselectWidget: Compat with ↵jenkins-bot2018-04-171-7/+9
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | mw.special.preferences.confirmClose"
| * | | | | mw.widgets.UsersMultiselectWidget: Compat with ↵Bartosz Dziewoński2018-04-171-7/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mw.special.preferences.confirmClose Replace `<input type="hidden">` with a `<textarea>` hidden using `display: none`, because the former does not have separate 'value' and 'defaultValue' properties, and the Special:Preferences script to enable/disable the "Save" button depends on them to work correctly. We use a similar approach in OOUI (RadioSelectInputWidget). Also correct a code comment (we need to trigger a 'change' event for any kind of input, not just `<input type="hidden">`). Bug: T192147 Change-Id: I2351bc752f9cf25a607f4b197c132062d52ecb1e
* | | | | | Merge "mw.special.preferences.confirmClose: Handle textareas"jenkins-bot2018-04-171-1/+2
|\| | | | |
| * | | | | mw.special.preferences.confirmClose: Handle textareasBartosz Dziewoński2018-04-171-1/+2
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | Bug: T192147 Change-Id: Ie02c5d8cab7db091054f7d66633c6ec34354ee19
* / | | | RCFilters: Prevent trigger element movementVolker E2018-04-161-0/+2
|/ / / / | | | | | | | | | | | | Change-Id: Ic04229ade53a42a47ccbd909640b848cf9979eb1
* / / / Use module.exports for mediawiki.libs.jpegmetaFomafix2018-04-173-5/+12
|/ / / | | | | | | | | | | | | | | | | | | | | | Deprecate mw.libs.jpegmeta. Use mw.loader.require( 'mediawiki.libs.jpegmeta' ) instead. Change-Id: I8a7fb7377248a2ce1cf9c6d3c888ca9835cadaad
* | | jquery.makeCollapsible: Use pseudo elements for square brackets around togglejdlrobson2018-04-122-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We want to use this in Minerva and mixing presentation with functionality makes styling it differently difficult. This change will also make it easier to deal with the reflow on initialisation (see follow up If9c8f0974e3a4b08e4a66d37f7f5adf67d7305). Change-Id: I4d96226c63563f16ad181e06f6bd12e6cf6bec67
* | | Merge "Remove checkIcon from TitleOptionWidget"jenkins-bot2018-04-121-0/+3
|\ \ \
| * | | Remove checkIcon from TitleOptionWidgetEd Sanders2018-04-111-0/+3
| | | | | | | | | | | | | | | | | | | | Bug: T191988 Change-Id: I6e5e20892f9171bf8fd28a3df3ee7d1f180e2ce4
* | | | RCFilters: Adjust unbalanced scan line in filter menuVolker E2018-04-116-24/+49
| | | | | | | | | | | | | | | | | | | | | | | | Bug: T191434 Bug: T191557 Change-Id: I0fb5c6f219600e697d4e712a21639d667ad2ed69
* | | | Ensure that span.mw-ui-icon is inline-blockjdlrobson2018-04-111-0/+5
|/ / / | | | | | | | | | | | | | | | | | | | | | In the Minerva skin there are several icons that are spans. This seems a sensible default and I'd rather keep this rule with the other definitions rather than inside Minerva Change-Id: I3d1ed6e4a165f48244e760752342c712047a07d8
* | | Add padding to popup tag widgetEd Sanders2018-04-101-0/+1
| | | | | | | | | | | | | | | Bug: T191883 Change-Id: Ie24a1d99788d7e40df790d123bbfd4adb0524fe6