| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
There's little point in phpcs checking LocalSettings.php or the other
*.php files in .gitignore.
Change-Id: Ibea15a3f3a7bfe2571e253ba9e19c1d91dfddeff
|
|
|
|
|
|
|
|
| |
Since the match can be case-insensitive (apparently), this meant
ExtensionsTestSuite.php ("extensions") wasn't being validated either.
Bug: T127238
Change-Id: I679de924ebeb45150004783ce404fac92af026a7
|
|
|
|
|
|
|
|
|
|
| |
* Fix errors spotted by new release
* Introduce "composer fix", which uses phpcbf to automatically fix some
errors spotted by phpcs.
* Drop $PHPCS_ARGS variable that didn't work on Windows, and add -s flag
* Remove rules from phpcs.xml that are now in MW-CS ruleset.
Change-Id: I13e2155695918c918b67497ac65b85a03897095e
|
|
|
|
|
|
|
|
|
|
| |
Per wikitech-l consensus:
https://lists.wikimedia.org/pipermail/wikitech-l/2016-February/084821.html
Notes:
* Disabled CallTimePassByReference due to false positives (T127163)
Change-Id: I2c8ce713ce6600a0bb7bf67537c87044c7a45c4b
|
|
|
|
|
|
|
|
|
| |
Two rules are ignored for now to allow us to upgrade:
* MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures
* Generic.ControlStructures.InlineControlStructure.NotAllowed
Also ignore the .git folder.
Change-Id: I1b149c72b27be54e22e369999ad0c41c2d1fc2b4
|
|
|
|
|
| |
Bug: T102609
Change-Id: I49eb778ccb5f0a3662fe4573872d1235c52fdd81
|
|
|
|
| |
Change-Id: Ie413b403992ba8598b3dea03adc9733c30414fe9
|
|
|
|
|
|
| |
Whitelist StubObject because the underscore is for internal use.
Change-Id: I4beeee8df8cde079b810a372539e3c169e80f2d3
|
|
|
|
|
| |
Bug: T102614
Change-Id: If853510b55d787765a84bac22b2dbff2e6c526c0
|
|
|
|
|
|
|
| |
Should work after Ie094f78781b2d6f7af1a0f1eea1f7ea4d0b9c69c
Bug: T104501
Change-Id: I1e3e8a1480b822272c762f2771d8554980c32c1b
|
|
|
|
|
|
|
| |
All remaining lines should be fixed now
Bug: T113854
Change-Id: I85269d4c84ae3a676a773e24b0a96a4e7a89ac38
|
|
|
|
|
|
|
| |
Enable only the SingleSpaceBeforeSingleLineComment part, not the
EmptyComment part.
Change-Id: I98f2d6d401745d8aaacaca115789eb15b81c6813
|
|
|
|
|
|
| |
Lots of warnings to be fixed in core
Change-Id: I9041ead57c2225cd618501d4998ceb85e9cb3c1b
|
|
|
|
|
|
|
|
|
| |
The list of variables to ignore was hardcoded in the sniff. Moving it to
the phpcs.xml file allows setting it on a per-project basis, and hence,
should be set in core's phpcs.xml.
Bug: T104501
Change-Id: I6909b1d3845ba72d867fe01e86bd4a8f6bef198f
|
|
|
|
|
|
|
|
|
| |
Certain unprefixed global functions have been in the codebase from a
long time and prefixing them could cause errors. The prefixed functions
sniff allows an ignoreList to be set in phpcs.xml.
Bug: T104501
Change-Id: Ie094f78781b2d6f7af1a0f1eea1f7ea4d0b9c69c
|
|
|
|
| |
Change-Id: I1b756909a1080108c5147d46950f826871ef6dc1
|
|\ |
|
| |
| |
| |
| | |
Change-Id: I07b4043163e5d00709f72dbbb3e2a46b17414d1c
|
|\ \ |
|
| |/
| |
| |
| | |
Change-Id: Ie86c512fbca07f41b252d95de3ab92da3a050e72
|
|\ \
| |/
|/|
| | |
MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis"
|
| |
| |
| |
| |
| |
| | |
MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis
Change-Id: I8482f5dd9d79e4946e862b0ac03bd027d62e8646
|
|\ \
| |/
|/| |
|
| |
| |
| |
| | |
Change-Id: I743c4ce019321d631c0a11ee2112fe9aa8ba4c5d
|
|/
|
|
|
|
| |
Fixed some SingleSpaceBeforeCloseParenthesis too
Change-Id: I1695c706a9b23ab98074ff7d6a3687eb5cdce6e7
|
|
|
|
| |
Change-Id: I50a987edf03cb19bfd707cd00c143c3665eba94f
|
|\ |
|
| |
| |
| |
| | |
Change-Id: I39f71dde31f3ec18ab06904692f6a4ffd454d4d1
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | | |
Add extra whitespace line too
Change-Id: Ia33c9b63c36f121e5e9283c6d4a2b024a1821a43
|
|\ \ \
| |_|/
|/| | |
|
| |/
| |
| |
| | |
Change-Id: Id3e4bc5d7e4d1b8003f9f6b324e2321b5af1771f
|
|\ \ |
|
| |/
| |
| |
| | |
Change-Id: Ib84ce8dc973f7e3fe688435a72f7936342b6f2dd
|
|/
|
|
|
|
| |
Globals are used in included file, so ignore warning in this case
Change-Id: I50315425827cc49eac3ca943a5a8952d0292ce23
|
|
|
|
|
|
|
|
| |
This allows us to make PHPCS voting, and enable the failing rules
individually when once their issues are fixed.
Bug: T102609
Change-Id: I6731d2d07bbd89d424a660ceb7aee4c0392500d3
|
|
|
|
|
|
|
|
|
| |
Most of these files have very long lines, but that makes them easier to
read. Also, they're generated from a script. It's probably a better idea
to ignore their lengths than to change the lengths.
Bug: T103806
Change-Id: Ic6860520e4cc76f93aa13c364aae11cf14f279d0
|
|
"composer phpcs" now runs PHPCS against the relevant directories.
Change-Id: Ic28eaff2318fa57977689957781538acb2b1893c
|