| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
This reverts commit 890558f1fa526550128bbfadcef94d72c430d717.
This restores Id584208d9b67d877606a0add1d71c9b1784cdb1b with some fixes.
Bug: T323786
Bug: T352742
Change-Id: Ib31c451ddd75b06c95a544c8a3d2a64b32264126
|
|
|
|
|
|
|
|
|
| |
This reverts commit bb4b5c5f87f292ef00415aff96c628cfe59c34c1.
Reason for revert: patch breaks CI
Bug: T352742
Change-Id: Iaf57bad945f5cbd01508a513f0d219ec4b510ce8
|
|
|
|
|
|
|
|
|
|
| |
This is only enabled in development mode for now.
It's intended as a baseline for further development,
the feature is not ready for production.
Bug: T323786
Change-Id: Id584208d9b67d877606a0add1d71c9b1784cdb1b
Co-authored-by: Atieno <pnjira@wikimedia.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
jsduck is preventing us from using ES6 syntax and has not
been supported for some time. It is also difficult to setup
locally due its use of Ruby.
Introduce jsdoc and remove jsduck per T138401#9335987
Link to static copy of jsduck explaining the state
This does the bare minimum - the docs are built to the folder
docs/js/index.html and only one module is ported over to allow
us to provide feedback on the end result.
Bug: T138401
Change-Id: I1a351ac5aec731bb79a877023ac10988ec3ec786
|
|
|
|
|
|
|
|
| |
Mostly this has a bunch of whitespace changes from the
template-curly-spacing and brace-style rules being set
to align with other spacing rules.
Change-Id: I4609c52a4ef426ad1f35fb4bfe447bb08323a8e8
|
|
|
|
|
|
|
| |
Required for running tests using Firefox.
Bug: T351747
Change-Id: I19d247d559eff06fc0aebac79f0d31b6ef65170a
|
|
|
|
| |
Change-Id: I9a870d937efee1588fb87584f65a985cb0d03693
|
|
|
|
| |
Change-Id: I35fa6b68e1ffdc563bd49de06d8ba11561f9cfdc
|
|
|
|
|
|
|
|
|
| |
svgo 2.8.0 → 3.0.2
Amending to new `cleanupIds` plugin name.
Bug: T339290
Change-Id: I16c77a2e6472f8b24e09795899233814fbb570e4
|
|
|
|
|
|
|
| |
* grunt-banana-checker: 0.10.0 → 0.11.0
* stylelint-config-wikimedia: 0.14.0 → 0.15.0
Change-Id: I21b3f7ed59c6f1485d968a6912f4ac33cdb1f53c
|
|
|
|
| |
Change-Id: I70d4e311d369bd160e0cb9411d1b074e22104006
|
|
|
|
|
| |
Bug: T333134
Change-Id: I8a9a3c3b2ba641806a6c75ffb852238b1a1d7606
|
|
|
|
| |
Change-Id: Ia66b47d707453b4204a52e3ad62c52be60cc1c86
|
|
|
|
| |
Change-Id: I8a71615e6cf70e07f60b97f5d53ed2da1faa8642
|
|
|
|
|
|
|
|
|
|
|
|
| |
<https://github.com/qunitjs/qunit/blob/2.19.4/History.md>
Main takeaways for us:
* Assert: Faster deepEqual.
* Core: Fix event "runtime" data to be rounded to milliseconds.
* HTML Reporter: Faster toolbar setup.
Change-Id: I2797cba94efc92d7986cc0573cc1b0c91541e3b2
|
|
|
|
| |
Change-Id: I8b2864b36ffa131a2c197c8a7da532e55a0d1a7e
|
|
|
|
|
|
|
|
| |
The `webdriverio` package does not need to be an explicit dependency.
It is a dependency of `@wdio/cli`.
Bug: T325059
Change-Id: Ie0ca84eb07fc12ebfeca9c16af26e1d84e8ba76a
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Only creating account via the web interface does not work on the beta
cluster, because of CAPTCHA.
Bug: T323824
Change-Id: I7e9c6169f1c72450b4b620a8712629af7637f06b
|
|/
|
|
|
|
| |
This fixes a bug with double-wrapping promises.
Change-Id: I40af372c17324dfe3863a5170c831ceeb59b7c49
|
|
|
|
|
|
|
| |
The environment variable is already set in the Jenkins job.
Bug: T323824
Change-Id: I08792ca50b5603b3f190638b0fa6e9d2d5c5656b
|
|
|
|
|
|
|
|
|
|
| |
composer:
* mediawiki/mediawiki-codesniffer: 39.0.0 → 40.0.1
npm:
* stylelint-config-wikimedia: 0.13.0 → 0.13.1
Change-Id: I67877aa166d781ce5e30dc2fe99050ebdfb28f32
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
composer:
* mediawiki/mediawiki-codesniffer: 38.0.0 → 39.0.0
The following sniffs are failing and were disabled:
* MediaWiki.PHPUnit.AssertEmpty.AssertEmptyUsed
* php-parallel-lint/php-console-highlighter: 0.5 → 1.0.0
* php-parallel-lint/php-parallel-lint: 1.3.1 → 1.3.2
npm:
* grunt-banana-checker: 0.9.0 → 0.10.0
* grunt: 1.5.2 → 1.5.3
* karma: 6.3.15 → 6.4.1
* async: 2.6.3 → 2.6.4
* https://github.com/advisories/GHSA-fwr7-v2mv-hh25
* got: 11.8.3 → 11.8.5
* https://github.com/advisories/GHSA-pfrx-2q88-qq97
Change-Id: I1d7bc9c9599b48d2bd837617cad409a31adb362a
|
|
|
|
|
|
|
|
| |
Begin moving the transform endpoints and handler class to
MediaWiki core.
Bug: T301370
Change-Id: I94e9d2e8d497c1992c542001afe333fa7537e553
|
|
|
|
| |
Change-Id: I59c7507fef057a880bca62a156662ee66f89ed94
|
|
|
|
|
|
|
|
|
|
| |
Highlights from <https://github.com/qunitjs/qunit/releases>
* HTML Reporter: Improve accessibility and design of the module filter.
* HTML Reporter: Faster rendering of module filter.
* Core: Improve performance of async pauses with native Map.
Change-Id: I03713b05982986fae261201f8591bafa0f774020
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
@wdio/dot-reporter that we currently use doesn't display much. For
example, it doesn't display skipped tests. It says 5 test suites are
executed, but that's a lie. 3 of those 5 suites are skipped.
@wdio/spec-reporter is more verbose but it actually outputs useful
information, like which tests are running, which are skipped.
This is a revert of aa7133ce8623e3e47202cc196771bf5aec7d72c3.
Bug: T280331
Change-Id: I7cef7d6a6d1b5e472622a81afc4f9a91523c1ca9
|
|
|
|
|
|
|
| |
Updating 'svgo' to v2.8.0 and newest Wikimedia SVG guidelines –
mainly around new whitespace features of SVGO.
Change-Id: Ibaf67b1178225c19a80dcba6a9ebbcf8964cbe8d
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Highlights from release notes at <https://github.com/qunitjs/qunit/releases>:
2.18.0:
* New `assert.propContains` for partial object comparison. (Izel Nakri)
* New `QUnit.hooks to globally add beforeEach and afterEach. (Timo Tijhof)
* CLI: Add support for watching `.ts` files when using TypeScript.
2.17.0:
* HTML Reporter: Add "Rerun failed tests" link. (Jan Buschtöns)
* Improve validation of `assert.throws`. (Steve McClure)
Depends-On: Ia98a60166209646cc641d45a1ece62c131bcbcd0
Change-Id: Ia8ce57fa72ced8286f3e74b0b991e33e24a88850
|
|
|
|
|
|
|
|
|
| |
If the project name isn't set, then `npm install` picks a value based on
the directory name. If that isn't "core", then package-lock.json will
overwrite the name property. Not a big deal, but may as well make this
consistent for everyone.
Change-Id: Idab76ffed4cd11fbc1659f090d51ffb3d43a96c5
|
|
|
|
|
|
| |
Also some minor version updates to karma dependencies as required.
Change-Id: I2740faca2d28ad2b2896a3b0222678115d11a166
|
|
|
|
| |
Change-Id: Ifb215e45a2ad4574fa821c696199e8c5911ba3ae
|
|
|
|
|
|
|
|
| |
Update npm packages: @wdio/* and webdriverio.
The update is need for WebdriverIO async mode to work.
Bug: T274579
Change-Id: I386d3d1d031f92cd67fad4b6746c6489110dfb80
|
|
|
|
|
|
| |
Depends-On: Ifb6fc6f3036c1623c32418c5f304b6fc7196fa04
Bug: T298735
Change-Id: I31966e96a996d30fb31f401abecff47a893b8f0c
|
|
|
|
|
|
|
| |
WebdriverIO has dropped support of sync mode due to breaking changes in Chromium, hence all tests have been changed to async.
Bug: T293071
Change-Id: I15347b789f11de84b764e13a3981545ed6759881
|
|
|
|
|
|
|
|
|
|
|
| |
* Replace `substr`/`substring` with `slice`. The second argument
to `substring` is length, not end index as in `substr`/`slice`,
so convert where necessary.
* Replace `new Date().getTime()` with `Date.now()`
* Documentation fixes
* Replace `throw Error` with `throw new Error`
Change-Id: I532500ea4c99d8ebec01efb21273c8df21626e59
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
composer:
* php-parallel-lint/php-parallel-lint: 1.3.0 → 1.3.1
npm:
* @wdio/mocha-framework: 7.4.6 → 7.13.2
* https://npmjs.com/advisories/5197 (CVE-2021-3807)
* nth-check: 2.0.0 → 2.0.1
* https://npmjs.com/advisories/5101 (CVE-2021-3803)
* ansi-regex: 5.0.0 → 5.0.1
* https://npmjs.com/advisories/5197 (CVE-2021-3807)
Change-Id: I0b17591a4d230192d5c64b68252bb3024ddcedae
|
|
|
|
|
|
|
|
|
|
|
|
| |
Highlights from release notes at <https://github.com/qunitjs/qunit/releases>:
* Added `assert.true()` and `assert.false()` methods.
* Added `QUnit.test.each()` method.
* Added fuzzy search filter as-you-type to the UI.
* Fixed HTML UI to increase contrast and use richer colors overall.
* Improve the "failing test" experience.
Change-Id: Idebf075b4b2be4c73807fd8ba398662240e6c268
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
composer:
* mediawiki/mediawiki-codesniffer: 36.0.0 → 37.0.0
The following sniffs now pass and were enabled:
* Generic.ControlStructures.InlineControlStructure
* MediaWiki.PHPUnit.AssertCount.NotUsed
npm:
* svgo: 2.3.0 → 2.3.1
* https://npmjs.com/advisories/1754 (CVE-2021-33587)
Change-Id: I2a9bbee2fecbf7259876d335f565ece4b3622426
|
|
|
|
|
|
|
|
| |
Just disabling the `declaration-property-unit-disallowed-list` failures
for now, but it looks like at least most of these could be switched over
to ems without breaking anything. For another patch!
Change-Id: I9220334d670f71eba1b0e392da826036d54bc2f3
|
|
|
|
| |
Change-Id: I5dc481c950bbc6ac479ad9f7acae5cfdbbdfe6fe
|
|
|
|
|
|
|
| |
Update npm packages: @wdio/* and webdriverio.
Bug: T274579
Change-Id: I16c1fd2bbb1486388934cea60d50265d43c0e1e7
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files are already linted by 'npm test'. For running only the
tests, there is no need to lint them first. If there are critical
syntax errors than Node will report these in a useful way either
way.
For quick feedback on the right style during development, one can
use an IDE plugin that provides it even quicker.
Alternatively, one could use 'eslint path/to/subset' to run only the
lint step. I've added a 'npm run lint' command to make this easier,
e.g. when iterating on the style for contributors without an IDE plugin
that want to confirm all lint failures from CI were addressed.
Change-Id: Ic09de49543e50cb5ade241b45741fbdb397f9954
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unil 2020-06-15 we were using Xvfb+ffmpeg to record videos.
In eed975d we have switched to wdio-video-reporter npm package.
It has never worked very well. It does not really record videos.
It creates screenshots and creates videos from them.
It does not record modal popups. Sometimes, it doesn't create a video
for a test at all.
I think it's time to switch back to Xvfb+ffmpeg. It has worked well. The
reason we moved to wdio-video-reporter was that it worked on all
platforms. That's not really important any more, since Xvfb+ffmpeg works
in a Fresh container.
Bug: T253113
Change-Id: I221775208576b6496f682ceefd6e6334db488bd4
|
|
|
|
| |
Change-Id: I378c3580668fe35e5341ddf10929618147c6eb35
|
|
|
|
|
|
|
|
|
| |
SVGO v2.x changed configuration to JS, amending configuration.
Adding new 'minify-svg' npm script.
Also re-crushing SVGs.
Bug: T278656
Change-Id: I1d746fca051cbc00900a05c33e8a401f95848930
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The jobs are running a subset of tests. (Tests containing string
`@daily` in the name.) To find the tests we are using
`--mochaOpts.grep` WebdriverIO command line option. The filter is
executed after the tests have already started. Since some test files
have no tests with string `@daily`, they are skipped. That results in
JUnit reporter creating a couple of empty XML files. Jenkins thinks
empty files are failures and fails the build.
This commit creates a suite of files that have tests with string
`@daily` and runs only those files.
Bug: T281505
Change-Id: Id844da81feac49f2a2b6820e98ead98d7e932e9f
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Devtools Service is "A WebdriverIO service that allows you to run
Chrome DevTools commands in your tests".
It was introduced in 2019 (1955a8a) but we are not using it.
For more information see:
https://webdriver.io/docs/devtools-service/
Bug: T280334
Change-Id: I718bd5bbcff56c294025f9e3f2fb3de67e1ed9c6
|
|
|
|
| |
Change-Id: Ia26ba71e1c41e7564ec60d78d4eb1492de7269d2
|
|
|
|
|
|
|
| |
We are no longer using Sauce Labs. Configuration was removed in ee14595.
Bug: T248221
Change-Id: I855597f43c91210662a155c4c549bda314361c00
|