| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
This way it can be subclassed in extensions, like AbuseFilter
(Ic755526d5f989c4a66b1d37527cda235f61cb437).
Bug: T188180
Change-Id: Idf320232011c72e39267b1f3c39848aea35d37fe
|
|/
|
|
|
| |
Bug: T101483
Change-Id: Ib1537cd92d733998818fe28b04ee81bec48a75d3
|
|
|
|
| |
Change-Id: I66b1775b7c1d36076d9ca78cbeb42787a743f2aa
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes most of the pre-CommentStore text columns, and the
$wgCommentTableSchemaMigrationStage setting that used to determine
whether the columns were used.
rev_comment remains in the code, as on Wikimedia wikis the revision
table is too large to alter at this time. A future change will combine
that with the removal of rev_user_text, rev_content_model, and
rev_content_format (and the addition of rev_comment_id and rev_actor).
CommentStore's constructor continues to take a $stage parameter, and
continues to have the logic for handling it, for the benefit of
extensions that might need their own migration process.
Bug: T166733
Change-Id: I1479c73774e01ead1490adf6128f820c09bce9d4
|
|\ |
|
| |
| |
| |
| | |
Change-Id: Ic92f43c9e9df2782ba20aa28ad9e6d2ef7976d2e
|
| |
| |
| |
| | |
Change-Id: Ib6847f7328f28f31141f3ae59f0f9a0f49dbf508
|
|/
|
|
|
|
| |
Add to foreign resource validation tool.
Change-Id: I06f5b2c258d1e72f2eb6268a6d24824bbe5d19eb
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So the conditional check should by default return $this->mDb if it's not
null, so, the else seems not to be needed(?). If we have a database handle
to process the current batch, $this->getDB() will return IMaintainableDatabase
but if it's not available (null), a call to $this->getDB() will return an
instance of \Wikimedia\Rdbms\Database is returned instead.
In accordance with the documentation (phpdoc), update the method getUserDB()
to be compliant with callers return type.
Change-Id: I95f3407dd2ffe8e4a1ad7a70be86b6cf3b65ff50
|
|
|
|
| |
Change-Id: Iac53864296990befe7c573a29dd2f35aca52a79e
|
|
|
|
| |
Change-Id: Ifa2892b2f38fa73362c3ac60e1d90614cdbc0a93
|
|
|
|
|
|
|
| |
These don't add any knowledge to what is already obvious from the
code, I find.
Change-Id: Ia613b6a059f78dbeefdfd020899bd1a6e239a731
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fixes the following error message when updating from an older database.
Renaming index il_from into PRIMARY to table imagelinks ...[7dbf1dd298ecf39128707744] [no req] Wikimedia\Rdbms\DBQueryError from line 1149 of /home/zok/mediawiki-1.30.1/includes/libs/rdbms/database/Database.php: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading?
Query: INSERT INTO imagelinks_tmp
SELECT * FROM imagelinks
Function: Wikimedia\Rdbms\Database::sourceFile( /home/zok/mediawiki-1.30.1/maintenance/sqlite/archives/patch-imagelinks-fix-pk.sql )
Error: 19 UNIQUE constraint failed: imagelinks_tmp.il_from, imagelinks_tmp.il_to
Explanation:
the "imagelinks" table used to have two fields: il_from and il_to.
At one point during the development of mediawiki a new field has been
added called il_from_namespace. This new filed is the second column
if the database is created from scratch, however if the database is
updated from an older version then the il_from_namespace column becomes
the 3rd column.
That means that some of the older databases will have the columns in the
following order:
(1) il_from, il_from_namespace, il_to
while some older ones, which have been updated will have the following
order:
(2) il_from, il_to, il_from_namespace
This shouldn't matter much, except the file modified in this commit
copies records from one table to another using the INSERT INTO ... SELECT
command without explicitly listing the column names.
The newly created table has the (1) order, but the source table
might sometimes have the (2) order.
Explicitly listing the column names solves all the issues.
Change-Id: I222b171495d14ae45339c4679e263f0ab610e826
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.30.2
Bug: T198231
Bug: T210862
Bug: T212806
Bug: T213137
Bug: T213199
Bug: T213507
Bug: T213517
Bug: T213544
Bug: T213574
Depends-On: Ic2163347ed522199ba3a9dbd5cb45b32e138cb5d
Change-Id: Ibb166a30adfa87225fec3e256450db55b71e0f14
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Update the Chinese conversion table routinely to fix bugs reported from https://zh.wikipedia.org/wiki/Wikipedia:%E5%AD%97%E8%AF%8D%E8%BD%AC%E6%8D%A2/%E4%BF%AE%E5%A4%8D%E8%AF%B7%E6%B1%82 .
It is only data changes and only works for Chinese WikiProjects.
Change-Id: I6d5b3c190411453673952c3557e2ea81dec885e6
|
| |
| |
| |
| | |
Change-Id: Ieff70f23b19f0be3670c4ed3e2a5c30ef3792d7f
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.30.1
Bug: T76638
Bug: T210847
Bug: T212977
Depends-On: Ib466527110d5068e297c42ebb3dd381c0c83754a
Change-Id: Ib466527110d5068e297c42ebb3dd381c0c83754b
|
|\ \ |
|
| | |
| | |
| | |
| | | |
Change-Id: I18313edf4fe9577fb488159b019689a450454b2f
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It was still looking for wfRunHooks, which no longer exists
as of MediaWiki 1.32.
After this, it is now able to find one bad hook:
> Unclear hook calls:
> - Hooks::run( $action . 'ArticleComplete', [ .. ] ); # SpecialEditWatchlist
Also, remove the matching of wfRunHooks generally, given it no
longer exists. And also remove the historic notes from hooks.txt.
Change-Id: I4ac52ed75fb99d7775d4b4755e3f0871003d70a8
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Use AuthManager::autoCreateUser when creating a new user via
createAndPromote.php so that configured AuthManager providers have
a chance to perform validations and extra actions beyond local account
creation.
Bug: T212689
Change-Id: I4972507bbaf65bb542934c281c37bd8a5c7a26b7
|
|\ \ \ \
| |_|/ /
|/| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
MariaDB really doesn't like the complicated OR in the join condition for
the actor table, it winds up scanning the whole actor table to find the
match. After trying several different options, the best bet seems to be
to use subqueries to get the actor_id.
MariaDB also doesn't like the DISTINCTed query for log_search, it gets
confused if the selected fields contain other fields much like it
historically gets confused when GROUP BY contains fields that are
constant in the WHERE clause. So we'll do the select from log_search in
a subquery and then join with actor, and inject the constant ls_field
into the rows as a constant field.
Bug: T188327
Change-Id: I979c040441f83bdf36e2f4031152559391233e5f
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Code and integrity from <https://code.jquery.com/qunit/>.
Release notes at <https://github.com/qunitjs/qunit/releases>.
Highlights for the browser version:
- [2.7.0] Reporter: Remove cost of DOM size when
using "hidepassed=true".
- [2.7.0] Reporter: Use perf.now() for improved accurracy
of unit test durations.
- [2.7.0] Reporter: Make debugging tests in a browser
easier by adding timeline markers for DevTools.
Highlights for the npm package / CLI version:
- [2.9.0] CLI: Reduce dependency tree size
from 143 packages to 9 packages.
Change-Id: I38408d90765cd18d5dd6952b8b6b30cbfa0c7ed5
|
|\ \ \ \
| |_|/ /
|/| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add a --status option which sets nonzero exit status for a query
returning or updating no rows. This is useful for shell scripts which
want to do simple existence checks (e.g. 'unless' conditions in Puppet)
or need to do a single-row change.
Change-Id: I3988c4fb24251dd8b33ac85aed9d0ae03eb0f910
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Bug: T201491
Change-Id: I8724206404a461eaace3b60f91c7704bd6581ee2
|
| |_|/
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.30.0
Bug: T150071
Bug: T150781
Bug: T183271
Bug: T190581
Bug: T196208
Bug: T208644
Bug: T208821
Bug: T210039
Bug: T210914
Bug: T211154
Bug: T211223
Bug: T212064
Bug: T212068
Bug: T212159
Bug: T212186
Bug: T212299
Bug: T212389
Depends-On: I00d3fa932de968019c6ad676237ed5e5077fb961
Change-Id: I00d3fa932de968019c6ad676237ed5e5077fb962
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Error messages should go to stderr not stdout.
Bug: T121597
Change-Id: Ibde26059982d1e621a104694343682a2032ac844
|
| | |
| | |
| | |
| | | |
Change-Id: I92dc906d0dfd870e6b77671e5d7cfd3f56090325
|
| | |
| | |
| | |
| | |
| | | |
Bug: T209525
Change-Id: I153607239145a772f5ea47eefd3340096a494b4b
|
| | |
| | |
| | |
| | |
| | |
| | | |
It's actually adding the column on the wrong table
Change-Id: I2fd8ea50f3eb4b5da04fce2ea0348a2dc6329965
|
|\ \ \
| |_|/
|/| | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The script already has waitForReplication(), that's good for non-WMF setups
Bug: T206568
Change-Id: I020a4472796eeff2561da6c17a817091d4e9af5a
|
|\ \ \
| |/ /
|/| /
| |/ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* return empty array when the query had no result (instead of
falling back into non-JSON mode)
* return JSON for write queries as well
* retain legacy behavior in non-JSON mode for empty SELECTs, just in
case somebody relied on it
Change-Id: Iaefbb443650a395278d1cc9ab6aa668b13b217c9
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
The columns dropped in this commit are:
* category.cat_hidden
(for MySQL, dropped in 1.20 / 0cbc85494d47cdeb)
* site_stats.ss_admins
(for MySQL, dropped in 1.21 / bd602d20833f435f)
* recentchanges.rc_cur_time
(for MySQL, dropped in 1.24 / 2b441eba406f2c49)
Bug: T64103
Change-Id: I7a7e9a2ac5066a9c9ab2583419d507e14fdd8c2c
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Update the Chinese conversion table routinely to fix bugs reported from https://zh.wikipedia.org/wiki/Wikipedia:%E5%AD%97%E8%AF%8D%E8%BD%AC%E6%8D%A2/%E4%BF%AE%E5%A4%8D%E8%AF%B7%E6%B1%82 .
It is only data changes and only works for Chinese WikiProjects.
Change-Id: Ib9ad77bd57dd55899ce685eb2023d1ee5c739e54
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Replace
if ( 42 === $foo )
by
if ( $foo === 42 )
Change-Id: Ice320ef1ae64a59ed035c20134326b35d454f943
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Remex is pure PHP so there is no reason to use an external tidy any
more. Configuration variables and implementation classes were
deprecated in 1.32 or earlier. We've kept only $wgTidyConfig
which can be used for experimental features or debugging Remex.
Bug: T198214
Change-Id: I99d48f858d97b6e1d1e6cd76a42c960cc2c61f9f
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.29.6
Depends-on: I1e584f5841b6004a4a02e4c324410cf0231ddb7a
Change-Id: If4b840b62a7792676caac5cf31e41a76650b945c
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Bug: T194163
Change-Id: I05d43510b51a67733b0107f0a768e261fe8ddabd
|