| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Change-Id: I5d3a5eb8adea1ecbf136415bb9fd7a162633ccca
|
|
|
|
|
| |
Bug: T125748
Change-Id: I2004d9b1fd7389623a3f2da6682f9007efd679dc
|
|
|
|
|
|
|
|
|
|
|
|
| |
* testCompression.php: Called $wgLang, but didn't set it.
It just assumed it was English. Use a local variable instead.
* update.php: Set $wgLang to English. Set main RequestContext as well.
* transstat.php: Rename $wgLanguages to $languages for less confusion.
It's just a local instance of language.inc's Languages class.
Change-Id: I67865f4d8710946001f7586ab0a17e125366b184
|
|
|
|
|
|
|
|
|
|
| |
Per wikitech-l consensus:
https://lists.wikimedia.org/pipermail/wikitech-l/2016-February/084821.html
Notes:
* Disabled CallTimePassByReference due to false positives (T127163)
Change-Id: I2c8ce713ce6600a0bb7bf67537c87044c7a45c4b
|
|
|
|
| |
Change-Id: I3bd8e7c4d2dca465957a353cb7dc2a906699ff6a
|
|
|
|
| |
Change-Id: I0e2aa83024b8abf5298cfea4b21bf45722ad3103
|
|
|
|
| |
Change-Id: I9ad6745d84506b736dae94747256caac89715899
|
|
|
|
|
|
|
| |
* Fix method calls to wrong classes
* Cleanup IDEA errors in static analysis
Change-Id: Ibd0fdb52db884abefb149f5340a4a4b5dad2c89b
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add transaction methods to complement getDB().
This makes it easy to grep for direct begin()/commit()
calls to IDatabase by having script use their own
wrapper. Maintenance scripts are one of the few places
that can (and need to) use begin/commit instead of the
start/end atomic methods.
Eventually, there should be almost no direct callers
and those methods can be made stricter about throwing
errors on nested calls.
Change-Id: Ibbfc7a77c0d2a55f7fc2261087f6c3a19061e0aa
|
|
|
|
|
|
|
| |
The double empty newline is not needed between functions, variable or at
end of file
Change-Id: Ib866a95084c4601ac150a2b402cfa184ebc18afa
|
|
|
|
|
|
|
| |
This allows empty lines inside the comment as found by the
MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.EmptyComment sniff
Change-Id: Iac155bbda4a84562db2b452baeae9b8973899453
|
|
|
|
| |
Change-Id: I5771af8135530677dc8223389f572896918c6b72
|
|
|
|
| |
Change-Id: I048ccb1fa260e4b7152ca5f09b053defdd72d8f9
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
wfSuppressWarnings() and wfRestoreWarnings() were split out into a
separate library. All usages in core were replaced with the new
functions, and the wf* global functions are marked as deprecated.
Additionally, some uses of @ were replaced due to composer's autoloader
being loaded even earlier.
Ie1234f8c12693408de9b94bf6f84480a90bd4f8e adds the library to
mediawiki/vendor.
Bug: T100923
Change-Id: I5c35079a0a656180852be0ae6b1262d40f6534c4
|
|
|
|
|
|
|
|
|
| |
Move the MWLogger PSR-3 logging related classes into the
MediaWiki\Logger namespace. Create shim classes to ease migration of
existing MWLoggerFactory usage to the namespaced classes.
Bug: T93406
Change-Id: I359cc81fbd2dcf8937742311dcc7d3dee08747b0
|
|
|
|
| |
Change-Id: Ib6e4914379568bfae32007f6e76968791798b08f
|
|\ |
|
| |
| |
| |
| |
| |
| | |
AutoLoader should take care of this.
Change-Id: Iabe335cd14e2739df9c184d6ab2e6ee98205b550
|
|/
|
|
|
|
| |
It causes a notice when moveToExternal.php is run
Change-Id: I50429742f87ab13a5428cbc282c2ce7eda37f714
|
|
|
|
|
|
|
| |
When a logging service other than MWLoggerLegacySpi is used, the
behavior of wfErrorLog is not guaranteed.
Change-Id: I8543bfd556aa752665f7a3daa855d3c2f7fc8956
|
|
|
|
|
|
|
|
|
|
|
|
| |
User::newFromID -> User::newFromId
Revision::newFromID -> Revision::newFromId
RecentChange::newFromID -> RecentChange::newFromId
WikiPage::newFromId -> WikiPage::newFromID
Title::newFromId -> Title::newFromID
Change-Id: I310f26653613951e9b21ce915a92d205a87937f1
|
|\ |
|
| |
| |
| |
| | |
Change-Id: I4d1a8c443cfa360c5d388364c580d48fa7124099
|
|/
|
|
|
| |
Bug: 71972
Change-Id: I16d6ffde113838fc431bffaf00be1574d5a0303a
|
|
|
|
| |
Change-Id: Ib26407bc55dff7969d8a3b1e2ae51751b202d8fb
|
|
|
|
| |
Change-Id: I6b58d014a4bfd6600e4e6f80188fdcfce18482ca
|
|
|
|
| |
Change-Id: Ia39b316e01797ddedd71885c2f05fe57ba4b89e9
|
|
|
|
|
|
|
|
|
| |
Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.
Also added some missing @param.
Change-Id: I727deec35a712de0f0c676cc87dfa661f1ee965b
|
|
|
|
|
|
|
|
|
|
| |
Removed version check for mysql from initEditCount.php and
storage/fixBug20757.php. Mediawiki needs MYSQL Ver 5.0.2 or
later, so the check is unnecessary.
Removed white spaces
Bug: 59126
Change-Id: I29e2ca8764fad8bf4d15bba307e80f3aacea1db7
|
|
|
|
|
|
|
|
|
|
|
| |
The Line continuation Coding conventions prefers the closing parenthesis
on the same line than the beginning curly braces. This is done for ifs
and functions.
Also move some boolean operator from the end of a line to the beginning
and changed some indentation to make the condition hopefully better
readable.
Change-Id: Id0437b06bde86eb5a75bc59eefa19e7edb624426
|
|
|
|
|
|
|
|
| |
- Removed trailing spaces in comments
- Removed multiple empty lines
- Removed space after object operator
Change-Id: I9fd3256ab490c7cd2034de3fd94e6be6e6d6d8f2
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Follows-up I1343872de7, Ia533aedf63 and I2df2f80b81.
Also updated usage in text in documentation and the
installer LocalSettingsGenerator.
Most of them were handled by this regex:
- find: (require|include|require_once|include_once)\s*\(\s*(.+?)\s*\)\s*;$
- replace: $1 $2;
Change-Id: I6b38aad9a5149c9c43ce18bd8edbab14b8ce43fa
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Squiz.WhiteSpace.LanguageConstructSpacing:
Language constructs must be followed by a single space;
expected "require_once expression" but found
"require_once(expression)"
It is a keyword (e.g. like `new`, `return` and `print`). As
such the parentheses don't make sense.
Per our code conventions, we use a space after keywords like
these. We appeared to have an unwritten exception for `require`
that doesn't make sense. About 60% of require/include usage
was missing the space and/or had superfluous parentheses.
It is as silly as print("foo") or return("foo"), it works
because keywords have no significance for whitespace between
it and the expression that follows, and since experessions can
be wrapped in parentheses for clarity (e.g. when doing string
concatenation or mathematical operations) the parenthesis
before and after basiclaly just ignored.
Change-Id: I2df2f80b8123714bea7e0771bf94b51ad5bb4b87
|
|
|
|
| |
Change-Id: Idd4299d17f1fcf98ab1d635484cb4e880f35ee24
|
|
|
|
| |
Change-Id: Id632867207960ba5c25d2b6eaba06f051fb1e681
|
|
|
|
|
|
|
| |
Added spaces before if, foreach
Added some braces for one line statements
Change-Id: I9657f72996358f8c1c154cea1ea97970d973723c
|
|
|
|
|
|
| |
Fix some other spacing while at it
Change-Id: I13f81533eaf40e06c13cf377c0f08ef5cef01d00
|
|
|
|
|
|
|
|
|
| |
And added/removed spaces around some other tokens,
like +, -, *, /, <, >, =, !
Fixed windows newline style
Change-Id: I0b9c8c408f3f6bfc0d685a074d7ec468fb848fc8
|
|
|
|
|
|
| |
Spotted in ipbreason-dropdown by Shirayuki.
Change-Id: I576ed4bc0abe5ab980aaee3fb9f9e4b43087311f
|
|
|
|
| |
Change-Id: Ied2f1bf7577e6afe1d09222ada6be54cedeec574
|
|
|
|
|
|
|
|
|
|
|
|
| |
By PSR2 PHP Standard, the files should ends with exactly one newline.
Some of our files have 2 or more and some other were missing a newline.
Fix almost all occurences of CodeSniffer sniff:
PSR2.Files.EndFileNewline.TooMany
I have not fixed the selenium files, I believe we will drop them.
Change-Id: I89fca8c1786fee94855b7b77bb0f364001ee84b6
|
|
|
|
| |
Change-Id: I87f059aaff72bf06ebc72ad3a7904cca8e11fab9
|
|
|
|
|
|
| |
(revision cbc28d41ae)
Change-Id: I44c6c20de0a6066e035b76b3d6d62f242a175c15
|
|
|
|
| |
Change-Id: I52ae3c55044bc8c53698e356bad74969406670bf
|
|\
| |
| |
| | |
Change-Id: Id4e0f40c03679c13d8934a6add99b5cd86d0437d
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Variables in classes should be declared using public $foo
instead of var $foo for various reasons. As we require PHP 5.3
we don't have to take care about that PHP4 left over, but can
get rid of it in favour of the more clear and better readable
public.
See also: http://php.net/manual/en/language.oop5.visibility.php
(Divided into several commits to keep reviewable)
Change-Id: Ic723d0347ab2e3c78bc0097345c68bbee3dc035a
|
| |/
| |
| |
| | |
Change-Id: Id86d06d3c22a69f7e378bf6e75b5c78ef8b47c51
|
| |
| |
| |
| |
| |
| | |
We can now do this since we finally switched to PHP 5.3 for MW 1.20 and get rid of the silly dirname(__FILE__) stuff :)
Change-Id: Id9b2c9cd2e678197aa81c78adced5d1d31ff57b1
|
| |
| |
| |
| |
| |
| |
| |
| | |
Was throwing Strict Standards: Declaration of OrphanStats::getDB()
should be compatible with that of Maintenance::getDB()
in maintenance/storage/orphanStats.php on line 25
Change-Id: I7451ada12a8c45aa37883b4b3803fbf505eec15b
|