| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \ \ \ \ \ \ \
| |_|_|/ / / / / / / /
|/| | | | | | | | | | |
|
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
Bug: T340552
Change-Id: Iae823c9cc632bdec59dedc70037ff677aa69875b
|
|\ \ \ \ \ \ \ \ \ \ \
| |_|_|/ / / / / / / /
|/| | | | | | | | | | |
|
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
We've had too many different things all named 'headline'.
This commit should have no functional changes.
Change-Id: I417370ab6b1b67c80e013e8c6fd70c600c18245e
|
|\ \ \ \ \ \ \ \ \ \ \
| |_|/ / / / / / / / /
|/| | | | | | | | | | |
|
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
Bug: T368113
Change-Id: I8d98d187ba4f1342167820b5710f5382b2ac4831
|
|\ \ \ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
Why:
Sometimes the verb will be something really generic like BEGIN.
https://phabricator.wikimedia.org/F58134893
Bug: T340552
Change-Id: I60dcc1cda332d4d64fb66b084bb7da582e7d1a3f
|
|\ \ \ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / / / /
|/| | | | | | | | | | | |
|
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
Example output:
https://phabricator.wikimedia.org/F58134893
Bug: T340552
Change-Id: Ib9ee43f1b10655a674f32339d5ec139e4551fa0a
|
|\ \ \ \ \ \ \ \ \ \ \ \
| | |/ / / / / / / / / /
| |/| | | | | | / / / /
| |_|_|_|_|_|_|/ / / /
|/| | | | | | | | | | |
|
| | |_|_|/ / / / / /
| |/| | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
First step in reworking storage of files metadata in the database
Bug: T368113
Change-Id: I6e79c47f9b6a191a3599db5f0a1a44e73b89be22
|
|\ \ \ \ \ \ \ \ \ \
| |_|/ / / / / / / /
|/| | | | | | | | | |
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Bug: T340552
Change-Id: I8f0f3d1729794f8df22f45cdb165821a6388dbb0
|
| |_|_|_|/ / / / /
|/| | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
When executed outside of test contexts, SplitGroupExecutor should
not require a ComposerSystemInterface for construction - the default
null argument should be replaced by a default object in the
constructor.
Change the SplitGroupExecutor constructor to provide a default
third argument.
Bug: T383054
Change-Id: I34020a7ee9e0f5411290e69684a8fc5ce92ab867
|
|\ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Mostly used find-and-replace:
Find:
/\*[\*\s]+@var (I?[A-Z](\w+)(?:Interface)?)[\s\*]+/\s*(private|protected|public) (\$[a-z]\w+;\n)((?=\s*/\*[\*\s]+@var (I?[A-Z](\w+)(?:Interface)?))\n|)
Replace with:
\3 \1 \4
More could be done, but to keep this patch reasonably sized, I only
changed the most obvious and unambiguously correct cases.
In some cases, I also removed redundant doc comments on the
constructor, and re-ordered the properties to match the constructor.
Change-Id: I3c1c59fe0ec660101429c5b7610887c66df4b9c8
|
| |_|_|_|/ / / / /
|/| | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Change-Id: I0387fdc3d99deb5e0c44c9090a7c9bc248929d3b
|
|\ \ \ \ \ \ \ \ \ |
|
| | |_|/ / / / / /
| |/| | | | | | |
| | | | | | | | |
| | | | | | | | | |
Change-Id: Ib5ef8ab213260284ca9e829ca3f47c8d7f9d86ca
|
|\ \ \ \ \ \ \ \ \
| | |_|_|_|_|_|/ /
| |/| | | | | | | |
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
* UserOptionsStore interface.
Follows-up If0b775d7ae (652d565584) for T323076, which introduced the
UserOptionsStore concept but it wasn't easy to figure out how an instance
is obtained, or how it relates to UserOptionsManager.
* User class.
Summarise the last 10 years of refactoring and decoupling, with
references to what we encourage new code to use instead.
Remove mention of MW 1.35 newable which is no longer applicable.
* Fix file headers and ingroup doc annotations
> Add missing `ingroup` to class blocks (and remove from file blocks)
> as otherwise the file is indexed twice (e.g. in Doxygen) which makes
> navigation on doc.wikimedia.org rather messy.
>
> Remove duplicate descriptions from file blocks in favour of class
> doc blocks. This reduces needless duplication and avoids incorrect
> or outdated copies emerging over time, and helps make file headers
> more consistently (visually) ignorable.
>
> Ref https://gerrit.wikimedia.org/r/q/message:ingroup+is:merged+owner:Krinkle+branch:master
Bug: T364652
Bug: T323076
Change-Id: I09fe4f64df88b5a83e7c934646467557f3af5fcd
|
|\ \ \ \ \ \ \ \ \
| |_|_|/ / / / / /
|/| | | | | | | | |
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Change-Id: Ic2bd012894ecf54dc6e8fb8bf52290ac560ccc16
|
|\ \ \ \ \ \ \ \ \ |
|
| | |_|_|_|_|/ / /
| |/| | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Why:
If tracing is enabled, but the sampling probability is <100%, we may
set a NoopSpan as the root span. Without this patch, the NoopSpan
cannot be activated, and thus creating child spans will fail with
PreconditionException.
This is a minimal patch to allow the NoopSpan to be activated, while
not affecting existing testing codepaths that don't require a root span.
Bug: T340552
Change-Id: Ib8a2d7b483190bba21a2f3b82fcd0e0b5756e750
|
|\ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Why:
- MimeAnalyzer needs ZipDirectoryReader, but it was not part of libs.
This was a problem because libs code must note depend on MediaWiki code.
Since there seem to be no other users of ZipDirectoryReader, the
simplest solution seems to be to move ZipDirectoryReader into the
Wikimedia\Mime library.
What:
- Moved ZipDirectoryReader and ZipDirectoryReaderError into
the Wikimedia\Mime namespace under includes/libs/mime.
Bug: T382910
Bug: T364652
Change-Id: Iccdade8dcd3211b7e2df2e50694da8d97c82b59e
|
|\ \ \ \ \ \ \ \ \ \
| |_|/ / / / / / / /
|/| | | | | | | | | |
|
| | |_|_|_|/ / / /
| |/| | | | | | |
| | | | | | | | |
| | | | | | | | | |
Change-Id: I484ce9391511a395ffeed4e4084d34f4c12cb8bd
|
|\ \ \ \ \ \ \ \ \
| |/ / / / / / / /
|/| | | | | | | | |
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
E_STRICT is deprecated in PHP 8.4.0.
MediaWiki (and almost all extensions) no longer produces errors at this
level.
To not break the compatibility, let's converts all E_STRICT level errors
to E_USER_NOTICE, which is also mapped to warning severity.
Using '@' operator to avoid generating the deprecation warning of
E_STRICT.
This should addresses the deprecation warning of E_STRICT when another
warning or error is raised.
Bug: T375707
Change-Id: I5937cacdf5b01614042a06d4deb5112ffff51727
|
|\ \ \ \ \ \ \ \ \
| |_|_|_|_|/ / / /
|/| | | | | | | | |
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Why:
Special:ListUsers can sort by temporary accounts by manually searching for the temporary account prefix. We can improve the UX by supporting this option out of the box.
What:
- Add an option to filter on temporary accounts if temporary accounts are known to the wiki
Bug: T373782
Change-Id: I802ad15e1ef5d90e12686f1cf636db27973986f5
|
|\ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
The hook is deprecated since I8ea56f2d111aeccee158c40b8379383e92154d8a
included in MediaWiki 1.43.
Change-Id: Icdf724fa2eeab10d4895fa1d45d7ff7320626c4e
|
|\ \ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
When there is nothing to insert,
do not create and execute the query builder
Avoid an exception when something is out of sync and no rows are found
Bug: T381643
Change-Id: Ie1201816d44a8f6263940647c8d1cc04fb272ac6
|
|\ \ \ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
…to indicate that it is a raw field.
Bug: T356971
Change-Id: I378f719df854e2ad62721fc0db8f488c47fa174b
|
|\ \ \ \ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | | |
These variables can be null at runtime (which the reason for
the isset() check plus doc comment plus phan annotation).
We can simplify all that if we just agree they can be null.
Change-Id: I3da7145eb90899dc4b21b8740f3a7c05ad98df0c
|
|\ \ \ \ \ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
Change-Id: Ib48af66a4eee79b6860402839707195dce7a8df7
|
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
The `mCode` property is set in the contructor and never changed
afterwards; it's guaranteed to be a string.
This change is not only for type safety, but also to simplify PHPUnit
tests: a return typehint allows PHPUnit to make the mocked method
return an instance of that type (instead of null) when the method is not
explicitly configured with `method()`. For a real example, see
I4d28a157aaeb4faa17f4785dccd3b591230b03d0.
Change-Id: I3293344d7e3376d9c18fd0c6372c636f5c9af881
|
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | |
When there is only one link for the editsection there is no need to
build the not-so-simple mw-editsection-divider span for the implode
Change-Id: I9ccefff812ff51297816b3aa8d9cb366f5478bf1
|
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ |
|
| | |_|_|_|_|/ / / / / / / / / /
| |/| | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | |
When there is nothing to insert,
do not create and execute the query builder
Bug: T381696
Change-Id: I3027601b28fb5d6274b7e04703d963a71dddfceb
|