| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
SiteConfig::$statsFactory is non-nullable, and
StatsFactory::withComponent() never returns null.
Change-Id: Ib14a1ee44b81476447717bc6aa00b54de1dca995
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Change-Id: I470b03c872979240806dfd4db6d1b6ca8284a263
|
|\ \ \ \ \ \ \ \ \
| |_|_|/ / / / / /
|/| | | | | | | | |
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
These use the new CdxMultiselectLookup component.
Values for the two inputs can be pre-filled with the
'wpPageRestrictions' and 'wpNamespaceRestrictions' URL parameters.
Tests to be added in a future patch (along with other tests around
partial blocks).
Bug: T362718
Bug: T362912
Bug: T368583
Change-Id: I53739bcdd63870fbfb57bc96298fc8d467bdfc2b
|
|\ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
php documentation:
If the size of post data is greater than post_max_size, the $_POST and
$_FILES superglobals are empty.
When the action= and format= are not in the GET data,
the help page is returned in html, breaking the clients expected format.
Return api error with http status 413
Bug: T291754
Change-Id: I5906fb6b4412b161b198df0b51e2476e7e1079b8
|
|\ \ \ \ \ \ \ \ \ \ |
|
| |/ / / / / / / / /
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Also for all sub-classes
Remove simple doc-blocks without further information
Change-Id: I981934efe32d44f52e5ab865a9b887be5bd0f41e
|
|\ \ \ \ \ \ \ \ \ \ |
|
| | |_|_|_|_|/ / / /
| |/| | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
* Skin::makeSearchInput has been deprecated @since 1.35
and was replaced with a final method on SkinTemplate
* Skin::makeSearchButton has been deprecated @since 1.39
- and was replaced with a final method on SkinTemplate
* SkinTemplate::buildContentNavigationUrls deprecated @since 1.38
and has no consumers.
* Merges the @internal makeSearchButtonInternal method into
makeSearchButton per deprecation note
Bug: T377521
Change-Id: I59c75d5636fc7958cc6ee4444f9c32d79fefa15d
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
- Replaced class properties with typed properties.
- Updated `$template` to `string`.
- Updated `$text` to `string`.
- Removed redundant type comments.
Change-Id: I53ff765949b8df978b189bd63306ed380a75c912
|
|\ \ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
- Replaced class properties with typed properties.
- Updated `$msg` to `string`.
- Updated `$lines` to `array`.
- Updated `$html` to `string`.
- Updated `$selected` to `?string` (nullable).
- Removed redundant type comments.
Change-Id: Iebfeda2a29d41cde0a0d7559757075973228bfa1
|
|\| | | | | | | | | |
| |_|_|_|_|/ / / / /
|/| | | | | | | | | |
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
- Added GNU GPL license header to ContributeCard, ContributeCardAction,
ContributeCardActionLink, ContributeFactory, and ContributeCardsHook
- Use typed properties in ContributeCard and ContributeCardAction
- Removed redundant docs for properties now using typed declarations
Change-Id: Ifb962f15fd08b2415e6877502b90db4ad1bdfcbe
|
|\ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / /
|/| | | | | | | | | |
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Transclude a special page can result in extra database queries,
track it as expensive operation to avoid to many usages on one page.
When the expensive function count is exceeded, the parser fallbacks to
display the transclusion as normal wikilink.
Change-Id: I86c9cf1fdd0833012ddbf51184080e3135eb83ec
|
|\ \ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
Use OutputPage::setIndexPolicy() so that we document the change in
behavior for OutputPage::setRobotPolicy() and emit deprecation
warnings as needed.
Bug: T377586
Change-Id: Ieab6a66b7ba868acf4da2d785a44a0307c0dacc1
|
|\ \ \ \ \ \ \ \ \ \ \
| |_|_|_|_|_|_|_|/ / /
|/| | | | | | | | | | |
|
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
Refactored slightly to use the new MetricTrait::setLabels() method
as well.
Change-Id: I4203c68d221630bc945a616544f80b05e40a1dad
|
|\| | | | | | | | | | |
|
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
Document that ::observeTiming takes an argument *in milliseconds*
(not seconds). Use the new Metric::setLabels() method to simplify
the implementation a bit as well.
Change-Id: I374ff380466cfc5c12abb24793e8a4ed195db382
|
|\ \ \ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
Why:
* ContributionsPager is being updated to allow subclasses greater
control over formatting. The $messages property holds a cache of
messages used for formatting, so is needed by subclasses.
What:
* Make the $messages property protected.
Bug: T377482
Change-Id: Ic3a475cc4fbd730f11a9c68972b89ac52094330c
|
|\| | | | | | | | | | | |
|
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
Why:
* Deleted revision authors are marked in the contributions line. The
visibility check uses the row's RevisionRecord. However, in some
subclasses there is no RevisionRecord, but visibility can be
determined from the row directly. A separate method allows
subclasses to perform this check.
What:
* Separate out the author visibility check into a new method.
Bug: T377482
Change-Id: I92074f28ff66266e574e743ccd57009589177f06
|
|\| | | | | | | | | | | |
|
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
Why:
* Each revision is displayed as a <li> with a data attribute
containing the revision ID. However, for subclasses that show
contributions from external wikis, it doesn't make sense to add
revision IDs to the HTML.
What:
* Make a separate method for populating HTML attributes, that can
be overridden by a subclass.
Bug: T377482
Change-Id: Ia22dde32071408798797b9f6f9f862ec5b57b2a4
|
|\| | | | | | | | | | | |
|
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
Why:
* A ContributionsPager can be configured to fetch only revisions,
or to display revisions and other types of contributions, added
by extensions. It avoids formatting rows from extensions. It
infers whether to skip by checking whether a RevisionRecord and
Title object could be made for the row.
* However, if configured only to fetch revisions, then it should
never skip the formatting, since every row is a revision.
What:
* Always execute ::formatRow if $revisionsOnly is true.
Bug: T377482
Change-Id: Ia7d4ab2abe4bef482ee8016ccbe4343977053611
|
|\| | | | | | | | | | | |
|
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
Why:
* ContributionsPager::doBatchLookups should skip a row if a
RevisionRecord can't be made. The check is hard-coded instead
of using the ::tryCreatingRevisionRecord method. This means that
if a subclass overrides ::tryCreatingRevisionRecord, the
override won't be used here.
What:
* Call ::tryCreatingRevisionRecord from ::doBatchLookups.
Bug: T377482
Change-Id: Ic6675e31a12360d81fc8f16029ec0e7b170ec32f
|
|\| | | | | | | | | | | |
|
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
Why:
* Formatting helper methods were introduced so that subclasses could
have more control of formatting their rows.
* These helper methods should take only the actual row as an argument,
since that is the only thing a subclass can guarantee is available,
e.g. it may not be possible to make a Title or RevisionRecord from
the row.
What:
* Pass only the row into the formatting helper methods.
Bug: T377482
Change-Id: Ic03b00bf93d25265cc162f57464f9d92d0a3c717
|
| |_|/ / / / / / / / /
|/| | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
Change-Id: I01d03aa6204a13a92bb8bc00364c822c27aa60b9
|
|\ \ \ \ \ \ \ \ \ \ \
| |_|_|/ / / / / / / /
|/| | | | | | | | | | |
|
| | |_|/ / / / / / /
| |/| | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Why:
- The JobQueue docs currently do not describe the
semantics of handling job execution failures.
- Some other features, such as job deduplication, enqueue semantics and
the overall execution flow, are also missing from the architecture
document.
What:
- Expand the JobQueue architecture document to describe how jobs that
return false from Job::run() or complete exceptionally are treated.
- Rework some preexisting sections of the same document for brevity.
- Describe JobSpecification and JobQueueGroup in the same document.
- Describe the different between push() and lazyPush() semantics.
- Describe the execution flow of a Job.
- Briefly summarize how job deduplication is expected to function.
Change-Id: Ib0c1f165feabefe862710b28977b598faf637ec5
|
|\ \ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
Bug: T296019
Change-Id: I8a8d499a6a6646bc86a4be7e843430eecd08d0a4
|
|\| | | | | | | | | | |
|
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
This is redundant with the same-named methods on ParserOutput.
Bug: T301020
Change-Id: I60455186e3a6e9b4329ff09e2f7ea920e2e05192
|
|\| | | | | | | | | | |
|
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
This is redundant with the same-named methods on ParserOutput.
Bug: T301020
Change-Id: I41dcca30e106f77d12d9afe780f8578a4f1c81c9
|
|\ \ \ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
.comment has a unicode-bidi: isolate; so this isn't needed.
It fixes yet other regression of
I919bb8270ddb13b38d747dba1a3a7fa0d3bb1a4f
Bug: T377555
Change-Id: Id60a7df155e550639004543026459b97eb01d840
|
|\ \ \ \ \ \ \ \ \ \ \ \
| | |/ / / / / / / / / /
| |/| | | | | | | | | | |
|
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
Bug: T301020
Change-Id: I0208d4670817c52c917e3fca680451a170330909
|
|\| | | | | | | | | | | |
|
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
Bug: T301020
Depends-On: I885f778eef92fa7d2b7d6a2c2997db6a8b0142e5
Change-Id: I3bfd47b078a5b84a88fffc04b48abe4c0023370f
|