| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/
|
|
|
|
|
|
| |
Since d0439af8, trying to view the login form while logged-in just
redirects to the 'returnto' address (or the main page), so this code
is unreachable.
Change-Id: I9ab8ab83172063d8facc491042832513d27f876b
|
|
|
|
| |
Change-Id: Ib585e32463765d7eb7d0be5dae54dc828ddd4ca9
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Upstream component from Flow
Adds mw-ui-input component
Update existing (and undocumented) usage in core of mw-ui-input to
use Flow focus style
Updated usage of mw-ui-input in Special:Search and Special:Userlogin
Packaged in mediawiki.ui.inputs to allow developers to use inputs
separately to other mediawiki ui components.
Change-Id: Ida765b97e6574bdc8fbba88a08ec98ec12f3dc95
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reinstates functionality removed in 44840d1.
There is no longer a default message, and must
be created on wikis locally.
Bug: 66574
Change-Id: Ife39fe868b46ef054101c2db2e4e901380998c0e
Co-Authored-By: Dan Poltawski <dan@moodle.com>
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Require use of class instead of applying styling to all <div>s
This resolves a few FIXMEs and dramatically lowers the awkwardness
level of using mediawiki.ui.
'.mw-ui-vform-field' is a more descriptive name than '.mw-ui-vform-div'
and corresponds to the HTMLFormField PHP class in core which generates
<div>s with this CSS class.
We previously styled '.mw-ui-vform > div' the same way we styled
'.mw-ui-vform .mw-ui-vform-div', which was an annoying piece of magic
causing difficult to debug problems when one needed a different HTML
structure (like bug 63233). Explicitly using '.mw-ui-vform-field'
where applicable is a lot saner.
Change-Id: I6f0b8842f5fdf70b97decb165086d1a83428b259
|
|
|
|
| |
Change-Id: I3b671616c1b110258389b5ebe10b5c2ca8c5835f
|
|
|
|
|
|
|
|
|
|
| |
We added these headings during the last account creation and login form
redesign but on recollection I'm not sure they're needed.
The messages are pretty much redundant with the h1 heading,
and now h2 elements have a margin-top of 1em it adds too much whitespace.
Change-Id: Ice5e8bf23cc00bf00835e7dc26acc33182654ec5
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Detailed rationale discussed on bugzilla, bug 53888 and parent,
where consensus on the design was gained.
Using https link per Brion et al. in comments and bug 54835,
with new keys for the messages in order to avoid any conflict
with existing messages. (The translations of the removed messages
will be automatically removed by localisation updates.)
https://www.mediawiki.org/wiki/Help:Logging_in was improved by Lloffiwr
and now also marked for translation. The link is ready for future
translations thanks to the use of the standard Special:MyLanguage, hence
the message is made ignored to allow customisations only locally.
Bug: 53888
Change-Id: I8cefafbcd3bd1d6a03cec7cf1d0efdf607fec21d
|
|\ \ |
|
| |/
| |
| |
| |
| |
| | |
Sometimes you really need to have a link (or two) in a checkbox message.
Change-Id: Ib75133cb1dfaa796c3acff6f4aa57eb25a806a0f
|
| |
| |
| |
| |
| |
| | |
Spotted by Lloffiwr and reported at
https://translatewiki.net/wiki/Thread:Support/MediaWiki:Pt-login/en
Change-Id: Ibfbe4abfbb29860c05ebaac83e2220f373940a59
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is done in addition to the server-side checks. Users who have
disabled JavaScript will not notice any difference.
The way this is done (via action=query&list=users API) means that we
can't check for all possible error conditions, both for the username
(e.g. these enforced by extensions like AntiSpoof) and other parts of
the form (e-mail, password…) – these are still handled server-side
only. Thus we intentionally never say that whatever the user typed in
is valid – we only warn when we know it's not.
Doing this "properly" would require some reworking of the internals of
the signup process and this way is already a huge improvement.
(Split off from the reverted a0c72523.)
Bug: 34447
Change-Id: I42c00b54651fd4e7217a862b3116c6113935f5ae
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit a0c72523c7a2c9ca16329f903ca6b269ccccb787.
which has terrible effects on mobile.
Most browser inputs on a mobile phone default to lowercase meaning
a username with a lowercase starting character will always trigger the
warning.
This means the user will have to re-enter their passwords, fill out the captcha
again and their email again (as all these are sensitive and not retained when
reloading the form with the warning)
If this is truly wanted on desktop, more thought it needed for the mobile use
case.
Bug: 61416
Change-Id: I8b93e5a4ca687f87305ced4343dcb28ca2909939
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The user name can be adjusted due to various technical restrictions:
the first letter is capitalized, underscores are changed to spaces,
numerous other less visible changes happen. Some of these tweaks can
be unwanted by some users.
Generate a warning if that happens. If the user has JavaScript
enabled, the check happens entirely client-side – a little warning box
is shown, the user doesn't have to do anything. Otherwise the check
happens server-side and the user has to resubmit the form.
The way this is done makes it trivial to also check if the username
is invalid or already taken, so let's do that. It also means that we
can't check for all error conditions, e.g. these enforced by
extensions – that is still handled server-side. (Client-side we
intentionally never say that whatever the user typed in is valid – we
only warn when we know it's not.)
API behavior is unchanged.
Co-Authored-By: umherirrender <umherirrender_de.wp@web.de>
Co-Authored-By: Bartosz Dziewoński <matma.rex@gmail.com>
Bug: 34447
Bug: 61416
Change-Id: Ic461a5e597ad71b854dc65bbf8a395c0f55d1fc3
|
|/
|
|
|
|
|
|
| |
Change check in WebStart to is_readable and output a different
text on NoLocalSettings template, when the file exists.
Bug: 61094
Change-Id: I4dbdb33e468bc731fa1d6eef8e0f66e1d552d0f8
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add personal tools messages for:
* login -- pt-login
* userlogout -- pt-userlogout
* createaccount -- pt-createaccount
Those messages shouldn't be used as personal tools messages.
Bug: 52861
Change-Id: I8fb229b15c4736945db46672b42a26fd7dafb5f6
|
|
|
|
|
|
|
| |
Also adjust related CSS styles
Bug: 60605
Change-Id: I87a16a8ee6d4968a0e2110c1ecdf0be9c99d8128
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new Agora ("beveled bottom") version deprecates mw-ui-primary.
* Use mw-ui-constructive (green) for Login, Create account, and Reset
password.
* Use mw-ui-progressive (blue) for Join <wiki> and Search.
A separate change I90954ea will implement right-aligned and quieter button layout.
Bug: 60596
Change-Id: Ia1fe557e7ebeac011c5da7297e848c1bfee7910f
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This was removed during the redesign of the login process in
I50f25583, but I found that 5-10% of non-wmf wiki sites used this
message to display notices, previously. We should keep this around or
at the very least provide advance notice for people.
Bug: 56455
Change-Id: I79423c1a05f0359c902d1940c3ffcd5e509dcf97
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Place commas correct
- Moved comments
- Add space after if/foreach/catch
- Reformat some conditions
- Removed trailing spaces/tabs
Change-Id: I40ccda72c418c4a33fcd675773cb08d971510cdb
|
|/
|
|
|
|
|
| |
There is no such thing as <select value="">. Use XmlSelect class to
properly build the selector instead.
Change-Id: If23071f29bf1ca8d7364453ec6c464127fecb509
|
|
|
|
|
|
| |
The Html class supports this handy shorthand.
Change-Id: Ie34790fa650c7ecad02c2d91130bf0db9172ea3f
|
|
|
|
|
|
| |
This file doesn't run any code, it just defines a class.
Change-Id: I92664e2c1a5617a28c0fb22c1d1fd99a46224a04
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A perceptive reviewer will note several issues with this code,
including at least one outright bug. I intend to fix them in
subsequent commit; I tried to avoid any non-whitespace changes
here to make it at all possible to review this.
This file has several lines longer than the phpcs limit of
100 characters, and several cases of the <?php } ?> pattern
phpcs complains about. I don't think it makes sense to enforce
these rules here; the code would IMO become less readable.
Change-Id: I95ab0f644fd5963878018f483f22e650867b5135
|
|
|
|
|
|
|
|
|
|
| |
* Show a warning about being already logged in above login form
* Show a button pointing to signup form with suitable explanation
Also changed some internal template stuff (s/createAnother/loggedin/).
Bug: 53306
Change-Id: I1672ee09330c231110c4db310a645d1382cc0b59
|
|
|
|
| |
Change-Id: Ie2e85af64aee164d6ddb8f6a10ead983ffc02ac5
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the user pref instead of the login form checkbox for setting up
cookie security on login.
The preferences menu is still broken (always shows checked, even if
preference has been turned off), but this will log the user in (over
https), and then redirect them back to http if they have selected to
not use https. Likewise, if they have the default preference to use
https, they get the forceHTTPS cookie and other cookies secure.
Change-Id: I08f67b35f355ef193ae86cb9cca3799e247ead4e
|
|
|
|
|
|
|
|
| |
userlogin-yourpassword and userlogin-resetpassword-link
appeared concatenated if the css wasn't available:
"PasswordReset your password"
Change-Id: I59049a3f1f912c45da89b1441661c3b725e1459b
|
|
|
|
|
|
|
|
|
|
| |
Removed the wpStickHTTPS checkbox from the login form, and instead
just use the user's preferences along with whether they came from
HTTPS or not to determine if they should stay in HTTPS.
Bug: 29898
Bug: 52283
Change-Id: I69e9cb23b8d700e821b8a961c672958e4e19e4f8
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Don't show the "Don't have an account? [Join <sitename>]" box to
logged-in users.
* Use different message for "Real name" (disabled on WMF wikis) when
creating another's account.
Also document showCreateOrLoginLink() and set its visibility.
Bug: 43172
Change-Id: I1b0bb6b78cbc5d37ef9f380a4bdf0f65d021a57f
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Detect a logged-in user creating an account for someone else and change
messages:
* heading is "Enter the new account information below."
* username placeholder is "Enter the username", not "Enter your username"
* email field placeholder is "Enter email address" not "Enter your ..."
* submit button is "Create another account"
Also improve JS when e-mail password is checked to remove the password
fields (otherwise the form still submits them and browser prompts to
remember password).
Bug: 47792
Change-Id: I00e0d21d63bf32ad691ea3a27523298478e2d45c
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* The "VForm" templates replace existing templates.
* Remove useNew switch logic and $wgUseVForm{UserLogin,CreateAccount}.
* The CSS and JS files for forms lose the .vform qualifier, except for
the CSS for styling vform elements.
* Merge tiny mediawiki.special.userLogin.signup.js into createAccount.js.
* Remove replaced and obsolete messages (see
https://www.mediawiki.org/wiki/Account_creation_user_experience/Strings
for details), and remove mention of "new" forms and useNew from
MessagesQqq.php.
Bug: 46333
Change-Id: I50f25583c3aa9a4a263fb40f50256f92c18ddb4d
|
|
|
|
|
|
|
|
|
| |
* Restore lost id=mw-user-domain-section (so wikitech can hide it).
* Remove obsolete pos-above class.
* Fix message key.
Bug: 49225
Change-Id: I73bcd44eff10a4fd2d1a392e82427e42e92fc3bf
|
|
|
|
|
|
|
|
|
|
|
|
| |
The separate icon floating left made the benefit text not request a
width, so the benefits column width was determined by the h2 "made by
people like you" heading and a short h2 could clip big numbers.
Now the icon is part of the background for the text div, and the column
width is the larger of h2 heading and benefits.
Bug: 48909
Change-Id: Iaf5fb1ccb4f50d34cad8a29b2bdd8f5b267ef008
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do not show the "(help me choose)" and "Can't see the image? _Request
an account_" links. They can still be customized on-wiki, but the
default value is empty.
The content and URLs that we encourage for these messages on WMF wikis
are now in extension WikimediaMessages (change I28b0079b).
Add comment to vform create account JavaScript.
Bug: 47801
Change-Id: Ie0888cd0582dc3f63ae569097159a4d9b171a5df
|
|
|
|
|
|
|
|
|
|
|
| |
* $wgHtml5 = false; is now ignored completely.
* $wgDocType and $wgDTD have been removed.
* $wgXhtmlDefaultNamespace is now ignored.
* XHTML5 will be output if $wgMimeType is set to an XML mime type (according to HTML5's rules).
* For backwards compatibility with extensions $wgHtml5 and $wgXhtmlDefaultNamespace are set
in Setup.php but depending on them is deprecated.
Change-Id: Iad9634e2ee420b5a3bbffe550421fde4fa1819b0
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Shorter "Reset your password" (new key userlogin-resetpassword-link).
Shorter "Use secure connection" (existing key userlogin-signwithsecure).
Better explanations.
Change-Id: Ia8e4219b200c25a61cbbade36841bb2c45cc9704
|
|/
|
|
|
|
| |
Removed parenthesis after echo
Change-Id: Ia533aedf63b11d15dcc6a5cf75a56134a4b11d86
|
|\ |
|
| |
| |
| |
| |
| |
| | |
Make it a little easier to tweak the number of benefits.
Change-Id: Icbd1f7738197be061b8b9f12c45024902e3bb2b8
|
|/
|
|
|
|
|
|
|
|
|
|
| |
* "Keep me logged in" (bug 47694)
* "[Create my account]" submit button (bug 47700)
* "Why you are creating another account" placeholder (bug 31888)
Bug: 47694
Bug: 47700
Bug: 31888
Change-Id: I7cfa4bb36368277a934144c1724ec437c426eacf
|
|
|
|
| |
Change-Id: Ie8adc00f4ee8ecec4554e584c18d5d2073415397
|
|
|
|
|
|
|
| |
new message createacct-error
Bug: 47691
Change-Id: I47d87858cd0e9dc3c668351283234388294872bb
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Similar to the login form (change 55847), this presents a compact
vertically-stacked form, if a global variable is set or if you add
?useNew=1 to the query string.
The redesigned create account form also:
* Removes the remember me checkbox (see bugzilla 47267)
* Displays some wiki statistics in a benefits column.
* Repositions the FancyCaptcha image if present using JavaScript (see
bugzilla 47372).
* Sets the template skin as in change 59577.
Bug: 44628
Bug: 47267
Change-Id: I9b03d519af43de147bff0ac509a1154f67cd3a0a
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also wrap it inside a section tag so the form's styling of gray labels
and full-width input fields doesn't apply to the CAPTCHA. The same fix
is in the new Create account form (though that uses JavaScript to
reposition the FancyCaptcha image).
CSS gives the section a small bottom margin to space it from the form
contents, small enough to not affect form layout if there is nothing
in the template header.
Bug: 47371
Change-Id: I1523fe6551585ba731b0ca4207e22d614d0a46d8
|