Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Add $conds parameter to ModifyExportDisplayQuery hook | Tim Starling | 2020-05-05 | 1 | -3/+8 |
| | | | | | | | | | | | | | | | | | Since I8d825eb02c69cc66d90bd41325133fd3f99f0226, modification of the $cond parameter to the ModifyExportDisplayQuery hook has had no effect, since $cond is now incorporated into a condition array $conds. This seems contrary to the purpose of the hook, although no extension in CodeSearch actually depends on it. It was also a documentation error, with the incorrect type on the interface causing a Phan error in the HookRunner call site migration patch. So, add a $conds parameter to the hook, which allows modification of the array, and fix the documentation. Change-Id: Id4608cec35df56456d7dad4de107bbef816e964b | ||||
* | docs: Hook interface doc comment review | apaskulin | 2020-04-21 | 4 | -22/+31 |
| | | | | | | | | Edited doc comments for hook interfaces to improve consistency and add type hints. Bug: T246855 Change-Id: I38fa802463cd6f39bf5946dbbeb1b3ebaea604b2 | ||||
* | Automatically generated hook interfaces | Tim Starling | 2020-04-20 | 4 | -0/+95 |
Add hook interfaces which were generated by a script which parses hooks.txt and identifies caller namespaces and directories. Hook interfaces are mostly placed in a Hook/ subdirectory relative to the caller location. When there are callers in multiple directories, a "primary" caller was manually selected. The exceptions to this are: * The source root, maintenance and tests, which use includes/Hook. Test hooks need to be autoloadable in a non-test request so that implementing test interfaces in a generic handler will not fail. * resources uses includes/resourceloader/Hook * The following third-level subdirectories had their hooks placed in the parent ../Hook: * includes/filerepo/file * includes/search/searchwidgets * includes/specials/forms * includes/specials/helpers * includes/specials/pagers Parameters marked as legacy references in hooks.txt are passed by value in the interfaces. Bug: T240307 Change-Id: I6efe2e7dd1f0c6a3d0f4d100a4c34e41f8428720 |