aboutsummaryrefslogtreecommitdiffstats
path: root/includes/diff
Commit message (Collapse)AuthorAgeFilesLines
* Use namespaced classesUmherirrender2024-10-216-0/+9
| | | | | | | Changes to the use statements done automatically via script Addition of missing use statement done manually Change-Id: I73fb416573f5af600e529d224b5beb5d2e3d27d3
* Deprecate OutputPage::{get,set}PreventClickjacking()C. Scott Ananian2024-10-171-4/+5
| | | | | | | This is redundant with the same-named methods on ParserOutput. Bug: T301020 Change-Id: I60455186e3a6e9b4329ff09e2f7ea920e2e05192
* Use explicit nullable type on parameter argumentsUmherirrender2024-10-164-5/+5
| | | | | | | | | | | Implicitly marking parameter $... as nullable is deprecated in php8.4, the explicit nullable type must be used instead Created with autofix from Ide15839e98a6229c22584d1c1c88c690982e1d7a Break one long line in SpecialPage.php Bug: T376276 Change-Id: I807257b2ba1ab2744ab74d9572c9c3d3ac2a968e
* Add namespace to remaining parts of Wikimedia\Mime and Wikimedia\StatsJames D. Forrester2024-09-271-0/+1
| | | | | Bug: T353458 Change-Id: If0137003ab625017d322d57870448a02569668c3
* Add missing documentation to class properties (frontend-related)Umherirrender2024-09-051-0/+1
| | | | | | | | | | Add doc-typehints to class properties found by the PropertyDocumentation sniff to improve the documentation. Once the sniff is enabled it avoids that new code is missing type declarations. This is focused on documentation and does not change code. Change-Id: Id75cb2e5fbee0fe7600f92473d876f23730d46b7
* Move Language and friends into Language namespaceJames D. Forrester2024-08-102-2/+2
| | | | | Bug: T353458 Change-Id: Id3202c0c4f4a2043bf97b7caee081acab684155c
* Drop writeapi userrightReedy2024-07-311-3/+1
| | | | | | Bug: T294397 Depends-On: Ib34228a18917e404517d45e539bd786419d9c401 Change-Id: Ifad2edc782b36d21c8c67fecde7f011dce02c11b
* diff: migrate TextSlotDiffRenderer to use StatsFactoryCole White2024-06-281-5/+19
| | | | | Bug: T359241 Change-Id: I4f443b004b9ed77b9e6b8b1144d0cc2847a55d16
* Merge "Use namespaced classes (1)"jenkins-bot2024-06-182-0/+2
|\
| * Use namespaced classes (1)Umherirrender2024-06-162-0/+2
| | | | | | | | | | | | | | Changes to the use statements done automatically via script Addition of missing use statement done manually Change-Id: Ic4d4dd61de5ab896fb6173eb579c81f164a1e4a3
* | diff: Mark TextSlotDiffRenderer DI setters as `@internal`Timo Tijhof2024-06-151-0/+2
|/ | | | | | For use by I4f443b004b9ed7 (T359241). Change-Id: If6acfb4fbb041dc13c7b4ccfaae4abd6f5b9b550
* Merge "Add namespace and deprecation alias to TextContent"jenkins-bot2024-05-201-0/+1
|\
| * Add namespace and deprecation alias to TextContentEbrahim Byagowi2024-05-191-0/+1
| | | | | | | | | | | | | | | | | | This patch introduces a namespace declaration for the MediaWiki\Content to TextContent and establishes a class alias marked as deprecated since version 1.43. Bug: T353458 Change-Id: Ic251b1ddfcf6db9c85cb54cddf912aa827d2bc3a
* | Import InvalidArgumentException at top of the sourceEbrahim Byagowi2024-05-192-3/+5
|/ | | | | | | | | | | | | | It was asked in a patch review to apply fully import InvalidArgumentException where possible. I was guessing some of my other already merged patches have but turned out such thing exists other places style so for the sake of consistency I've turned rest of inline import of the specific exception at top of the file. There are instances of source files that aren't in any namespace but have fully qualified import which this patch doesn't touch. Change-Id: I4071fc698b65746d9594cf4d5f45bae82843d436
* Merge "Metrics: Migrate MediaWiki.diff_cache.* to statslib"jenkins-bot2024-05-101-4/+12
|\
| * Metrics: Migrate MediaWiki.diff_cache.* to statslibLarissa Gaulia2024-05-041-4/+12
| | | | | | | | | | Bug: T359240 Change-Id: Iec49ddac0f7b24ad45b7a25e5832c91f5ee55214
* | Add namespace and deprecation alias to DeprecationHelperHakan Özdemir2024-05-051-0/+1
|/ | | | | | | | | This patch introduces a namespace declaration for the MediaWiki\Debug to DeprecationHelper and establishes a class alias marked as deprecated since version 1.43. Bug: T353458 Change-Id: I808c6aa7836445feaa7b401624d79d01f2c70322
* Always show patrol link regardless of whether in diff-only modeJon Robson2024-02-221-8/+3
| | | | | Bug: T357693 Change-Id: I93736bd8ca4cc69cb89023d83872dcc3d71694a5
* diff: Change order of inline diff legend elementsSam Wilson2024-02-151-1/+1
| | | | | | | | To match the order that's used within the diff (deleted followed by inserted). Bug: T357150 Change-Id: I80dd954e8bfb699280dcf5791cc16e153b291e17
* Diffs: Always render patrol link in HTML and hide via CSSJon Robson2024-02-121-9/+15
| | | | | | | | | | | | The mobile site has traditionally shown the patrol link to all mobile users. The diff HTML is updated to allow skins to have opinions on whether the patrol link is displayed or not. By default it is hidden which is the status quo. Bug: T357213 Change-Id: I71eed29aed22b79367286c1761cf744a83609967
* build: Upgrade mediawiki/mediawiki-phan-config from 0.13.0 to 0.14.0 manuallyJames D. Forrester2024-02-101-3/+3
| | | | | | | | | | | * Switch out raw Exceptions, mostly for InvalidArgumentExceptions. * Fake exceptions triggered to give Monolog a backtrace are for some reason "traditionally" RuntimeExceptions, instead, so we continue to use that pattern in remaining locations. * Just entirely give up on PostgresResultWrapper's resource vs. object mess. * Drop now-unneeded false positive hits. Change-Id: Id183ab60994cd9c6dc80401d4ce4de0ddf2b3da0
* Namespace includes/contextJames D. Forrester2024-02-084-1/+6
| | | | | Bug: T353458 Change-Id: I4dbef138fd0110c14c70214282519189d70c94fb
* Change more uses of getDBLoadBalancerFactory() to getConnectionProvider()Bartosz Dziewoński2024-01-231-1/+1
| | | | | | | | | | | Some less trivial cases. Also update variable names. This doesn't really change anything, but I hope it helps promote getConnectionProvider() as the common way to do this. Follow-up to 8604c384f624273f46b653ec252ffaed30e6ff89. Change-Id: I6657d783375fac5c7fa856b884ff1fb09285e94c
* PoolCounter: Namespace classesAmir Sarabadani2023-12-201-0/+1
| | | | | | | | Two of the classes in this directory have already namespaced to MediaWiki\PoolCounter. Bug: T353458 Change-Id: Ie41f8d935f7623bb40040a5eb78f99c6d7b7b75e
* Namespace ParserOutputJames D. Forrester2023-12-141-1/+1
| | | | | | | Most used non-namespaced class! Bug: T353458 Change-Id: I4c2cbb0a808b3881a4d6ca489eee5d8c8ebf26cf
* Use namespaced classesUmherirrender2023-12-111-0/+1
| | | | | | | Changes to the use statements done automatically via script Addition of missing use statements and changes to docs done manually Change-Id: I443aada1c18c8628b02671aa9fd6f441961e5c2e
* Move user options related classes into its own namespaceMartin Urbanec2023-11-291-1/+1
| | | | | | | | | | | | | There are a couple of user options related classes already, and the T321527 work on dynamic defaults is going to add even more. Let's move them into a separate namespace to make core a bit more organized. Old name is kept as an alias for compatibility purposes. Bug: T321527 Bug: T352284 Change-Id: I9822eb1553870b876d0b8a927e4e86c27d83bd52
* diff: Fix LinkRenderer method callAmmarpad2023-10-251-0/+1
| | | | | | Bug: T349726 Follow-up: Ie8ac1aab6d2fe5f4575a6891c36efe497458e093 Change-Id: Ibd728d171ce7e821f9a67131ad466d779681fe49
* Diffs: Use JS friendly data timestamp instead of mediawiki timestampJon Robson2023-10-231-3/+8
| | | | | | | | | | | This is more useful for JavaScript clients. Follow up to 7f554fc74 The diff timestamp is also moved to its own HTML element to account for hidden revisions. Bug: T240624 Change-Id: Ie8ac1aab6d2fe5f4575a6891c36efe497458e093
* Merge "DifferenceEngine: Wrap edit, undo thank link tools with CSS parentheses"jenkins-bot2023-10-171-3/+2
|\
| * DifferenceEngine: Wrap edit, undo thank link tools with CSS parenthesesJon Robson2023-10-171-3/+2
| | | | | | | | | | | | | | This allows other skins to skin these differently. Bug: T240624 Change-Id: I3232c2f5075ae6ef2ba5a1bdcd63530461919b6f
* | Merge "DifferenceEngine: Add user meta information on diff pages"jenkins-bot2023-10-171-2/+73
|\ \
| * | DifferenceEngine: Add user meta information on diff pagesJon Robson2023-10-171-2/+73
| |/ | | | | | | | | | | | | | | | | This will be used to consolidate the mobile and desktop diff pages. This useful information could also be incorporated into desktop skins at a future date. Bug: T347779 Change-Id: If1f6f75ea829e8754fc51c7c15a2f47ad16dba52
* / TextSlotDiffRenderer: show tooltip instead of help icon on inline switchMusikAnimal2023-10-171-2/+3
|/ | | | | | | Also add to the switch itself, not just the label Bug: T346429 Change-Id: Ia7319a63878e029765c08a44f890fe96205c35da
* Remove meaningless /** #@- */ commentsthiemowmde2023-10-151-2/+0
| | | | | | | | | | | Some of these comments are more than 20 years old. Almost all of them are copy pasted from somewhere else, most certainly without knowing what they mean. I can only guess that they have been part of some ancient code folding feature that's not supported any more. Even if, almost all of them are misplaced by now because the surrounding code changed without updating the comments. Change-Id: I53c37f050574a530ec772b7a07b67d84b31bb7a0
* diff: add help message to inline switchhmonroy2023-10-131-1/+2
| | | | | | | | | | Add help message that explains what the inline toggle does when you click it. Remove 'diff-table-format-label` text since it is not being used. Bug: T346429 Change-Id: Idc3aefffd03d491a573b27c7e18b337f68bbc9cf
* Merge "DifferenceEngine: Separate previous/next from diff itself"jenkins-bot2023-10-111-2/+26
|\
| * DifferenceEngine: Separate previous/next from diff itselfJon Robson2023-10-101-2/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Having these controls in the diff makes it very difficult to adapt the diff page for mobile screens. It is proposed we add links at the top of the diff page, that are initially hidden. These will initially be used in Minerva skin and possibly upstreamed at a later date for all skins. Change: * Add previous / next breadcrumbs at top of diff page Bug: T347780 Change-Id: Iae6c140cde54d807204e6d2b8c7b6599f75df89e
* | Merge "DifferenceEngine: Comments on diff page should be themeable"jenkins-bot2023-10-101-2/+6
|\ \
| * | DifferenceEngine: Comments on diff page should be themeableJon Robson2023-10-041-2/+6
| |/ | | | | | | | | | | | | | | | | | | Remove hardcoded parentheses in favor of CSS pseudo elements to support different display in different skins. There should be no visual change in any skin with this change. Bug: T117279 Change-Id: Iaea122647893acfa405d413e851e14949fb4b8d3
* | Merge "DifferenceEngine: Make timestamps data readable"jenkins-bot2023-10-101-1/+3
|\ \
| * | DifferenceEngine: Make timestamps data readableJon Robson2023-10-041-1/+3
| |/ | | | | | | | | | | | | | | | | The Minerva skin renders a relative timestamp. Having this data attribute available will allow the Minerva skin to render a relative timestamp on this page. Bug: T117279 Change-Id: Ib66de95bdeca6e9bfa082889f0ed0740dbf8639f
* / diffs: add line number headings to inline diffsMusikAnimal2023-10-093-5/+18
|/ | | | | | | | | | | | | | Adds new regex in BaseTextDiffer::localizeLineNumbers() to work with wikidiff2 inline diffs as well as table diffs. Since there are no "columns" in inline mode, we have a new message to indicate how the line numbers changed from the old diff versus the new. Deprecate DifferenceEngine::localiseLineNumbers() as no longer used and redundant to BaseTextDiffer::localizeLineNumbers(). Bug: T346460 Change-Id: I7b195879b677e2242ad73070fe19ad82121576a8
* Merge "DifferenceEngine: Distinguish between table and inline diffs"jenkins-bot2023-09-291-0/+4
|\
| * DifferenceEngine: Distinguish between table and inline diffsJon Robson2023-09-291-0/+4
| | | | | | | | | | | | | | | | Having a different class on the diff allows different styling in the different contexts. Bug: T117279 Change-Id: I32fc945dac113453351c07bd75fbf2835e616ce2
* | SECURITY: DifferenceEngine: hide diff-multi-sameuser message for supressed ↵Maryum Styles2023-09-291-1/+11
|/ | | | | | | | | | | revisions CVE-2023-PENDING reduce the edit count if a user for a given revision is suppress-deleted Bug: T341529 Change-Id: I79539464cf3500065cb4f42e1542ff5feec31395
* Add first batch of taint-check annotationsDaimona Eaytoy2023-09-231-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | These are the same as taint-check's MediaWikiSecurityCheckPlugin.php. The notable exception is methods in WebRequest that were previously hardcoded as returning a safe value. This was a consequence of said methods return safe types (e.g., int, bool). Instead of adding taint-check annotations, add return typehints instead, which let taint-check remove any taintedness. Fix some taint-check issues that were previously not spotted or whose suppressions were removed in other patches. Also fix the following bugs spotted by phan thanks to the type hints: - SpecialExport did not have explicit handling of null $depth, and just returned 0 because null fails both the < and the > comparisons. - Improve documentation of params and props in ProtectedPagesPager. SpecialProtectedPages can pass null $namespace and $size. - Remove unused parameter from SpecialProtectedPages::showOptions, of which $ns and $size were not documented as nullable. - Add FIXMEs in SpecialVersion about very inconsistent escaping. Bug: T321806 Change-Id: I726f528856614c92329683a0ad8936a42e262748
* Namespace User under \MediaWiki\UserJames D. Forrester2023-09-191-1/+1
| | | | | Bug: T166010 Change-Id: I7257302b485588af31384d4f7fc8e30551f161f1
* Merge "Use OutputPage::setPageTitleMsg() instead of ::setPageTitle()"jenkins-bot2023-09-191-4/+8
|\
| * Use OutputPage::setPageTitleMsg() instead of ::setPageTitle()C. Scott Ananian2023-09-181-4/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Passing a Message argument to OutputPage::setPageTitle() is deprecated, because the message is not properly HTML-escaped by default. Use ::setPageTitleMsg() instead wherever the message doesn't include HTML metacharacters. Also protect arguments with Message::plaintextParams() where appropriate. Bug: T343994 Bug: T343849 Change-Id: Iba67d008545249772c136c5d6d302110516d3b94
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-22 02:34:25 +0000