| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
deprecated since 1.34 and unused.
Bug: T249031
Change-Id: I6003c56f07469ffe796ccb415bb4d1e5ff8993a9
|
|
|
|
|
|
|
| |
deprecated since 1.28 and unused.
Bug: T249034
Change-Id: Ib21d994bf31e14f650a8684628d0b1542085c877
|
|
|
|
|
|
| |
Just an auto-replace from codesniffer for now.
Change-Id: I5240dc9ac5929d291b0ef1c743ea2bfd3f428266
|
|
|
|
|
| |
Bug: T278459
Change-Id: I7ed97f868f2a8a505ca4e529036d7efce6eea3ae
|
|
|
|
|
| |
Bug: T249230
Change-Id: I8fb43e862a19031520dda5a147e533becd7eb89e
|
|
|
|
|
|
|
|
| |
We still rely on Title internally, until the logic for mapping Titles to
URLs has been factored out.
Bug: T279796
Change-Id: I6abf30b8359fbe306c569ea290a64ed0d4105d71
|
|
|
|
|
| |
Bug: T278459
Change-Id: I77fb37c1aec17d3e51056f85fdff59821f326cc3
|
|
|
|
|
| |
Bug: T277987
Change-Id: Iafc4b3e3137936046487119b7e17635f4e560277
|
|
|
|
|
|
|
|
|
| |
This has effectively been the case since 1.35; this just cleans up the
remaining code which assumed it still needed to explicitly call
Parser::firstCallInit() on a newly-constructed Parser.
Bug: T250444
Change-Id: I340947c721172f12ff413322b4283627c0b0b3a4
|
|
|
|
|
|
|
| |
User::isValidUserName is deprecated since 1.35 and should be replaced with the UserNameUtils service
Bug: T277398
Change-Id: Iaef995b992e2f38f651453092b23c928479e7d18
|
|
|
|
|
|
|
|
|
| |
This is micro-optimization of closure code to avoid binding the closure
to $this where it is not needed.
Created by I25a17fb22b6b669e817317a0f45051ae9c608208
Change-Id: I0ffc6200f6c6693d78a3151cb8cea7dce7c21653
|
|\ |
|
| |
| |
| |
| | |
Change-Id: I3519dd5a1ce1ea688de602190cd74755c400c717
|
| |
| |
| |
| |
| |
| | |
Bug: T249230
Depends-On: Ia2c6e93595905e6143cccede8478a6aac8dbf567
Change-Id: I749be35d784481671936c5ba037945f3b9ee2c4f
|
|/
|
|
|
|
|
|
| |
* Remove incorrect null type from documentation of properties
that cannot be null.
* Add type doc for $caller and $data
Change-Id: I8d51dca7fd4910acf744361279c441fe4c3a4307
|
|
|
|
|
| |
Bug: T249019
Change-Id: Id0d368dc8fda78465806215a46b06022bc658b85
|
|
|
|
| |
Change-Id: I6c79531691be0f80bdcfe9141ff6cc31ee9b91f9
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
These are mostly easy fixes. Tests were fixed when that didn't require
any change to the tested code, and moved to /integration otherwise.
MediaWikiUnitTestCase::setTemporaryHook was removed: the
caller should provide a HookContainer, at which point it would just
become a useless wrapper around HookContainer::register. (We don't
really need it to be temporary, if proper DI is used).
The method was only used in the tests touched by this commit.
Change-Id: I2aba02560c41b77eea9dd4bff0e4d1c4bb0da9a2
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
This includes fixing some mistakes, as well as removing
redundant text that doesn't add new information, either because
it literally repeats what the code already says, or is actually
duplicated.
Change-Id: I3a8dd8ce57192deda8916cc444c87d7ab1a36515
|
| |
| |
| |
| |
| |
| |
| |
| | |
unset() does not throw an error if the value to be unset does not exist
in the first place, so guarding it with an isset() check is unnecessary.
Remove a few ifs that didn’t do anything else.
Change-Id: Ie5493c8a4c4d25e12a029d0257374527cd12303d
|
| |
| |
| |
| | |
Change-Id: I082b95bf0dcf3625f3c71689e78643b55238b5f8
|
| |
| |
| |
| |
| |
| | |
Reformat existing documentation to match the format
Change-Id: I190b54b5e962f17bab6502dd1b3c02f11dc926d2
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For example, documenting the method getUser() with "get the User
object" does not add any information that's not already there.
But I have to read the text first to understand that it doesn't
document anything that's not already obvious from the code.
Some of this is from a time when we had a PHPCS sniff that was
complaining when a line like `@param User $user` doesn't end
with some descriptive text. Some users started adding text like
`@param User $user The User` back then. Let's please remove
this.
Change-Id: I0ea8d051bc732466c73940de9259f87ffb86ce7a
|
|
|
|
|
| |
Bug: T253061
Change-Id: Id951177712648dc5ac684ae38097a0e9f3e12c7a
|
|\ |
|
| |
| |
| |
| |
| | |
Bug: T258665
Change-Id: Ifddbf57f8aa2e3eb0d5845601376cbafa08ed407
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| | |
Use RequestContext::getMain(), since we only need the context user's
name
Bug: T254702
Change-Id: I48a77904a173a06c5ec3d1e9e33193a0bf4ef5d6
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This saves two queries per local overridden message when filling the
cache
(one from RevisionStore::loadSlotRecords, one from
SqlBlobStore::fetchBlobs)
Remove 'user' join, as nothing is getting user information from this
records. Join against comment and actor also not needed, but there is no
option to avoid the join.
Change-Id: Ieb5086f81310092f573ef95d997bf0bc99c30952
|
|\ \ |
|
| |/
| |
| |
| |
| |
| | |
Avoid use of global loadbalancer
Change-Id: I4991e9501cef4fd294d9cae197b31080ca907d45
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Follows-up 6e2be46e828 (Idaa8552cf37), which allowed canonical
action=raw URLs to be long-cached by the CDN and have them be
purged on-edit alongside the view and history URLs.
In reviewing that, I mistook isJsSubpage() as checking both
NS_USER and NS_MEDIAWIKI js pages. This method name was renamed
to isUserJsConfigPage() which made the omission more obvious.
Bug: T261371
Change-Id: Ic22b5f39ce4e1a9f074833f9e4e626e3999465dd
|
|/
|
|
|
|
|
|
| |
These were never meant to be part of the public interface and should not
ever have been marked with @since. They're only useful for constructing
the respective objects, which no outside users should be doing.
Change-Id: I86e01272d46fc72af32172d8a12b9180971d4613
|
|\
| |
| |
| | |
definitely an integer"
|
| |
| |
| |
| |
| |
| | |
integer
Change-Id: I8fede00dfe1270d93c5d78d3c36e788cddfc8a99
|
|/
|
|
|
|
| |
It is easier to read.
Change-Id: Ia3965b80153d64f95b415c6c30f526efa252f554
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It caused a 20% latency regression by unconditionally parsing extension.json
files on every single load instead of using the existing caching
infrastructure. There are further problems with the use of parsing/loading
extension.json files in a method that is incompatible with the existing
architecture.
This primarily reverts commit 46eabe275c923ca7827435a36d6576150cea8899.
Also needed to revert 16381261ae and 7c72347ec1.
Bug: T258664
Change-Id: I34a783c3f0df0447876a26441bb2d12e02368871
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
For compliance with the new version of the table interface policy
(T255803).
This patch was created by an automated search & replace operation
on the includes/ directory.
Bug: T257789
Change-Id: I17e5e92e24c708ffc846945a136347670a3a20c7
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
For compliance with the new version of the table interface policy
(T255803).
This patch was created by an automated search & replace operation
on the includes/ directory.
Bug: T257789
Change-Id: Ie32c1b11b3d16ddfc0c83a757327d449ff80b2e4
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
For compliance with the new version of the table interface policy
(T255803).
This patch was created by an automated search & replace operation
on the includes/ directory.
Bug: T257789
Change-Id: If560596f5e1e0a3da91afc36e656e7c27f040968
|
|/
|
|
|
|
|
|
|
|
|
| |
For compliance with the new version of the table interface policy
(T255803).
This patch was created by an automated search & replace operation
on the includes/ directory.
Bug: T257789
Change-Id: I5ffbb91882ecce2019ab644839eab5e8fb8a1c5f
|
|
|
|
|
|
| |
Also avoid undefined $pdbk for invalid titles
Change-Id: I2a6b02c06284704461243ffb4255b6473199dd0a
|
|
|
|
|
|
|
|
| |
This classes were found by surveying concrete classes derved from base
classes in core.
Bug: T247862
Change-Id: I231752aaad26e2ab3f097301e449b31e723590f0
|