| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
Change-Id: I41c19a63d20dc4e734430ad4fe989fa5a9e18d62
|
|
|
|
|
|
|
| |
Fixed typo "MediWiki" to "MediaWiki" in core.
Bug: T201491
Change-Id: I55cb4af63b72cfa08de079544c43ae9f1366a457
|
|
|
|
|
|
| |
The class supports php4 and the visibility private does not work there.
Change-Id: I9cbffe437a1d1f4243f0b70bd881cdc8b8257537
|
|
|
|
| |
Change-Id: Ia056ba7f9eddbcf31082c7b2f7a64e7dbf02cba4
|
|
|
|
|
| |
Bug: T172165
Change-Id: I740f32ac859d9bb3787fdf8414f82ae6f410492f
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
In 7.2, the `utf8_encode` function was moved into core PHP, and is no
longer a part of the `xml` extension. Use a different function to check
for the existence of it.
Change-Id: Ib50c1a59dd9c2a8777b07b2f7a3dd638a55832c6
|
|/
|
|
| |
Change-Id: Id0aaad5a06cb90c4b2b81fa233a0a622aaf91a1e
|
|
|
|
| |
Change-Id: I3a6135871de0fdc94fa3fe622c6534746035a209
|
|
|
|
| |
Change-Id: Ic4bcf03bc84c2208186e47015a27fb93a63887d8
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because it doesn't work. `phpcs:ignoreFile` is intended as a performance
shortcut, and gives up on the file as soon as that token is found.
Instead, use `phpcs:disable` which does support selectively disabling
some sniffs. And since disabling is local to the file, there's no need
to re-enable it at the bottom of the file.
<https://github.com/squizlabs/PHP_CodeSniffer/issues/1903> has some
relevant discussion and clarification from upstream on this.
And make the files that are now being re-enabled pass PHPCS.
Change-Id: Ia4d8c45045f61cf9f24eb1d8631ff98d99c82d69
|
|
|
|
| |
Change-Id: I7031f0e909db8d63012f4057939292cb3b472cde
|
|\ |
|
| |
| |
| |
| | |
Change-Id: I0a22c638bf6bbd6c8b93e50c23f8e455e36acd7c
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
Clean up use of @codingStandardsIgnore
- @codingStandardsIgnoreFile -> phpcs:ignoreFile
- @codingStandardsIgnoreLine -> phpcs:ignore
- @codingStandardsIgnoreStart -> phpcs:disable
- @codingStandardsIgnoreEnd -> phpcs:enable
For phpcs:disable always the necessary sniffs are provided.
Some start/end pairs are changed to line ignore
Change-Id: I92ef235849bcc349c69e53504e664a155dd162c8
|
|
|
|
| |
Change-Id: I2a1ce7b7af7ef9991a054332593b1f63a0213469
|
|
|
|
| |
Change-Id: Iaf8e012b91888233703577e2de4ec522f39428e7
|
|
|
|
| |
Change-Id: I6b2c9c7af9a281fe457099cc3a336a60a25e74aa
|
|
|
|
|
|
|
|
| |
We call mime_content_type() in a couple of important places with no
fallback.
Bug: T172643
Change-Id: I83db8b078f8f42d02fe6024ec9895da0688f1c91
|
|
|
|
|
|
|
|
|
|
|
| |
HHVM brings it's own version number, so relying on the PHP version
string in the PHP_VERSION const on an hhvm server maybe does not
increase in different versions of hhvm. Therefore, this change
implements a hhvm server version check, if MediaWiki runs on an
hhvm server, instead of checking the php version.
Bug: T123436
Change-Id: I91b0a4e1eded61d3ba63ecbd14cdc85c57295892
|
|
|
|
| |
Change-Id: If9842b19ec995d03f93f96bfad4d61ca96c37f3c
|
|
|
|
|
|
|
|
|
|
| |
I was bored. What? Don't look at me that way.
I mostly targetted mixed tabs and spaces, but others were not spared.
Note that some of the whitespace changes are inside HTML output,
extended regexps or SQL snippets.
Change-Id: Ie206cc946459f6befcfc2d520e35ad3ea3c0f1e0
|
|
|
|
|
|
|
|
|
| |
The class keyword should work in all reasonable working php installations,
as far as I know. In this way, the php version check does not rely on a
set of global functions. It also should make maintaining the different
checks a bit easier.
Change-Id: I73ee098a8cf931ca4df6263c6e0a3e215555b612
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Branch point was dc0f9b3a3a75e80a0c5f09dd76b4df1fcc05080d
The following commits missed the branch point and should probably
be backported because master reports them as 1.28
- 4290f686c07265d40718fc3358f196de41bbde57
- 81698d4c1605f491709e636acd5ca0e6857e3821
- 40da8bf039019a2845405854a2d636be4bd3b98d
- 95db9833dd8d75ff3dc44d587fdc3ad80332a500
- 7bd97758f7e1496c7d4a1fa4e7275c9d6c01c5c3
Change-Id: I51562ba357b5533500ef9dd1e29107dd05cc9e1e
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The installer is far too late of a place to be checking if
a function does or doesn't exist if we require it for operation.
Functions can very easily (T137509) be called prior to ever
getting to the installer check page.
Also, an old installation could've gotten past the checks if
they ran update.php --skip-compat-checks. What a scary setting!
Instead, fail hard, fast and early along with PHP version checks.
All entry points are required to go through this.
While we're here, also remove the check for mbstring.func_overload
since we already would've failed at WebStart.php
Change-Id: Ib9727979af2a4741f3cd952d13a3bb350fad43e4
|
|
|
|
|
|
|
| |
We bumped to version 1.28 in mediawiki recently but seems we forgot to do
it in PHPVersionCheck.php.
Change-Id: I2a455669b68225fd9d6772c8482559c220d433b5
|
|
|
|
|
|
|
|
| |
Result of RfC and extensive discussion. RfC approved
by Tim/ArchCom on 2016-01-27.
Bug: T75901
Depends-On: I00e2e7adf5202384fc92371b8d0551782c3c17cb
Change-Id: I68c5b5d60952418ff8300c163edfe2275571f41f
|
|
|
|
| |
Change-Id: Iecc771cda2e67eeaf2b6bf27f338e698d3298e96
|
|
|
|
|
|
|
|
|
|
| |
Replaced all dirname(__FILE__) by __DIR__ or added
@codingStandardsIgnore
Found by tests:
https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs/2736/consoleFull
Change-Id: I90ff10f183ed60175fe580c43d73c0e57fd04234
|
|
|
|
| |
Change-Id: Id1caeb487a4e801bd7f0f5377b6c06c6fc7eebe4
|
|
|
|
|
|
|
|
| |
Except the ones for which there is no clear way to fix
because of T114213.
Bug: T102614
Change-Id: I94a1fc7c890c82a36f0b51e42d311585c275775c
|
|
|
|
|
| |
Bug: T102614
Change-Id: I0d759be6ef568c2c6f28606d3002484ad77a1830
|
|
|
|
| |
Change-Id: Ib664051153e35d39f72e3d2e93516a16ba64b554
|
|
|
|
|
|
|
|
|
|
|
| |
* separate warnings for PHP version and vendor
* new wfGenericError() function
* minimum PHP version in a single place
Bug: T102094
Change-Id: I7ae0369e4bab279d5e1bc754fe1a0bc8543bb2ed
|
|
This way, if someone tries to install MediaWiki via
either web installer or install.php maintenance script,
after obtaining from git, they get some useful information
on what to do.
Put the checks alongside the php version check, as
stuff installed via composer (mustache / lightncandy)
is used for NoLocalSettings.php and install.php
attempts to use logging stuff.
Also tried to make PHPVersionError look slightly nicer,
with some <h2> elements and more padding for the <p>
elements.
and centralized this code in one place, as much as possible,
for improved ease of maintenance.
Bug: T90438
Bug: T88951
Change-Id: Iae4eb42c4266dbe9213c5de8a96fccfbeaa9acb0
|