| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Follows-up 606a21c, 79414f8, 870c5e2.
* Mention class name in PHP source. Since there is no obvious link
between "mediawiki.checkboxtoggle.js" and "ListToggle.php" these
comments make it possible to find the PHP class. Previously
these css classes had 0 matches across all source code, thus
risking accidental removing.
* Quote attribute selector.
* Ensure default prevented before instead of after the handler. These toggles
have no fallback (href="#"). As such, navigation should be prevented
regardless of whether the JS fails or succeeds.
* Remove use of is(':checked'). These is no need to reach out to the
selector engine to determine whether 'checked' property is true or false.
Instead, use prop('checked') for both getting and setting.
* Simplify code by using this.checked directly instead of $().prop().
* Simplify code by using one loop (from $.prop) instead of two loops
($.prop inside $.each). This pattern is also used by selectAll().
Test by using "All", "None" and "Invert" on Special:Log.
Bug: T131318
Change-Id: Idfc43f094c6147d69104416b3f8622eabb20b824
|
