| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
MW wouldn't even log users in without OpenSSL in default
configuration. Makes sense to mention it.
Change-Id: Ifa68adc09c23eed078d6c5624139da7df208fe99
(cherry picked from commit 308f3f6851dcec2334973553d5181a1f99a6e947)
|
|
|
|
|
| |
Bug: T234766
Change-Id: I25206df6d7bc1587c3e18b1015603b3d264017f7
|
|
|
|
|
|
| |
Bug: T234767
Change-Id: I96ddb373bb89a8c7e3b0599bb7c7dc671e26e337
(cherry picked from commit 54cd4fcabad81f57049f959bde4774e3707cd7d0)
|
|
|
|
|
|
|
|
|
| |
This is just a first, top-level patch for documentation and the
PHPVersionCheck class itself. Much more clean-up to follow.
Bug: T192166
Change-Id: I50f5adc8d5fff604a14c8a889a31d3b92cc568c5
(cherry picked from commit ed8e9397adf9477c381f3880276a2e0917087a7b)
|
|
|
|
|
|
|
| |
Bug: T233165
Depends-On: I070678446f1932d63b9c533b4c5406ad7e69e291
Change-Id: I7658c18a3c6868c12ee453027e9f4b30ee663cd9
|
|
|
|
|
|
|
|
|
| |
This fixes a lingering incompatibility with PHP 7.4.
Bug: T233012
Bug: T233062
Depends-On: I569cffadcde7a2db36a970cf21da9909d7650cf6
Change-Id: I9939c8697a5c4bbe1694a0e9be22b9efa782f027
|
|
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.34.1
Bug: T230694
Bug: T232211
Bug: T232514
Bug: T232537
Depends-On: I00c6ecd8666d565b66af3021ecf5f339288606fe
Change-Id: Ic9b7033e3f52f415ec8aec845a65a8452d0e5d8f
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Our current recommendation for adjusting PHPUnit configuration for
extension code coverage reports is to manually modify
tests/phpunit/suite.xml. This is cumbersome and annoying, since
suite.xml is version controlled.
This patch proposes a composer script to simplify editing
the (non-version controlled) phpunit.xml config in the root of the
MediaWiki repo. It is useful if you are interested in generating
code coverage reports based on unit tests only, not integration tests.
Usage: composer phpunit:coverage-edit -- extensions/GrowthExperiments
When you're done, you can run `rm phpunit.xml` to switch back to the
default phpunit.xml.dist.
The script will use the default includes/src/maintenance directories,
but a future improvement would be to identify the relevant directories
via the AutoloadClasses property of extension.json.
Another improvement would be to provide an option for passing
arbitrary paths in core, in case you are working on tests for a
specific class and want to generate coverage reports instantly.
We could probably also remove
dockerfiles/quibble-coverage/phpunit-suite-edit.py (which inspired
this patch) and use composer phpunit:coverage-edit instead.
Bug: T100294
Change-Id: Ia0ef41f67ca4a64b0d1ca0ddcee488c29630af0b
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.34.0
Bug: T35242
Bug: T225669
Bug: T226872
Bug: T226872
Bug: T230160
Depends-On: Ic50014955550f6c310155f38834ad03cbd77af20
Change-Id: I1520084a0d546279180320d2b03d390be6689d05
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This release remove use the Wikimedia/quietCall function wrappers
in favour of calling Wikimedia\AtEase directly. This is used
in WebStart/WebRequest::getIP/ProxyLookup::isConfiguredProxy.
Bug: T189966
Depends-On: I31a371d206ac22df4d95c2d72c85b8b2d89722fd
Change-Id: Icdf34bde803cdea90ca9f6b730391514d6485618
|
|/
|
|
|
|
|
|
| |
This allows us to remove many suppressions for phan false positives.
Bug: T231636
Depends-On: I82a279e1f7b0fdefd3bb712e46c7d0665429d065
Change-Id: I5c251e9584a1ae9fb1577afcafb5001e0dcd41c7
|
|
|
|
|
|
|
|
|
| |
In most cases it's packaged as part of the php xml extension
but there's likely some OS that maybe package it separately....
Shouldn't cause any harm being here
Change-Id: I6c8a40a06314e7e4eb3fe83448a2a071e8203554
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.33.4
Bug: T171865
Bug: T224070
Depends-On: Iec2d70793459492c3cebaa735753e0afa542e7c4
Change-Id: Iec2d70793459492c3cebaa735753e0afa542e7ca
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.33.3
Bug: T212159
Bug: T225021
Bug: T226045
Bug: T226780
Bug: T226822
Bug: T227666
Bug: T227917
Depends-On: I7dde9d02f94c4e78ef480035d3887b68d0128233
Change-Id: I7800da87a6a10399f705b43e05c8592c766bae6f
|
|
|
|
|
|
| |
Vendor patch: I5571d3ea4b50a866b2444af648b22b1c5a1b5ebe
Change-Id: If5884a31c3f468fc55502c27e978f2eb2668441d
|
|
|
|
| |
Change-Id: I370fed5248c8b243527cafb77d80ddb6f4bc7064
|
|
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.33.2
Bug: T158708
Bug: T226780
Bug: T227040
Bug: T227275
Depends-on: I3d7a990d0f32734a9048ec55d22035150a562f04
Change-Id: I4287a6f2e950a8ad0511b24f4a1c8074e4f427b3
|
|
|
|
|
|
|
|
|
|
|
| |
These were removed from the phpunit.xml file recently (after having
been unused for many years), but between the revert and resplit
of the recent MediaWikiTestCase refactor, that change was lost
and the group exclusion re-introduced.
This removes it again, following 214750d8d224fc7.
Change-Id: I9448854e5f1587b1083e78f61ef8b520722ad2b9
|
|
|
|
|
|
|
| |
Follows 214750d8d224. This isn't needed because they run with
that directory already in their PATH.
Change-Id: I855bbe53c2b5c87afa425b7b6d3ec920c452cc99
|
|
|
|
|
|
|
|
|
|
|
| |
The idea is that `vendor/bin/phpunit` could run all of the tests contained in
core + extensions + skins with no overlap, but that we can also provide
granularity for CI which wants to run some testsuites (e.g. core:unit and
core:integration) before extensions/skins, as well as running unit before
integration tests.
Bug: T87781
Change-Id: I2fb57f4a9a58ec7a4042d9cc1821cc484661a6b9
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.33.1
Bug: T226819
Bug: T226822
Depends-On: Ibff36df9866dd0c8c6fbd2ca4ce0decc633976b0
Change-Id: Ibff36df9866dd0c8c6fbd2ca4ce0decc633976ba
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Following discussion in Ibb8175981092d7f41864e641cc3c118af70a5c76, this patch
proposes to further reduce the scope of what unit tests may access, by removing
the loading of DefaultSettings and GlobalFunctions.php. This also has the
implied effect of disabling the storage backend, as well as the global service
locator.
MediaWikiTestCase is renamed to MediaWikiIntegrationTestCase so it's scope and
purpose is more clear. Whether we still need to keep `@group Database`
annotation around is debatable, as it's unclear to me what the performance costs
are of implying database access for all tests which extend IntegrationTestCase.
As far as I can tell, `@group Database` is primarily used in CI to run faster
tests before slower ones, and with the new UnitTestCase the annotation seems
redundant.
To run all testsuites, use `composer phpunit`. Other composer scripts:
- `composer phpunit:unit` to run unit tests
- `composer phpunit:integration` to run integration tests
- `composer phpunit:coverage` to generate code coverage reports from unit
tests (requires XDebug).
Note that you can pass arguments to composer scripts with `--`, e.g. `composer
phpunit:integration --exclude-group Dump`.
Other changes:
- Rename bootstrap.php to bootstrap.maintenance.php so it's clear it's part of
the legacy PHPUnit-as-maintenance-class setup
- Create new bootstrap.php which loads the minimal configuration necessary for
the tests, and do additional setup in the run() method of the unit/integration
test case classes
- Move the unit-tests.xml file to phpunit.xml.dist in preparation for this being
the default test configuration
For a follow-up patch:
- Find unit/integration tests for extensions/skins
- Migrate other test suites from suite.xml
- Support running all tests via vendor/bin/phpunit
Bug: T84948
Bug: T89432
Bug: T87781
Change-Id: Ie717b0ecf4fcfd089d46248f14853c80b7ef4a76
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.33.0
Bug: T218753
Bug: T218977
Bug: T224657
Bug: T224702
Bug: T224881
Bug: T225021
Bug: T225571
Bug: T225882
Bug: T226031
Bug: T226045
Bug: T226618
Depends-On: I396faea52625a294991f7a473043cb39ed98ca28
Depends-On: I38aa1ce529bed43175d2ecdcecd1c6a2a0ed603f
Change-Id: I396faea52625a294991f7a473043cb39ed98ca20
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* wikimedia/object-factory -> 2.0.0
* wikimedia/timestamp -> 3.0.0
* wikimedia/xmp-reader -> 0.6.3
Needed for I5c0cc3a8. mediawiki/vendor equivalent is Iea05dc43.
Bug: T224729
Bug: T144482
Depends-On: Iea05dc439688871c574c639e617765ae88a75ff7
Change-Id: I6705a8d46f53ef807edab10f8f0cb0eba6b560dc
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
https://github.com/Seldaek/monolog/releases/tag/1.23.0
https://github.com/Seldaek/monolog/releases/tag/1.24.0
https://github.com/Seldaek/monolog/compare/1.22.1...1.24.0
Change-Id: I83b4b2e0b2cb0061daacb52e029dbab2f4e1cc95
Depends-On: I32633c85a4b1eb7919a1ce8c9b6693227f2ae55b
|
|/
|
|
|
|
|
|
| |
johnkary/phpunit-speedtrap prints this information right before the
test results.
Bug: T225730
Change-Id: I288dcd6b3c9b2c0b31c6047eaf48a23e13af726e
|
|
|
|
|
|
| |
Bug: T222410
Change-Id: Ifab2602972ba385a975a0d8279605d2c4802ca9f
Depends-On: I5629e287208b2f038753d88d328989ebdc934c0f
|
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.32.1
Bug: T223841
Bug: T224739
Bug: T224885
Depends-On: I1e6ed138cbab66c94cd45289799302d88d22cad9
Change-Id: I72278024790829841c15dd7b3eb09fe1a98cac9c
|
|
|
|
|
|
|
|
|
|
| |
Adds symfony/yaml for parsing event schemas used by EventBus
as part of the CirrusSearch test suite. The dependency needs to be
added to core to support CI testing extensions that depend on
CirrusSearch.
Bug: T220723
Change-Id: Iddbfb81fb667980470d6872c34a1e63897f1e4af
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.32.0
Bug: T141320
Bug: T163142
Bug: T169484
Bug: T178950
Bug: T180730
Bug: T203859
Bug: T212186
Bug: T213884
Bug: T215644
Bug: T219479
Bug: T220239
Depends-On: Ia65a8053082ac95bf89cb5484aa64668fb780735
Change-Id: I0a48885642b86950180d1fbe4c7a609d323fb87f
|
|
|
|
|
|
|
|
| |
https://github.com/wikimedia/remex-html/releases/tag/2.0.3
https://github.com/wikimedia/remex-html/compare/2.0.1...2.0.3
Change-Id: Iaa7212a362b120ca4d9c91f229ad4cabc39cc578
Depends-On: I6b6a45c2cf6dcc1fa03f59bf54d4c759111b3385
|
|
|
|
|
|
|
|
| |
https://github.com/wikimedia/at-ease/releases/tag/v2.0.0
https://github.com/wikimedia/at-ease/compare/v1.2.0...v2.0.0
Change-Id: Ia49a156e76d0a4e257e91cc6a51050848bcb9a5e
Depends-On: If40364e2590e3c23035838f8ed26c4f69e730602
|
|
|
|
|
|
|
|
| |
Fix five instances of PhanPluginDuplicateConditionalNullCoalescing;
escape the rest for now.
Bug: T219114
Change-Id: Ic4bb30c43c5315ce6b878b37b432c6e219414f8b
|
|
|
|
|
|
|
|
|
| |
https://github.com/cssjanus/php-cssjanus/releases/tag/v1.3.0
https://github.com/cssjanus/php-cssjanus/compare/v1.2.1...v1.3.0
Bug: T215746
Change-Id: I352f79f6f34279e669057aee7c2f1570800c8a11
Depends-On: Id8aba2d9e99671a9c45e02b271dbf290a11228d7
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update composer/semver from 1.4.2 to 1.5.0
https://github.com/composer/semver/releases/tag/1.5.0
https://github.com/composer/semver/compare/1.4.2...1.5.0
Update composer/spdx-licenses from 1.4.0 to 1.5.1
https://github.com/composer/spdx-licenses/compare/1.4.0...1.5.1
https://github.com/composer/spdx-licenses/releases/tag/1.5.1
Update mediawiki/codesniffer from 25.0.0 to 26.0.0
https://github.com/wikimedia/mediawiki-tools-codesniffer/releases/tag/v26.0.0
https://github.com/wikimedia/mediawiki-tools-codesniffer/compare/25.0.0...v26.0.0
Disable failing Squiz.WhiteSpace.FunctionSpacing, can be fixed in a later
commit
Change-Id: I89062c8f28bef893f054650f2e81287291ba9ca0
Depends-On: I8f55e77283f83d853ce340f5c1b7704c65e45bc4
|
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.31.6
Bug: T220792
Bug: T222088
Bug: T222427
Depends-On: Id1eae9aa3105886d557a6d11af68fff633602970
Change-Id: Ie40cf6c8eb8ad77f99512db56026827de4d636fa
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.31.5
Bug: T218229
Bug: T221705
Depends-On: I89a829b50e318649ed80b4bd9ac2fea61d08a5d2
Change-Id: I89a829b50e318649ed80b4bd9ac2fea61d08a5d1
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.31.4
Bug: T163142
Bug: T208547
Bug: T220041
Bug: T220204
Bug: T220227
Bug: T220248
Bug: T220840
Change-Id: Ic94a2f6790334baad7bc9c3055e990f7d3917e17
Depends-On: I0a2e152e61700e723a9ad7cd061682efaa9faf4d
|
|
|
|
| |
Change-Id: I1132bb024abe9a5f8a5374eb062d1b8efbfc3007
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.31.3
Bug: T193731
Bug: T194523
Bug: T217381
Bug: T218408
Bug: T219033
Bug: T219826
Depends-On: I94d1fd4398ec92c2ec63ebf1e57b3b4fc72bd76a
Change-Id: Ibb276860815fc29beaea131401bb5dfeca5159d6
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.31.2
Bug: T161854
Bug: T192131
Bug: T218882
Bug: T218977
Bug: T219004
Bug: T219240
Depends-On: I6179266e71901182614ec24e7b0510b7a44ff50a
Change-Id: I6179266e71901182614ec24e7b0510b7a44ff50b
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MediaWiki core now runs phan 1.2.6, bringing in nearly 2+ years of upstream
fixes.
Configuration was moved from `tests/phan` to `.phan/`. The legacy bash wrapper
script is still kept in the repository in its own location for any extensions
that are still using it. It should be removed before 1.33 is released.
Since there's a lot of new issues being flagged, all currently failing issues
are suppressed, and will be fixed in follow-up patches.
We're dropping the jetbrains/phpstorm-stubs repository in favor of just
the minimal stubs we need. Stubs for PHP extensions are kept in
the new `.phan/internal_stubs` directory, since they're in a slightly
different format than normal stubs.
Normal stubs are kept in `.phan/stubs`. wikidiff2 and excimer are kept with
these since we're also the upstream for them.
Change-Id: I3fe437befa17f4fbaf97aa6271f659b56021f396
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.31.1
Bug: T163135
Bug: T170263
Bug: T184835
Bug: T209716
Bug: T214748
Bug: T216071
Bug: T216780
Bug: T218409
Bug: T218722
Bug: T218753
Depends-On: I79088caef4a34b3f6ae06bff25213652a079854a
Change-Id: I79088caef4a34b3f6ae06bff25213652a079854b
|
|/
|
|
|
|
|
|
|
|
| |
Use the library instead of duplicating most of the config/defaults that it
provides. MediaWiki core is different of course, so we have to override a
bunch of file/directory lists, but there was a lot being duplicated.
This is the first step in migrating to a newer phan version.
Change-Id: Ib5987ebdf208138d97e1aba8ef54438064063fe9
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.31.0
Bug: T215645
Bug: T217471
Bug: T217584
Bug: T217952
Bug: T218271
Depends-On: Icc14a3662039080f1a65d098004640366351f0bb
Change-Id: Icc14a3662039080f1a65d098004640366351f0ba
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.30.4
Bug: T92026
Bug: T145674
Bug: T206729
Bug: T213884
Bug: T216780
Bug: T217014
Bug: T217213
Bug: T217381
Bug: T217790
Depends-On: Id50f068908accd022c7847c40795286c32199b4e
Change-Id: Id50f068908accd022c7847c40795286c32199b4a
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.30.3
Bug: T215559
Bug: T216070
Bug: T216075
Bug: T216578
Bug: T216582
Depends-On: Ic5a4598bbb222fa4b98c2706fe909aa9eb297f4b
Change-Id: Ic5a4598bbb222fa4b98c2706fe909aa9eb297f4a
|