| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Bug: T373222
Bug: T386152
Bug: T386482
Bug: T386485
Bug: T386997
Bug: T387217
Bug: T387218
Bug: T387867
Bug: T388709
Bug: T388710
Bug: T388831
Bug: T388835
Bug: T389094
Change-Id: Idd564f5720960a9376f6d83a25d19a42e9c50f19
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Previously this used the uca-xx-ckb collation. However this gave
incorrect results. That collation has been deprecated in this
commit.
This also adds support for groups of equal weight characters in
CustomUppercaseCollation
Bug: T310051
Change-Id: I1e122af6be94e3484f735f150ac639dfb99f681f
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
Bug: T353458
Change-Id: Ibe1810f1c71316a9124e1dc6ae405097dafd5267
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Bug: T353458
Change-Id: Id3ca24e22877e544b707a8a527a58e00cc1bc247
|
| |_|/
|/| |
| | |
| | |
| | | |
Bug: T353458
Change-Id: I35864ad9bd48701703c51367d62f8ebde963c52d
|
| |/
|/|
| |
| |
| | |
Bug: T353458
Change-Id: I7a9c74f2106655d41ae029742090253f541bd4a6
|
|/
|
|
|
|
|
|
| |
Release notes:
https://gerrit.wikimedia.org/g/oojs/ui/+/v0.51.7/History.md
Depends-On: Ide3e140beb9affe3a1bd4bdc91da636065877926
Change-Id: Ie09af553957d3c19ab3b458716c5261f56766915
|
|\ |
|
| |
| |
| |
| |
| |
| | |
Disable all new issues for now.
Change-Id: Ib145e2cd4f455355bb11857ae68cd05cb432924e
|
|/
|
|
|
|
| |
Bug: T388323
Depends-On: I0646915ad777cad38cbe5071120392f8f4dd8fe2
Change-Id: I253fbcee7d7c5b3b0e05db871572b6663eca10d6
|
|
|
|
|
| |
Bug: T341775
Change-Id: I0f93cfa546580fe5544b781f0dd138877b5850b4
|
|
|
|
|
| |
Bug: T341779
Change-Id: I97f377db80be9ee840ad101436233b40205590ad
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Now that MessageParser has been split out, MessageCache has no
remaining calls to Language methods except for getCode().
The only non-deprecated usage of Language is as a parameter to the
callbacks registered by the MessageCacheFetchOverrides hook. Review of
all MessageCacheFetchOverrides handlers in Code Search shows that none
are actually using the Language parameter. None of the closures even
declare a third parameter.
A Language object is a complex and inefficient way to pass a language
code.
So:
* Revert the deprecation of string language codes in the language
passed to MessageCache::get().
* Pass a string code internally instead of a Language object.
* Relax the validation applied to string language codes, so that it is
similar to LanguageFactory. Callers were often passing a Language
object with a code like "qqx" which is not a known language tag, but
is allowed as a parameter to LanguageFactory::getLanguage().
* Remove the third and fourth parameters to the override callbacks.
* Remove the LanguageFactory constructor parameter.
Depends-On: Ic4beec7373e799e51082957ab96d26e4c692c413
Change-Id: Ia9ddb1b83a6f20d3f7cee2afaf5987dbc99ea00b
|
|/
|
|
|
| |
Bug: T387856
Change-Id: I1e206dc4ad8bca2fae78ca4fdf919e3a8ee3c4b5
|
|\ |
|
| |
| |
| |
| |
| |
| | |
Also fix name of wikimedia/langconv lib (fixing 3d620e3f80)
Change-Id: I62c32456040e150e79f6e7c26de4e8137c360a85
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
GenderCache gets the "gender" user preference directly out of the
core database. Thus it does not respect global preferences. So:
* Add UserOptionsLookup::getOptionBatchForUserNames(), which gets a
single user preference for a set of named users.
* Add UserOptionsStore::fetchBatchForUserNames() as a backend. This is
a new interface method so is a breaking change.
* Have GenderCache call the new interface.
The no-database case in ServiceWiring is apparently no longer reachable
from the installer due to my previous patch which split
MediaWikiTitleCodec.
Performance generally degrades from one query to three. For change lists
and user page namespace redirects, it shouldn't be a problem, but for
the {{GENDER}} parser function there may be a user-visible performance
degradation.
Bug: T386584
Depends-On: Id02489a597f96cd1cd6db08e16b3624542fdf1f7
Change-Id: I9646b5422afce356e9a1dceeb09d8d4e286dc65e
|
| |
| |
| |
| |
| |
| | |
Bug: T352913
Depends-On: I04efc91cefd02776f8680ba5492122d681593080
Change-Id: I1953cdeadedd2309eff71a75a16592ceda501e6b
|
| |
| |
| |
| |
| |
| | |
Bug: T388283
Depends-On: Iab2028f6813fda32d05ab2926ec646f15463f0d3
Change-Id: I862e5efd0ea37b92a48eacd87b0dea1db458ef3a
|
| |
| |
| |
| |
| | |
Change-Id: Ie497e207a847d7f9b1210af98683c8cb5c039d84
Depends-On: Ibdce6ddbe8f6781f3998043ff7ad5b7310fdcdfd
|
|\ \ |
|
| | |
| | |
| | |
| | | |
Change-Id: If542e6096a73e8a954937c088d619d197f4555bf
|
|\ \ \
| | |/
| |/| |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Add a batch version of CentralIdLookup::isOwned(), to support the
linked bug.
* Add test.
* Fix error in LocalIdLookupTest::provideIsAttachedShared() which
failed to provide the shared case due to an incorrect loop bound.
This test has been non-functional since it was introduced in 2015.
* Fix error in LocalIdLookupTest::newLookup() which failed to override
the config.
Bug: T386584
Depends-On: Ie63ed1f14c9ba4f9cefcceef05d5585a6676f111
Depends-On: I83716f7930bd0d2de4761cc5b04d9d3ff4172da2
Change-Id: I99dd733547f46e635c2f363166ce111e76e06a5e
|
|\ \ \ |
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Highlights from https://gerrit.wikimedia.org/g/mediawiki/libs/less.php/+/v5.2.1/CHANGES.md:
* Fix un-parenthesized nested operation via a variable (T386074).
* Fix PHP 8.1 warning.
* Fix undefined key warning (T380641).
* Performance improvements.
Depends-On: I3a562cfb4f19420085f86f84d07854d328c6aede
Change-Id: I803919a8bfa38367800b6ebc2d7a433afde03b2e
|
|/ /
| |
| |
| |
| |
| | |
This has been unused since 2010 after SVN r70135.
Change-Id: I506a1c1dc12ceb17fe3b0bb75e91d95ff3775389
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 1695950bccb1ca7eba98952753708ae7c4b76d8d and re-applies commit I8f3c2ea021d0f6e.
Reason for revert: the remaining usages have been updated in Ida665f486eff384.
Bug: T166010
Change-Id: I43f06e6872b264e43aef7fa7c2ac47159926a694
|
|\| | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit db47e7f7154a2121bce6d3d9e93a74486bf765f3.
Reason for revert: Broke scap sync-world in beta, and possibly caused T387938
Bug: T166010
Change-Id: If608c3e27081bb36b284ad16a5b912dd51b3557e
|
|\ \ \
| |/ /
|/| | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Bug: T373218
Bug: T373219
Bug: T383867
Bug: T386148
Bug: T386150
Bug: T386151
Bug: T386300
Bug: T386481
Bug: T386485
Bug: T386621
Bug: T387536
Bug: T387601
Bug: T387757
Bug: T387911
Change-Id: If664d2c3a8fde00f8012a03a53436db8b943558b
|
|/ /
| |
| |
| |
| |
| |
| | |
Bug: T166010
Depends-On: Iba93dd9749656e641c427e01790d7a14cd1a2dc2
Depends-On: I97ccc2c49ce09ca96192bf6ffdc833c1765c3faa
Change-Id: I8f3c2ea021d0f6e574dde901f0bfd4a0408f5455
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
For the linked bug, I would really like GenderCache to use
UserOptionsManager. But all user-related services need UserNameUtils
which depends on TitleParser, and TitleFormatter needs GenderCache to
correctly format NS_USER titles. Having TitleFormatter and TitleParser
together in a single class creates an intractable dependency loop.
So, split MediaWikiTitleCodec. On Daniel's advice I converted the
existing TitleParser and TitleFormatter interfaces to classes. The code
was always structured to allow this. Extensions require surprisingly few
updates. MediaWikiTitleCodec remains only for its deprecated static
methods.
The implementations were split cleanly with no need for shared code. The
tests did have a little bit of shared code, for round-trip testing, so I
added a shared test base class for that.
Bug: T386584
Depends-On: Ibf307e953b666d8923bc96a507907421558da378
Depends-On: I47e83e95727e6830500e9af7cff92e7d3f91167e
Depends-On: Id9c045864a9dc3c640a896e6b34f516c7e42b050
Change-Id: I3dcce6639ed01c7611a663671c872cec775bdaa2
|
| |
| |
| |
| |
| |
| | |
Bug: T387507
Depends-On: I763ffc4af1cb24fb4b38d1b854c919e2d7acc916
Change-Id: I1d4150cb7f6c04284bb984232447af8b14be22c4
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Why:
* User::getGlobalBlock is no longer used in WMF deployed code after
the merging of d4d993be5c1ce6ac9f3b88ff651b8e89334bc852 for
T363185.
* We can now hard deprecate the method per the stable interface
policy.
** Doing this is needed so that we can remove the method in the
next MW release.
What:
* Add a wfDeprecated call in User::getGlobalBlock to cause
deprecation warnings, making it hard deprecated.
Bug: T387574
Change-Id: I880f2c1e833823bf1ac08d6744d638ad342821cb
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | | |
Bug: T351733
Change-Id: I59b6115d034d6fd8e2d0a650b7990b8bb4b8de8c
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Bug: T322944
Change-Id: I4e142ec5eba2dc05afe947f138bea043e0667151
|
|\ \ \ \
| |_|_|/
|/| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Why:
- When a transaction lifecycle callback such as
onTransactionPreCommitOrIdle() is invoked by rdbms, rdbms passes in
the DB connection handle the callback was scheduled on.
- However, the DB connection handle may have since been reset to a
different DB domain on the same physical cluster due to connection
reuse.
- We could implement bookkeeping to keep track of the expected DB domain
for each pending callback and ensure the passed-in DB handle matches
that before invoking the callback, but nobody seems to be making use
of the passed-in DB handle except for two call sites in core.
- As such, it seems more prudent to remove this functionality.
What:
- Stop passing the DB connection handle to rdbms transaction lifecycle
callbacks.
Bug: T386190
Change-Id: I9125bfb8b5e2cac4aab3525ffd229ea49beccc17
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Why:
- OutputPage::addModules() and OutputPage::addModuleStyles() currently
store added module names in two lists, mModules and mModuleStyles.
- The contents of these lists then get passed to array_unique() when
OutputPage::getModules() is invoked, to filter out any duplicate
module names.
- In I4f70ff15becbc4991c4f1b0307a14d5354c79dc1, we would like to modify
UserLinkRenderer::userLink() to automatically add the requisite
ResourceLoader modules to the output, instead of every page where
userLink() is called needing to do so manually.
This can cause these modules to be added thousands of times when a
large list with many user links is rendered, e.g. on RecentChanges.
- Running `php maintenance/run.php benchmarks/benchmarkEval output.php`,
where output.php holds:
```
$out = ( new RequestContext() )->getOutput();
for ( $j = 1; $j <= 2000; $j++ ) {
$out->addModules( 'ext.foo' );
}
$out->getModules();
```
takes about 4-5ms on my system.
- Turning the properties into associative arrays and getting rid of the
array_unique() call drops this to < 0.2ms.
- These properties are exposed via public property accessors that have
been deprecated since MW 1.38 and have no usages in codesearch.[1]
Since we're changing how the properties work, this is a good time to
remove the deprecated public property accessors.
What:
- Use associative arrays to store module names in OutputPage.
- Document that addModules() and addModuleStyles() take a
string|string[] rather than a string or an arbitrary array.
- Add unit tests for the behavior.
- Drop the deprecated public property accessors for mModules and
mModuleStyles.
[1] https://codesearch.wmcloud.org/search/?q=mModule%5BSs%5D
Bug: T358469
Change-Id: I86c557a4ce7207359d100538c0d4b1ffa75fcbf9
|
|\ \ \ \ \
| | |_|/ /
| |/| | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Bug: T322944
Change-Id: I6de31143e67e14d14aeaf7df04f1cbe257cf56bb
|
|\| | | | |
|