aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* RequestContext: add @param documentation to setAuthority()Universal Omega2021-05-091-0/+3
| | | | Change-Id: I78caeb1d76aebcf3e8c6ba48128078a0bbec520c
* Merge "Simplify database handling in CategoryTest"jenkins-bot2021-05-091-128/+24
|\
| * Simplify database handling in CategoryTestDannyS7122021-05-091-128/+24
| | | | | | | | | | | | Use addDBData() and tables used Change-Id: Ib9c9e9dcd2ddfad4ab9d4780c44fbc94a7a85d77
* | DatabaseBlock: Hard-deprecate calls to isWhitelistedFromAutoblocks()James D. Forrester2021-05-081-0/+2
| | | | | | | | | | Bug: T277987 Change-Id: Ic14f38e0e60bd156d1ff04392e65eeceb3ba77b2
* | DatabaseBlock::isExemptedFromAutoblocks: Drop fallback message loadJames D. Forrester2021-05-082-2/+4
|/ | | | | | | | | This is no longer needed in Wikimedia production. Third party users will have had a release to adjust to one of the three called-out migration issues. It's time. Bug: T277987 Change-Id: Ia4a797afc71441ed9a7a90ff4f1e72cc4495cf63
* Merge "resourceloader: Fix path-only URLs in wiki modules when script path ↵jenkins-bot2021-05-081-2/+14
|\ | | | | | | is docroot"
| * resourceloader: Fix path-only URLs in wiki modules when script path is docrootTimo Tijhof2021-05-081-2/+14
| | | | | | | | | | | | | | | | | | | | | | When a wiki is installed with its script path as the document root, then WikiModule would pass MediaWiki's wgScriptPath value (empty string) to CSSMin as base url, which is invalid. A similar bug was recently fixed in FileModule with I16abf482e3a1a. Bug: T282280 Change-Id: I0b9a67aa912eb3a0320631027303cedf3f348bb8
* | Merge "Update wikimedia/minify to 2.2.2"jenkins-bot2021-05-082-2/+2
|\|
| * Update wikimedia/minify to 2.2.2Timo Tijhof2021-05-082-2/+2
| | | | | | | | | | | | Bug: T282280 Depends-On: I1d2f958a7a3c594e020bb19c5284b3dbe69d7ebd Change-Id: I759c47f87e47c27bba479b4e4f10e53d2c722e8c
* | Merge "Rename `page_timestamp` revision index"jenkins-bot2021-05-086-1/+240
|\ \
| * | Rename `page_timestamp` revision indexAmmarpad2021-04-306-1/+240
| | | | | | | | | | | | | | | | | | | | | | | | Rename to `rev_page_timestamp` Bug: T270033 Depends-On: I16fc273b14e7f4b00e8c31ec1ed7712149aafe37 Change-Id: I93fcfb3caf8c6bd7f9e46921065b751c23571ae1
* | | Merge "Do not call SpecialPage::addHelpLink in constructor"jenkins-bot2021-05-082-2/+10
|\ \ \
| * | | Do not call SpecialPage::addHelpLink in constructorUmherirrender2021-05-042-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The help link will show up on Special:SpecialPages if the helplink of Special:SpecialPages is disabled. It also using global context on the message parse inside the function when used in constructor Change-Id: Ia7baee93cffe565d894960d2c7ab86085197b241
* | | | Merge "registration: Allow multi-line strings in "@" note keys"jenkins-bot2021-05-082-1/+8
|\ \ \ \ | |_|_|/ |/| | |
| * | | registration: Allow multi-line strings in "@" note keysTimo Tijhof2021-04-292-1/+8
| | | | | | | | | | | | | | | | Change-Id: Ifb1a0f04cc22b122ed99308c096d0ce4296e9097
* | | | Merge "Split TimeCorrection parser into separate class"jenkins-bot2021-05-078-101/+417
|\ \ \ \
| * | | | Split TimeCorrection parser into separate classDerk-Jan Hartman2021-05-078-101/+417
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The parsing of the timecorrection useroption was split over multiple classes. Combine into a single class and add some testcases. Change-Id: I2cadac00e46dff2bc7d81ac2f294ea2ae4e72f47
* | | | | Merge "ForkController: Throw more meaningful error for missing PHP extensions"jenkins-bot2021-05-072-15/+19
|\ \ \ \ \
| * | | | | ForkController: Throw more meaningful error for missing PHP extensionsAmmarpad2021-04-172-15/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently all the signal constants emit warnings as they are undefined in PHP 7.4 and throw fatal error in PHP 8, if pcntl is not available. pcntl extension is not enabled by default, and is not required by MediaWiki, so this class should throw a better error if it's not found. The class already has comment that pcntl and posix are required but this is meaningless since the error and a warning for each constant would be emitted anyway. https://www.php.net/manual/en/pcntl.installation.php Convert RESTARTABLE_SIGNALS constant back to static property as it was, because we can only use these constants after confirming they exist, which happens in the constructor. Bug: T280456 Change-Id: I66deaa9b346b936b2628ac0511492d20a42fea6c
* | | | | | Merge "Declare $wgCanonicalNamespaceNames in DefaultSettings.php"jenkins-bot2021-05-071-0/+7
|\ \ \ \ \ \
| * | | | | | Declare $wgCanonicalNamespaceNames in DefaultSettings.phpdaniel2021-05-071-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This ensures tests can run from phpstorm directly, without MediaWiki's custom phpunit wrapper. Background: $wgCanonicalNamespaceNames needs to be declared in DefaultSettings so it works properly when Setup.php is included via wfRequireOnceInGlobalScope, as is the case in MediaWikiIntegrationTestCase::initializeForStandardPhpunitEntrypointIfNeeded. wfRequireOnceInGlobalScope will import any variables in the global scope into the local scope to make them available in the included file. It also exports all variables declared in the scope of the included file to the global scope, but only after the file includsion returns. If $wgCanonicalNamespaceNames is not defined in global scope before Setup.php runs, then the $wgCanonicalNamespaceNames variable defined in Setup.php will not become global until after Setup.php finishes. However, Setup.php instantiates services that need $wgCanonicalNamespaceNames to be present. This causes the test framework to fail. Change-Id: I8c5179433737170303f37cb072cb0352006ca173
* | | | | | | Merge "LinkBatch: skip bad input"jenkins-bot2021-05-072-23/+83
|\ \ \ \ \ \ \
| * | | | | | | LinkBatch: skip bad inputdaniel2021-05-072-23/+83
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | LinkBatch used to be lenient about receiving null or invalid titles. This patch restores this lenient behavior. Bug: T282180 Bug: T282070 Change-Id: I2c6378a3a0d508c77bcb290a6ed07f4d5f96d62c
* | | | | | | Merge "Add null checks for namespaces and actions in blocks"jenkins-bot2021-05-072-18/+25
|\ \ \ \ \ \ \
| * | | | | | | Add null checks for namespaces and actions in blocksSTran2021-05-072-18/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't show namespaces or actions that are not active (eg. uninstalled extension) in block information Bug: T280798 Change-Id: I14fa7006b3d46eeb41d53216c5203d294fff6338
* | | | | | | | Merge "Stop resetting partial action block options when values change"jenkins-bot2021-05-071-4/+0
|\ \ \ \ \ \ \ \
| * | | | | | | | Stop resetting partial action block options when values changeSTran2021-05-061-4/+0
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | updateBlockOptions() was unchecking all action blocks whenever it was run and it's run any time a value changes. User inputs were being lost if they didn't select actions last. Remove that code from the update function. Bug: T282177 Change-Id: Id06d172afb1998f9bd32ea0b7cb39d42b2e94d11
* | / / / / / / Title: avoid instance cache pollutiondaniel2021-05-072-5/+76
| |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T281337 Change-Id: I2e8d18b2fc10509097f66287b2543217f4eb9b6a
* | | | | | | Localisation updates from https://translatewiki.net.Translation updater bot2021-05-0726-269/+304
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I9bc1cdefed392f541d9ff05d273e14f000debc68
* | | | | | | Merge "ApiQueryLogEvents: when user is specified, omit STRAIGHT_JOIN"jenkins-bot2021-05-071-1/+2
|\ \ \ \ \ \ \
| * | | | | | | ApiQueryLogEvents: when user is specified, omit STRAIGHT_JOINTim Starling2021-05-071-1/+2
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise it tries to scan the whole logging table, joining every row on actor. Bug: T282122 Change-Id: Ia34897a496656e0d0d26f9e038b1edb0377c461e
* | | | | | | Merge "LinksUpdate: don't throw if page does not exist"jenkins-bot2021-05-072-13/+39
|\ \ \ \ \ \ \
| * | | | | | | LinksUpdate: don't throw if page does not existdaniel2021-05-042-13/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | LinksUpdate may encounter a non-existing page due to race conditions, when the page has been deleted or renamed before the update is executed or even created. We should log such incidents to detect anomalities, but we should not crash hard. Similarly, RefreshLinksJob should not attempt to run on a page that no longer exists. Bug: T281802 Change-Id: Ic73c3e339ff0478710bd57a9f707c1284dcce2d9
* | | | | | | | Merge "Remove PathRouterTest::$basicRouter, unused"jenkins-bot2021-05-071-12/+0
|\ \ \ \ \ \ \ \
| * | | | | | | | Remove PathRouterTest::$basicRouter, unusedDannyS7122021-05-051-12/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I9760da3ea034b09745ea7b553541a806c71bdac2
* | | | | | | | | Merge "rdbms: disallow upsert()/replace() calls with multiple unique keys"jenkins-bot2021-05-075-47/+22
|\ \ \ \ \ \ \ \ \
| * | | | | | | | | rdbms: disallow upsert()/replace() calls with multiple unique keysAaron Schulz2021-05-055-47/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I4b6f07e8c8b3915c780885083f7465790328d2a3
* | | | | | | | | | Merge "Use a constant for 'Maintenance script' username"jenkins-bot2021-05-0712-11/+18
|\ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | Use a constant for 'Maintenance script' usernameGergő Tisza2021-05-0312-11/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The user 'Maintenance script' is often used to perform various automated tasks. Providing it everywhere as a string literal is error-prone, and errors can be somewhat disruptive (e.g. with User::newSystemUser with steal=true it can erase the credentials of a legitimate account). Provide a constant instead. Also replace existing uses for consistency. Change-Id: I685a5bfe56bbf1a47f35072f7f7c8be320ee27db
* | | | | | | | | | | Reorder tables in SpecialWatchlistPetr Pchelko2021-05-061-1/+1
| |_|_|_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Same issue as in Ifbdb24ff5b99b9ec12cb313c48227563696c48c9 Bug: T282181 Change-Id: I166ef428932136b8466610b8accb78ec6ccdf757
* | | | | | | | | | Merge "WebInstaller: Don't show the announce-l subscribe checkbox temporarily"jenkins-bot2021-05-061-6/+7
|\ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | WebInstaller: Don't show the announce-l subscribe checkbox temporarilyJames D. Forrester2021-05-051-6/+7
| | |/ / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | … whilst we fix auto-subscription. Hopefully. Bug: T281549 Change-Id: Ifa2e46ee668e51caf87eeca34bec123511595c50
* | | | | | | | | | Add Malay (Arabic Jawi script, ms-arab) to Names.phpAmir Aharoni2021-05-063-0/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T282085 Change-Id: Ic118bdf1eba4cca7e037a78c969cd2247c1397c2
* | | | | | | | | | Merge "Deprecate legacy actor migration keys"jenkins-bot2021-05-062-6/+23
|\ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | Deprecate legacy actor migration keysTim Starling2021-05-032-6/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For every table except revision, the use of ActorMigration was "soft deprecated" in 1.34. Now, hard deprecate it. Bug: T278917 Change-Id: I63d26d13026214d84b6b94f06b4ad0d2362d97ed
* | | | | | | | | | | Merge "Split a base class out of ActorMigration"jenkins-bot2021-05-064-503/+623
|\| | | | | | | | | |
| * | | | | | | | | | Split a base class out of ActorMigrationTim Starling2021-05-034-503/+623
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | AbuseFilter needs a class which is almost identical to core's ActorMigration, so I split out the generic facilities into ActorMigrationBase, leaving the bits specific to core in ActorMigration. I changed the way fields and tables are specified so that it's easier to override in subclasses. Proper injection of ActorStoreFactory in ActorMigrationTest::testGetWhere() was necessary to avoid a test failure due to a teardown issue. Bug: T278917 Change-Id: I3a6486532f2ef360d1fd01b3a609de71d412f739
* | | | | | | | | | | Merge "rdbms: use is_file() in DatabaseSqlite::open()"jenkins-bot2021-05-061-5/+1
|\ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | rdbms: use is_file() in DatabaseSqlite::open()Aaron Schulz2021-05-051-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I79ee0a8d357913f64578cf38cf17d969b6661153
* | | | | | | | | | | | Merge "Eliminate use of Title object in REST infrastructure"jenkins-bot2021-05-0633-345/+549
|\ \ \ \ \ \ \ \ \ \ \ \