aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* language: Remove maintenance/language/checkExtensions.phpNiklas Laxström2020-04-153-254/+0
| | | | | | | | | | | | | Broken: ArgumentCountError from line 43 of /home/developer/mediawiki/workdir/ extensions/Translate/ffs/MediaWikiExtensions.php: Too few arguments to function PremadeMediawikiExtensionGroups::__construct(), 0 passed in /home/developer/mediawiki/workdir/maintenance/language/checkLanguage.inc on line 609 and exactly 2 expected No point fixing this, checks are done on translatewiki.net side. Change-Id: I9f39684c2ef8479ea35ad1d60e3f1f86d88a8067
* language: Stop using Languages class in maintenance/langmemusage.phpNiklas Laxström2020-04-151-4/+8
| | | | | | This class comes from languages.inc. Change-Id: I046fa583b95fe3dee3690fd7ca89e0ec0b3e63aa
* Merge "poolcounter: Call poolCounter->release on exception and add tests for ↵jenkins-bot2020-04-153-6/+264
|\ | | | | | | PoolCounterWork"
| * poolcounter: Call poolCounter->release on exception and add tests for ↵Peter Ovchyn2020-04-103-6/+264
| | | | | | | | | | | | | | | | | | PoolCounterWork Add type hitting to correctly cover object construction. Bug: T249531 Change-Id: I20c61a08813cf564e07dc3a8272727a1e1043348
* | Merge "maintenance: Move $IP and MEDIAWIKI assignment to doMaintenance.php"jenkins-bot2020-04-152-6/+6
|\ \
| * | maintenance: Move $IP and MEDIAWIKI assignment to doMaintenance.phpTimo Tijhof2020-04-142-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Per 4eb1e679d5, these are now documented as the bare minimum entry point responsibilities. For WebStart these are already consolidated, but for the CLI use case they were a bit scattered. Consolidate these in the CLI entry point (doMaintenance.php) for clarity. * $IP was previously assigned in Maintenance::__construct, which is called from doMaintenance.php. It still executes at the same logical time, one line above 'new $maintClass()'. * MEDIAWIKI was (for CLI) previously defined in Maintenance::setup() which is called from doMaintenance.php. This is now done a few lines earlier, and in the entry point file instead. For both of these, they are still available and set in all the same scenarios as before. Bug: T246076 Bug: T250003 Change-Id: I2a6f5e997a36502535eb383a95deac0ce74d83fb
* | | DatabaseBlock: Remove deprecated isValid methodThalia2020-04-152-11/+1
| | | | | | | | | | | | Change-Id: I5f54426207f31f6acaceb8f21d43ddb2227d58cc
* | | Localisation updates from https://translatewiki.net.Translation updater bot2020-04-1516-287/+306
| | | | | | | | | | | | Change-Id: Ie14f3fa3d2c6858cfba766bb02faeb0dbf9f85cf
* | | Merge "Update OOUI to v0.38.0"jenkins-bot2020-04-15113-416/+552
|\ \ \
| * | | Update OOUI to v0.38.0James D. Forrester2020-04-14113-416/+552
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release notes: https://gerrit.wikimedia.org/g/oojs/ui/+/v0.38.0/History.md Bug: T178387 Bug: T232383 Bug: T248393 Bug: T249853 Change-Id: Iaddcb40869fdba31e3c489e260bee7002ee22cd9 Depends-On: I00c36baabfb781d81a9bfcc9db8f10699ea9749d
* | | | Merge "Hide deprecated warnings for Hooks::clear()"jenkins-bot2020-04-153-0/+7
|\ \ \ \
| * | | | Hide deprecated warnings for Hooks::clear()Nikki Nikkhoui2020-04-143-0/+7
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some tests were failing after Hooks::clear() was deprecated in the new HookContainer.php, and needed to have the deprecation warning hidden to pass. Bug: T250102 Change-Id: I59784e7972517488ba4cb8d0bad8d09a6f534f48
* | | | Merge "objectcache: make WANObjectCache::set() handle very slow regeneration"jenkins-bot2020-04-152-62/+134
|\ \ \ \ | |_|/ / |/| | |
| * | | objectcache: make WANObjectCache::set() handle very slow regenerationAaron Schulz2020-04-142-62/+134
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a key always takes a very long time to regenerate, is popular, and does not use lockTSE, it still needs to be cacheable. Since a value cannot be more up-to-date than the time it takes to regenerate it, take the "lower the TTL" approach for these cases. Use "walltime" to narrow down the "reject the set()" case based on regeneration time. This is already provided by getWithSetCallback() automatically. Bug: T244877 Change-Id: Id43fb02738b28dad3bc922057efb7eee0272d0e1
* | | | Merge "Add Vuex (v3.1.3)"jenkins-bot2020-04-158-0/+1156
|\ \ \ \
| * | | | Add Vuex (v3.1.3)Roan Kattouw2020-04-148-0/+1156
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Requires a wrapper file to make module.exports work, just like momentjs does. Also call Vue.use( Vuex ) in the wrapper file. Change-Id: I883d9531d13faa11bb630b27437bc6272d0bc134
* | | | | Merge "resources: Provide an ES6-style Promises library with a skip function"jenkins-bot2020-04-156-0/+317
|\| | | |
| * | | | resources: Provide an ES6-style Promises library with a skip functionJames D. Forrester2020-04-146-0/+317
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using https://github.com/taylorhakes/promise-polyfill via a skipFunction. Bug: T237688 Change-Id: Ib0ffb5d9821e7b734c3f7533cc99e5fdd2c8da3a
* | | | | Merge "resourceloader: Let derivative context inherit getUserObj() object"jenkins-bot2020-04-142-0/+31
|\ \ \ \ \
| * | | | | resourceloader: Let derivative context inherit getUserObj() objectTimo Tijhof2020-04-142-0/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The DerivativeResourceLoaderContext class extends the ResourceLoaderContext class and thus its getUserObj method works without needing an override. But, while this inherits the logic from the parent class, it does not inherit the *state* from the parent object (which is a local concept, not something PHP would magically do). Like the other methods do already, add a missing getUserObj override which inherits from the logical parent when possible. This way, the instance cache can be shared which will save about a dozen replica database queries on every page view (3 queries per User object, and about 2-3 User objects were being re-created this way). Bug: T249189 Change-Id: Id5a9f9c1e7656109e0cf25ea6860426341d4a0bc
* | | | | | Merge "resourceloader: Derive from existing Context object in ClientHtml"jenkins-bot2020-04-141-8/+7
|\| | | | |
| * | | | | resourceloader: Derive from existing Context object in ClientHtmlTimo Tijhof2020-04-141-8/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was previously creating a fresh context object, and then manually imported some query parameters, and then *also* created a derivative context object (so that it can copy over the "getContentOverrideCallback" value and to allow the consumer to also use setVersion/setModules). The reason for this indirection was that I wanted to re-use the query string parsing logic of ResourceLoaderContext::__construct, instead of interpreting it here. However that extra indirection is rather fragile as it could easily forget some other things to inherit manually. And, per T249189, it means there is no process cache shared between the two. This is exactly what DerivativeResourceLoaderContext is for, and if there is a missing feature in it, we should add it, instead of working around it (note to self...). For now, though, it can actually be used as-is. Changes: * Use DerivativeResourceLoaderContext directly. * Set the 'only' and 'user' values directly using the setter methods after creating the derivative object. * Also set 'raw' correctly. This was previously handled by $extraQuery being passed to ResourceLoaderContext::__construct, but now needs to be done manually. Bug: T249189 Change-Id: I4173ec75bef4fe9fee39663b1348c077414d3627
* | | | | | Merge "RevisionUndeleted hook: Add $oldPageId"jenkins-bot2020-04-142-1/+2
|\ \ \ \ \ \ | |_|/ / / / |/| | | | |
| * | | | | RevisionUndeleted hook: Add $oldPageIdDannyS7122020-04-142-1/+2
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Not always the same as the restored revision's pageId Bug: T248727 Change-Id: I4e3ea4519d34de7c67ad8999575affe77d756f08
* | | | | Merge "Hard deprecate Action construction with WikiPage"jenkins-bot2020-04-147-40/+130
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | Hard deprecate Action construction with WikiPageArtBaltai2020-04-147-40/+130
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tests, PermissionManager, EditAction: Construct Action with Article Bug: T239975 Change-Id: Ia3f653f3c193312e03ccef56586e8b8222c80fa6
* | | | | Fix linking to nested sub-sections in preferencesBartosz Dziewoński2020-04-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous selector could return another sub-section if the target sub-section was nested. The new one only returns top-level sections (the tab panels). The class .mw-prefs-section-fieldset did not exist when this code was originally written (it was added in 255a58bedd). Bug: T248644 Change-Id: I33318b3fb73a27ce8013c2d1d6fff9bb7f729221
* | | | | Merge "Add Special:MyLanguage for better user experience"jenkins-bot2020-04-143-8/+8
|\ \ \ \ \
| * | | | | Add Special:MyLanguage for better user experienceYuki Shira2020-04-143-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | Change-Id: If77a684c1d17a36e8f264f2fed133755adaa99d2
* | | | | | Merge "Add small HtmlCacheUpdater service class to normalize purging code (2)"jenkins-bot2020-04-1420-133/+391
|\ \ \ \ \ \
| * | | | | | Add small HtmlCacheUpdater service class to normalize purging code (2)Aaron Schulz2020-04-1420-133/+391
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a re-submit of 35da1bbd7cb, which was accidentally merged before CR (and reverted with aa4da3c2e8e). The purge() method handles purging of both file cache and CDN, using a PRESEND deferred update. This avoids code duplication and missing file cache purge calls. Also: * Migrate HTMLCacheUpdate callers to just directly using HTMLCacheUpdateJob * Add HtmlFileCacheUpdate class and defer such updates just like with CDN * Simplify HTMLCacheUpdate constructor parameters * Remove BacklinkCache::clear() calls which do nothing since the backlink query does not actually happen until the job runs Bug: T230025 Change-Id: Ic1005e70e2c22d5bd1ca36dcdb618108ebe290f3
* | | | | | | Localisation updates from https://translatewiki.net.Translation updater bot2020-04-1435-198/+302
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I7dd46d9c9c28f2834a2cce5c8cabd1b49b284bdf
* | | | | | | Merge "Stop defining legacy 'rows' and 'cols' options, ignored since MW 1.29"jenkins-bot2020-04-141-2/+0
|\ \ \ \ \ \ \
| * | | | | | | Stop defining legacy 'rows' and 'cols' options, ignored since MW 1.29James D. Forrester2020-04-141-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T155153 Change-Id: I5f5bc6d903513e89281ee8063ca456f105e24cce
* | | | | | | | Merge "WikiPage::onArticleEdit - accept a RevisionRecord"jenkins-bot2020-04-143-4/+12
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | |
| * | | | | | | WikiPage::onArticleEdit - accept a RevisionRecordDannyS7122020-04-103-4/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using Revision is hard deprecated Bug: T249561 Change-Id: I4b639f8adba329991afbcff26c7223e325225055
* | | | | | | | Merge "Hard deprecate Revision::setId"jenkins-bot2020-04-143-0/+4
|\ \ \ \ \ \ \ \
| * | | | | | | | Hard deprecate Revision::setIdDannyS7122020-04-113-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are a lot of methods names setId, but looking through a codesearch for deployed code[1], none appear to be for revision objects outside of the test for the method Bug: T246284 Change-Id: I32148b3380797352ef0cdf47c05bdd022d88e3ec
* | | | | | | | | Merge "Disable mail in mediaWikiSetUp() instead of TestSetup"jenkins-bot2020-04-142-8/+6
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|/ / / / |/| | | | | | | |
| * | | | | | | | Disable mail in mediaWikiSetUp() instead of TestSetupTim Starling2020-04-092-8/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To disable mail in tests, use setTemporaryHook after the service container setup, instead of the soon-to-be deprecated Hooks::register(). Change-Id: I84ea69feb0ebf81855b745c14fdba50d4e121de8
* | | | | | | | | Merge "Fix failing tests relying on private Hooks.php properties"jenkins-bot2020-04-142-25/+0
|\ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / |/| | | | | | | |
| * | | | | | | | Fix failing tests relying on private Hooks.php propertiesNikki Nikkhoui2020-04-132-25/+0
| | |_|_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some tests rely on properties in Hooks.php that will no longer exist with the new HookContainer.php (e.g. Hook::handlers). These tests need to be modified to adhere to the changes made in Hooks.php. Bug: T250102 Change-Id: I5e21ee49925c82260c43cb1d6470fae195057ba5
* / | | | | | | Maintenance: Don't redefine MW_ENTRY_POINT if it's already setArtBaltai2020-04-141-2/+3
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Maintenance.php may be included after other entry points in certain configurations (like IDE bootstrapping). So if MW_ENTRY_POINT is already set, don't try and define() it as another value. Bug: T250003 Change-Id: Ide011ad11d8dd29fe786a745c6e67259e46b9bfb
* | | | | | | Merge "RevisionSearchResultTrait: Remove use of Revision objects"jenkins-bot2020-04-132-16/+23
|\ \ \ \ \ \ \
| * | | | | | | RevisionSearchResultTrait: Remove use of Revision objectsDannyS7122020-04-132-16/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T249183 Change-Id: I89a8ca4839b302c50973c15ce01ff5814e11e3c6
* | | | | | | | Remove codepaths which ran parser in 'untidy' modeC. Scott Ananian2020-04-1314-324/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Disabling tidy has been deprecated since 1.33. This cleans up the code paths which still used untidy output. Bug: T198214 Change-Id: I821ef3b8f59b272d983583d407b2f0794fe1e791
* | | | | | | | Merge "Updating nikic/php-parser (v4.3.0 => v4.4.0)"jenkins-bot2020-04-132-2/+2
|\ \ \ \ \ \ \ \
| * | | | | | | | Updating nikic/php-parser (v4.3.0 => v4.4.0)Reedy2020-04-122-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I5bbf15ab1a1c55e1c55ef7a7a96d532099100e3e Depends-On: I8ad3115a8d7dee649d33417913a37ad889d0e310
* | | | | | | | | Merge "Updating psy/psysh (v0.10.2 => v0.10.3)"jenkins-bot2020-04-132-2/+2
|\| | | | | | | |
| * | | | | | | | Updating psy/psysh (v0.10.2 => v0.10.3)Reedy2020-04-122-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I44523a4c90a95a3a926f5bd14b5a842b164b3e22 Depends-On: Ifb45fdd235c8ee0ae6705921f071cb5856a57661