| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
In the new release of parsoid the PageBundle::$html field is given
a non-nullable type hint, which causes phan errors unless we update
the tests.
Bug: T379319
Depends-On: Ifb33cf12adda79c6b271ec0467975e2823f1c703
Change-Id: I753bbbfaf99fb486384b0fa97de71159abb504b3
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This makes sure all entries for the same page end up in the same
database table in the same cluster so depool/crash of a parsercache host
wouldn't have out of proportion effects on the cache overall.
But if we just change the key scheme, every key will be displaced and
everything will go down. So we need to introduce a temporary config variable
to gradually roll out the change.
Bug: T373037
Change-Id: Iae9b8dd5dd65c6d7c8d3b6f786a110d72f0b959e
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| | |
Backport of I29136fa to 1.43:
<https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1089353>
Change-Id: Ic10fe2cd063c0665edb9d7e192ed33cd8945c7c4
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | | |
This module uses packageFiles and therefore doesn't need the wrapper.
Change-Id: Ic3345160d4ddb204a212356c0eb57918363c3c69
|
|\| | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The 4-argument version of the OOjs .on() method was used essentially
as a workaround for the lack of arrow functions, to avoid having to
re-bind `this`. We can now do things in a way that doesn't require
knowing this obscure functionality of OOjs.
Change-Id: Iceda34be72bdd541c46cb8a4ac12e2bfc3cb2a6e
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Partial revert of I48977ac0547bd7bd694397e0561dbb1ad1c9a42e:
The call to RevisionFromEditComplete had been moved to a compatibility shim
triggered by PageUpdatedEvent. This however makes it impossible to
modify the tags associated with the edit.
The shim also used a fresh WikiPage instance, which may have resulted in
loss of context for some hooks handlers, see T379218.
Bug: T379152
Change-Id: I4acc0d7150328fc95c7cafbdddf828ba0cb84b87
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Change-Id: Ice89888216220612bae0f5597e2bbde9b9bd3bf1
Depends-On: I19d29ef502f4647da6a2249180bdc9f612335085
|
|\| | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Bug: T379508
Change-Id: Ia693d5e3424d925172cd2e4b7cb501a031822f3b
Depends-On: Iec814da22ff34810077876d3ee0ad0264cfc54a9
|
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Why:
* The NamespaceInfo service may need to be visible to subclasses.
* An example of this is the GlobalContributionsPager, which needs
to check properties of namespaces for T378155.
What:
* Make ContributionsPager $namespaceInfo protected instead of
private.
Bug: T378155
Change-Id: I6a52e84a8dc1886df59dff09e82bdef25875e1c3
|
| | | |
| | | |
| | | |
| | | | |
Change-Id: Ib00d0f75f46d6ed5408e4f02cbd9c90a32dd5762
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
It turns out that the fix in Ia4d57fd953dbd34e45789208ec8e765cce6ddf15
is general enough that we don't need these special cases any more.
Bug: T379418
Change-Id: I7c29d68325a3525463cd22cd6da5710848619b85
|
|\| | | |
| |_|_|/
|/| | | |
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When parsing wikitext like `{{func:a|b|c}}`, jqueryMsg accepted
multiple expressions in the parameters following '|' (which are
handled by templateParam()), but not in the first parameter
following ':' (which is handled by templateWithOutReplacement()).
So, `{{#FORMAL:Informal hello|{{GENDER:|Formal}} hello}}` worked,
but `{{#FORMAL:{{GENDER:|Informal}} hello|Formal hello}}` didn't.
Now they both work.
Bug: T379418
Change-Id: Ia4d57fd953dbd34e45789208ec8e765cce6ddf15
|
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
MWCryptHKDF was added ten years ago (in af66c04d39ad96a0), and as far as
I can tell, it was never used anywhere. It seems unlikely that CryptHKDF
will be used in the future, at least in its current form, for several
reasons:
* PHP 7.1.2+ has hash_hkdf(), so HKDF() would not be needed.
* At the time MWCryptHKDF was created, access to a CSPRNG was dependent
on server configuration: operating system, enabled PHP extensions,
open_basedir, etc. The "clock drift" RNG used as a last resort was not
considered to be secure or fast enough for generating large amounts of
output.[1] random_bytes(), added in PHP 7, changed the situation.
* Depleting the input pool of Linux's RNG is no longer a concern; there
is no more blocking output pool for /dev/random.[2][3] In 2022, this
change and others, including some that improved performance,[4] were
backported to stable kernels as old as 4.9.[5]
* $wgAuthenticationTokenVersion obviated the primary use case of
quickly resetting the user_token field for all users, assuming all
the existing tokens are unique.
* CryptHKDF seems to perform much slower than random_bytes(), at least
on Linux, making it pointless to use given that the other reasons for
its existence no longer apply.
[1]: https://bots.wmflabs.org/logs/%23mediawiki-core/20161004.txt
[2]: https://lwn.net/Articles/808575/
[3]: https://lore.kernel.org/all/cover.1577088521.git.luto@kernel.org/
[4]: https://www.zx2c4.com/projects/linux-rng-5.17-5.18/
[5]: https://lore.kernel.org/all/Yo3pmh9hiUFtQz77@zx2c4.com/T/
Change-Id: I29136fad826341d21728671aa30285d5551f1162
|
|\ \ |
|
| | |
| | |
| | |
| | | |
Change-Id: I98f7056cd43355d2094e4010131b66bc4ad6039d
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The documentation made it sound like the 'creating' flage is never
true for autocreation, which would be incorrect.
Change-Id: I2bc6086ece88bb796386222fe64494f45d432d46
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Depends-On: I8128035597dba96c269ae35c0439032821f63232
Change-Id: I200775b8b55679df154db00832405f17a8064890
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Bug: T362829
Change-Id: Ia7c88b3fa51f0a6c515897c535b9969587db81d2
|
|\ \ \ \ \
| | |/ / /
| |/| | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Bug: T378275
Change-Id: Iacc8ca2e9ece0f32c0f537f01fcf03140e3f8ee5
Depends-On: Ia6d7e08c448407de4b9963c8bf47947fec264d7c
|
|\| | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Bug: T378300
Change-Id: I9c4306842ae6a21000f14e2ac36052560f5423cb
Depends-On: Ic224f2c33d76b1430c5faef6af341b256c3f4855
|
|\ \ \ \ \ |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Mostly used find-and-replace:
Find:
/\*[\*\s]+@var (I?[A-Z](\w+)(?:Interface)?)[\s\*]+/\s*(private|protected|public) (\$[a-z]\w+;\n)((?=\s*/\*[\*\s]+@var (I?[A-Z](\w+)(?:Interface)?))\n|)
Replace with:
\3 \1 \4
More could be done, but to keep this patch reasonably sized, I only
changed the most obvious and unambiguously correct cases.
In some cases, I also removed redundant doc comments on the
constructor, and re-ordered the properties to match the constructor.
Bonus: Fix some todos in AuthManagerTest.
Change-Id: Ife5313b821cf537984f6de364bfe1d9b4b992a07
|
|\ \ \ \ \ \
| | |/ / / /
| |/| | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Bug: T379377
Change-Id: I7a044533ebfe8a726bf2c94521c79856c3bbcd63
Depends-On: I153db8f19aa2ac06f0ad3ad9691a84bd7bfaddf0
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The searchsuggest logic was not forwarding events which might change
the state of the autocomplete. This made it so that composed charaters
and so called 'dead key' updates would not register.
While the default search is not affected, search completion in Vector,
monobook and the inputbox extension was still affected by this.
Bug: T177251
Change-Id: I889d926400f6627918583f170fe0c7d3f9704da6
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Depends-On: I6498db659a855d4c9c66f5e7219d812b3057617f
Change-Id: Ib47cfb7a6349926397c65a25f51b85a38c2f8952
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Depends-On: I2a7da46c89694803060b9c450da06b14a5bd44ad
Change-Id: I16e5d3bfa2067e7108fadabb04692955aa9c3bda
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Bug: T379384
Change-Id: Ia84fe750996a15370cf41a0a15bc77919dbc5abf
Depends-On: I78e985d273146b71302f430201c1331bbecf1d8a
|
|\ \ \ \ \ |
|
| | |_|_|/
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | | |
Bug: T379435
Change-Id: Ic5068f01dbc3f4295946c066a86a6d958dbc6e9c
Depends-On: Iad2909b8df0141ff4ce08f4d6d5b34ab3e9b7f0a
|
|\ \ \ \ \ |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Accordion labels now include an infochip component displaying the
total number of items in the table. If the api returns a "continue"
then a + sign is added to the number to indicate that there are more
items not being displayed
Bug: T376744
Change-Id: Ie154fce0bf673c438d5b4c07c6e23d304083dd19
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Bug: T372709
Change-Id: Ieed7b5a18f5223c7b8a2918df88790d4dc305f9d
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Change-Id: I82b562564ac21fc61f93b19d19abb4e02f58d8e5
|