aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | Add regression tests for UserDef::processUser()DannyS7122021-07-131-0/+96
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before we switch to only providing UserIdentityValue, make sure we match the sometimes weird behavior of User objects Change-Id: Iba5ef7f0068963e03935c7a69128ecfbe2f39a15
* | | | | | | | Merge "Add wider desktop breakpoint"jenkins-bot2021-07-131-0/+4
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | |
| * | | | | | | Add wider desktop breakpointClare Ming2021-07-131-0/+4
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T284243 Change-Id: Icb349987c5f5939b7f4ffa477ac1ecb35b5425e7
* | | | | | | Merge "Schema migration for revison_actor_temp table removal"jenkins-bot2021-07-1325-527/+862
|\ \ \ \ \ \ \
| * | | | | | | Schema migration for revison_actor_temp table removalTim Starling2021-07-1425-527/+862
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduce a new schema migration stage in which rev_actor is used directly and the revision_actor_temp table is no longer needed. This becomes the new "new" stage whereas the previous situation is now termed SCHEMA_COMPAT_TEMP. Introduce migrateRevisionActorTemp which copies data from revision_actor_temp to rev_actor. The code is similar to migrateImageCommentTemp.php except that it doesn't delete from the old table. Partial revert of c29909e59fd89d9fc6. That change removed direct references to $wgActorTableSchemaMigrationStage and made queries involving revision_actor_temp be unconditional. Such changes need to be reverted to make the use of revision_actor_temp be conditional again. In ActorMigrationTest, I compacted provideGetJoin() and provideGetWhere(), removing most of the duplication between expected values. I gave all the stages a short name, and mostly used the name in providers. Bug: T275246 Change-Id: I7498107dd6433ab7de5bf2e7b3fe2aa5e10e345d
* | | | | | | | Merge "Remove fallback to global state in WikiImporter"jenkins-bot2021-07-131-23/+9
|\ \ \ \ \ \ \ \
| * | | | | | | | Remove fallback to global state in WikiImporterAlexander Vorwerk2021-07-121-23/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T283530 Change-Id: Ide7693a411d76e11bd1611b2ffd269cb1f23799c
* | | | | | | | | ApiTestCase: stop interacting with $wgUserDannyS7122021-07-132-12/+11
| |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T285448 Change-Id: I6c91f47321c5ab717812a7dd0d629230b71a3ef1
* | | | | | | | Remove Skin::generateDebugHTML()bwang2021-07-132-12/+2
| |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T280611 Change-Id: I7f2520851fe9f4064e54f869507df4cffdd6684b
* | | | | | | Clean up MergeHistoryPetr Pchelko2021-07-135-203/+162
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Remove deprecated support for direct construction of MergeHistory 2. Store reading from the database inside the constructor. 3. Remove ::checkPermissions, deprecated since 1.36 Change-Id: I523d72ab7cb56c76f5d17fb51436fb356441d791
* | | | | | | Merge "Convert Skin::relevantUser to UserIdentity"jenkins-bot2021-07-134-38/+37
|\ \ \ \ \ \ \
| * | | | | | | Convert Skin::relevantUser to UserIdentityPetr Pchelko2021-06-304-38/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a breaking change, but I've reviewed all usages and there's nothing that requires full User object to be returned. Maybe it's too bold, following the deprecation process is not too hard either. Change-Id: Id22580945f594d7e0de533226f6c374a7a97fe1e
* | | | | | | | Merge "links is flat array"jenkins-bot2021-07-131-2/+3
|\ \ \ \ \ \ \ \ | |_|_|_|_|/ / / |/| | | | | | |
| * | | | | | | links is flat arrayjdlrobson2021-07-131-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pass a valid key to makeLink rather than an integer (index) which may result in an exception. Bug: T286040 Change-Id: Ic69ec102caec982e65e264f5812ac15df5168008
* | | | | | | | Add maintenance script to invalidate a users bot passwordsReedy2021-07-132-0/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T269543 Change-Id: I5848466edf45d4a2d04b52d1643c35fb68b0da08
* | | | | | | | maintenance: Move username/userid validation into Maintenance classReedy2021-07-132-10/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Ie8f650eb03186feb7f69e7c71ef121c0d26404f5
* | | | | | | | Merge "Mark ApiClientLogin/ApiLogin as requiring write mode"jenkins-bot2021-07-132-0/+10
|\ \ \ \ \ \ \ \
| * | | | | | | | Mark ApiClientLogin/ApiLogin as requiring write modeReedy2021-07-132-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T283394 Change-Id: Idf8f3cc184cfa3b4ef3ec55c04ec4a4520cbc0b5
* | | | | | | | | Merge "Api: Convert php and json formatversion to use PARAM_HELP_MSG_PER_VALUE"jenkins-bot2021-07-134-6/+18
|\ \ \ \ \ \ \ \ \
| * | | | | | | | | Api: Convert php and json formatversion to use PARAM_HELP_MSG_PER_VALUEReedy2021-06-254-6/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T285545 Change-Id: I6efc1644893ae068fcb5b05c1b32f10e436b2402
* | | | | | | | | | Merge "Api: Convert errorformat to use PARAM_HELP_MSG_PER_VALUE"jenkins-bot2021-07-133-1/+14
|\| | | | | | | | |
| * | | | | | | | | Api: Convert errorformat to use PARAM_HELP_MSG_PER_VALUEReedy2021-06-253-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T285545 Change-Id: I887a212f8e913e90e9adac4ad0b139e854fa3db2
* | | | | | | | | | Merge "PasswordTestCase.php: Remove unnecessary paramter to provideTypes()"jenkins-bot2021-07-131-1/+1
|\ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | PasswordTestCase.php: Remove unnecessary paramter to provideTypes()Reedy2021-07-131-1/+1
| | |_|_|_|_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's unused, and overridden in the loop Change-Id: I0463abdb7d534c3d1497582d48e7a3160dda6d3d
* | | | | | | | | | Merge "LinkDeletionUpdate: Remove dead code"jenkins-bot2021-07-131-4/+0
|\ \ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / / |/| | | | | | | | |
| * | | | | | | | | LinkDeletionUpdate: Remove dead codeMatěj Suchánek2021-07-131-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is no lock to release since 6d315fb7f7. Static analysis is not reporting this because it is allowed to pass an unset variable by reference. Change-Id: I819cf438fe074cbe06e103566f61adecee018c1e
* | | | | | | | | | Merge "phpcs: Use cache flag"jenkins-bot2021-07-131-1/+1
|\ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / |/| | | | | | | | |
| * | | | | | | | | phpcs: Use cache flagKosta Harlan2021-07-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will use a temporary cache directory for the files analyzed by phpcs, so that subsequent runs are fast. Bug: T209149 Change-Id: I15967d220c1dbf9f06551cf4a5d01af5ddb739b6
* | | | | | | | | | Merge "MediaWiki: Avoid usage of deprecated `JobQueueGroup::singleton()`"jenkins-bot2021-07-131-3/+3
|\ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | MediaWiki: Avoid usage of deprecated `JobQueueGroup::singleton()`Derick A2021-07-121-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make use of the `JobQueueGroupFactory` service provisioned in 1.37 Change-Id: I12fe943fc1e62402dcfb7d0f66495fdbc76d751d
* | | | | | | | | | | Merge "Title: Avoid accessing class members directly & use accessor methods"jenkins-bot2021-07-132-6/+39
|\ \ \ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / / / |/| | | | | | | | | |
| * | | | | | | | | | Title: Avoid accessing class members directly & use accessor methodsDerick A2021-07-122-6/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | First step here is to avoid accessing the Title class members directly. Instead, use their corresponding accessor methods. Affected members are, $mTextform, $mUrlform, $mDbkeyform, $mNamespace, $mInterwiki, and $mFragment. TODO: The next step from here would be to find usage of direct access and replace them with calls to accessor methods while making the members private. Bug: T275763 Change-Id: I9b3efe7a43597f14e19d5db8e824f65aeb169d0b
* | | | | | | | | | | Add Gun (Gungbe, guw) to Names.phpAmir Aharoni2021-07-133-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T286460 Change-Id: I6e95d446faad3838f715fdfa2302ec0c9dc11c37
* | | | | | | | | | | Localisation updates from https://translatewiki.net.Translation updater bot2021-07-1330-126/+1013
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I7376a9662cc9fd2203ed464e56a8b964db2695fb
* | | | | | | | | | | Do not lock user_preferences before updatingPetr Pchelko2021-07-121-2/+2
| |_|_|_|_|_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See T286521#7207425 for my theory on why deadlock is happening. This is a stop-gap solution since the ticket is a UBN, not a long-term fix. This is also a partial revert of Ibed2789f5260b725fd806b4470631aa30d814ce6. The good: shouldn't deadlock. The bad: it will be possible (but very unlikely) that options save would undo previously saved options. The long-term solution: we shouldn't need to re-fetch all the options again before storing them. We now know which options have changed. But the UserOptionsSave hook requires all current options to be passed, and then the hook can unset some of the options. Before implementing the long-term solution, we need to change the hook to only need modified options, not all the options. This will be done as a followup. Bug: T286521 Change-Id: Ie6203be29ab23bc7ef9e26db421365a4f075c78f
* | | | | | | | | | Merge "Deprecate LogFormatter::styleRestricedElement"jenkins-bot2021-07-132-4/+17
|\ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | Deprecate LogFormatter::styleRestricedElementAlexander Vorwerk2021-07-122-4/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | LogFormatter::styleRestricedElement has been deprecated in favor of ::styleRestrictedElement in order to fix the typo in the method name. Bug: T286408 Change-Id: I27df9dab4dcc34594332c22b70348558f9e66fca
* | | | | | | | | | | Merge "EnhancedChangesList: Use parent::beginRecentChangesList()"jenkins-bot2021-07-121-7/+1
|\ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | EnhancedChangesList: Use parent::beginRecentChangesList()Fomafix2021-07-031-7/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I72b56a15371b5ab42358ce7c10db72cb491a091c
* | | | | | | | | | | | Merge "SpecialWhatLinksHere: Conditionally hide the namespace invert checkbox"jenkins-bot2021-07-121-7/+13
|\ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / / / / |/| | | | | | | | | | |
| * | | | | | | | | | | SpecialWhatLinksHere: Conditionally hide the namespace invert checkboxFomafix2021-07-051-7/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This changes hides the namespace invert checkbox like on SpecialRecentchanges and on SpecialContributions. Also use class="mw-input-with-label" to prevent line breaks between checkbox and label and inside of the label. Also use normal space (U+0020) instead of no-break space (U+00A0) because the no-break space does not prevent any line breaks here but gets visible at the beginning of the line in case of wrapping. Change-Id: Id8f7201087cc35c45a4be5f457aee2b37c64511e
* | | | | | | | | | | | Merge "Update stretch-php72-fpm im MediaWiki-Docker to 3.0.0"jenkins-bot2021-07-121-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | Update stretch-php72-fpm im MediaWiki-Docker to 3.0.0physikerwelt (Moritz Schubotz)2021-07-121-1/+1
| | |_|/ / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In version 2.0.0 XDebug was not if the container did run as non-root user. DEVELOPERS.MD suggested to run as non-root user. Fortunately, the problem was resolved in I37d0f35f0e3622a7fb3cb095d3b6b9496438ce12. This commit updates the MediaWiki-Docker compose file to also use the fixed container. Bug: T273682 Change-Id: Ib10e524d8cb4f58836efe7034303357a0f20c5ac
* | | | | | | | | | | | Use CsrfTokenSet as CSRF token sourcePetr Pchelko2021-07-1253-216/+303
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I079d2c802d9b48d6abf7f37fa9ef7dafac631345
* | | | | | | | | | | | Merge "SpecialBlock: replace User with UserIdentity"jenkins-bot2021-07-123-18/+33
|\ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | SpecialBlock: replace User with UserIdentityPetr Pchelko2021-06-303-18/+33
| | |_|_|_|_|_|_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Ib4ad056cef96e2bce41a8b36b6d3d24036824052
* | | | | | | | | | | | Merge "Add warning to MediaWikiServicesHook interface."jenkins-bot2021-07-123-1/+47
|\ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | Add warning to MediaWikiServicesHook interface.daniel2021-07-023-1/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Hook handlers for the MediaWikiServicesHook must not use services, since the service container is not fully initialized when the hooks is called. This is by nature of the hook itself, which exists to allow configuration and wiring to be manipulated. Depends-On: I1519aea8bca2f3977fcf15ee8776a1b3319687b5 Change-Id: Ifbc60e72167e5280e3609d14a47ffa6232fabca6
* | | | | | | | | | | | | Merge "Fix some @stable for ... annotations to use @stable to ..."jenkins-bot2021-07-1210-27/+27
|\ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | Fix some @stable for ... annotations to use @stable to ...DannyS7122021-07-0810-27/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T257789 Change-Id: I3ba94a9d6b739cd57cd57afe5d397963127160a8