aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Localisation updates from https://translatewiki.net.Translation updater bot2020-08-1320-62/+82
| | | | Change-Id: I5c0e7f096261251bc036263248774b4ef812905d
* Convert PageProps to a serviceDannyS7122020-08-126-46/+65
| | | | | Bug: T253188 Change-Id: Ic358946099a3424a3d1c2615feb14e74b6336a0e
* Merge "Doc: Clean up non-sentence in SkinAddFooterLinksHook"jenkins-bot2020-08-121-1/+1
|\
| * Doc: Clean up non-sentence in SkinAddFooterLinksHookjdlrobson2020-08-121-1/+1
| | | | | | | | | | Follow up to Id258b1ec2ae7008fc4d586d0647a5131ec889fe6 Change-Id: Iafbfc084efd096165dafcec403d34ccb67edc1ec
* | Merge "RevisionStoreCacheRecord: Fallback to master for update callback."jenkins-bot2020-08-121-1/+17
|\ \
| * | RevisionStoreCacheRecord: Fallback to master for update callback.Petr Pchelko2020-08-051-1/+17
| | | | | | | | | | | | | | | Bug: T259738 Change-Id: Id76f7c5179fa351a4aba4d5226437ef6338bbdce
* | | Merge "SpecialBlock: Show error if a block could not be inserted or found"jenkins-bot2020-08-123-1/+6
|\ \ \
| * | | SpecialBlock: Show error if a block could not be inserted or foundThalia2020-08-113-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a block cannot be inserted, it is assumed that there is an existing block against the target. That block is then retrieved from a replica database using DatabaseBlock::newFromTarget. We are seeing errors as a result of assuming that newFromTarget always returns a block object in this situation. Sometimes a block could not be inserted because there is an existing block, but the existing block could not be retrieved. This could happen if: * there is an existing block but it is not in the replicas yet * an existing block was removed after the insert attempt, but before the retrieve attempt Check whether DatabaseBlock::newFromTarget returns a block object, and display a message explaining the situation if not. Bug: T259212 Change-Id: I1737e3a69748ebaa743e87b185ba1e3b92afec8c
* | | | Merge "content: Add hidden preference to disable PST on CSS/JS content"jenkins-bot2020-08-124-3/+18
|\ \ \ \
| * | | | content: Add hidden preference to disable PST on CSS/JS contentC. Scott Ananian2020-08-124-3/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Test Plan: * Logged-in, preview a change adding {{subst:CURRENTYEAR}} to User:You/common.css, User:You/common.js and Main_Page. * Observe that it expands to 2020 in all cases. * Run `(new mw.Api).saveOption('pst-cssjs', '0')` * Try again. Observe that the first two are now left unchanged. Bug: T236828 Change-Id: Ic13e2ff3b90f0c3587cdb1e97fffcd96be650e0e
* | | | | Localisation updates from https://translatewiki.net.Translation updater bot2020-08-1212-48/+73
| | | | | | | | | | | | | | | | | | | | Change-Id: Ieef94c8a7da60df235a307f085b7d5afc5b1c884
* | | | | installer: PostgreSQL installer should respect a custom portsaper2020-08-112-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Submitted by: joernc_unibi (Joern C.) Bug: T30162 Bug: T245387 Change-Id: I99f0ae363096da49b3f840af999821a81767584e
* | | | | Merge "Fix bad use of `|=` PHP bit operation where `= … ||` bool is intended"jenkins-bot2020-08-124-8/+8
|\ \ \ \ \
| * | | | | Fix bad use of `|=` PHP bit operation where `= … ||` bool is intendedUmherirrender2020-08-124-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Do not use bit operator on bool as it does not work the same way. |= is not a short form of bool or (||) and assignment (=). It is the short form of bitwise or (|) and assignment (=) Change-Id: I64988cd3aeb8f4cbc53b0b866f1ac96f12976cca
* | | | | | Merge "ResourceLoaderOOUIImageModule: loadOOUIDefinition() may return false"jenkins-bot2020-08-121-2/+2
|\ \ \ \ \ \
| * | | | | | ResourceLoaderOOUIImageModule: loadOOUIDefinition() may return falseBartosz Dziewoński2020-08-101-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | loadOOUIDefinition() may return false when an extension is (ab)using the ResourceLoaderOOUIImageModule class to define custom icons (e.g. VisualEditor), and it doesn't include definitions for all of the available themes, perhaps because your skin is using a custom theme. As noted in a code comment elsewhere in this file: "that's okay, it will just use the defaults". Bug: T260059 Change-Id: I5468906b5efc4b727c6967ab5958fa6657e355ee
* | | | | | | Merge "rdbms: make DatabaseMysqlBase::masterPosWait() error messages prefer ↵jenkins-bot2020-08-121-3/+3
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | | | | | | | | filtered GTID list"
| * | | | | | rdbms: make DatabaseMysqlBase::masterPosWait() error messages prefer ↵Aaron Schulz2020-08-041-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | filtered GTID list This is less confusing as it only mentions GTIDs that were actually waited on. Bug: T221159 Change-Id: Ib821e63512d40fa38df8843cc8bb24add77a0d1b
* | | | | | | Merge "Filter invalid namespace on Special:RecentChanges and friend"jenkins-bot2020-08-122-30/+70
|\ \ \ \ \ \ \
| * | | | | | | Filter invalid namespace on Special:RecentChanges and friendUmherirrender2020-07-102-30/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes invalid values from the query and cast everything to int The database field is known as integer and there is no need to pass strings to the database In case of all namespaces are invalid the parameter is ignored and all namespaces are returned Bug: T253098 Change-Id: I166ef53aed669de61c20db42e3da75783ebc3970
* | | | | | | | resourceloader: update FNV doc url in startup moduleDannyS7122020-08-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://en.wikipedia.org/wiki/FNV_hash_function was renamed, update the url. Change-Id: Ib06b8f939dc1b2456e2263c6649d032d0def0d44
* | | | | | | | Merge "Remove uncalled InfoAction::getContributors"jenkins-bot2020-08-111-66/+0
|\ \ \ \ \ \ \ \
| * | | | | | | | Remove uncalled InfoAction::getContributorsUmherirrender2020-08-081-66/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Code exists in CreditAction class Change-Id: Ideeecb19b484ef7b76f18745258aa550aa0acbe0
* | | | | | | | | Merge "Add option to enable cross-origin resource sharing (CORS) in REST API"jenkins-bot2020-08-113-4/+34
|\ \ \ \ \ \ \ \ \
| * | | | | | | | | Add option to enable cross-origin resource sharing (CORS) in REST APIDavid Barratt2020-08-043-4/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When MediaWiki is not behind an intranet, it is completely safe to add the Access-Control-Allow-Origin: * header to responses and allow cross-origin sites to access the REST API. Bug: T232176 Change-Id: Ic0658039a6a46ee4f50c76f5d100450fdef7525a
* | | | | | | | | | Merge "Deprecate Skin::setupSkinUserCss"jenkins-bot2020-08-115-11/+7
|\ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | Deprecate Skin::setupSkinUserCssAmmar Abdulhamid2020-08-095-11/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T257990 Depends-On: I132513a897e40162acd973b9817b3103f4a33333 Depends-On: I363f8c9e39298ab9f74274d288681f2ef88a1894 Change-Id: I13bedd8c14de419ff1a88d5087f5669652cd3123
* | | | | | | | | | | Merge "Avoid SpecialPage::getTitleValueFor in LinkRenderer"jenkins-bot2020-08-111-2/+6
|\ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|/ / / |/| | | | | | | | | |
| * | | | | | | | | | Avoid SpecialPage::getTitleValueFor in LinkRendererUmherirrender2020-08-101-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The static function is using the global SpecialPageFactory Change-Id: I378d7dcf92b6e38f712de1138673bc77e2934f51
* | | | | | | | | | | Localisation updates from https://translatewiki.net.Translation updater bot2020-08-1113-12/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I51802fa4c3511c22346fb2440dc6038bc340d6cf
* | | | | | | | | | | Merge "Add full message names for some tooltip variants"jenkins-bot2020-08-111-0/+5
|\ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | Add full message names for some tooltip variantsSam Wilson2020-08-111-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For easier searching, add the matching tooltip-ca-* variants of the watching messages. Bug: T253135 Change-Id: I286372a608d79e34404a62a3a4487bdaf2e95017
* | | | | | | | | | | | Merge "SignatureValidator: Tweaks to linter error messages"jenkins-bot2020-08-101-1/+7
|\ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|/ / / / |/| | | | | | | | | | |
| * | | | | | | | | | | SignatureValidator: Tweaks to linter error messagesBartosz Dziewoński2020-08-051-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Suppress the "Multiple unclosed formatting tags on the page" errors, they always appear with "Missing end tag" errors and are redundant * When displaying "Missing end tag" error, show the HTML syntax for closing tags, rather than just the name. * When there are multiple linter errors, show them in a numbered list rather than bulleted, as they might otherwise look identical. Bug: T259570 Change-Id: I204a6466005cba1d6681dcf9884b5d3098f83371
* | | | | | | | | | | | Merge "Make phpunit:unit accept extension*.json to populate the classes"jenkins-bot2020-08-101-17/+12
|\ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | Make phpunit:unit accept extension*.json to populate the classesAmir Sarabadani2020-08-071-17/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Right now, for autoloading, it depends on a complex logic of DirectoryIterator and a hard-coded set of extension.json names. This is not useful and also doesn't pick up Wikibase extension.json files because they are extension-repo.json and extension-client.json which in turn causes all sorts of warnings This patch fixes that Bug: T243124 Change-Id: Iaf47a6f485f4ba2769b4e384278c8121366dd9a5
* | | | | | | | | | | | | Merge "concatenateChunks failures are not job failures"jenkins-bot2020-08-101-2/+4
|\ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | concatenateChunks failures are not job failuresMatthias Mullie2020-07-011-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | concatenateChunks can fail for many reasons, including - corrupt files - don't pass abusefilter - exceeds file limits etc. When we're unable to concatenate the chunks, it shouldn't be considered a job failure. It just didn't pass whatever requirements, and the user should be informed about it, but the job actually did what it had to do and it's not the software's fault that the file isn't any good. Besides, this job is only triggered on async uploads. Synchronous uploads call concatenateChunks directly, and no exceptions are thrown there when it fails to concatenate: we simply inform the users what happened - same as what's already happening for these async uploads as well. TL;DR: The job did what it has to do. Bug: T204881 Change-Id: Idf166d2fb509211080fb9e5f0e085467ef7d7ef2
* | | | | | | | | | | | | | Merge "Remove package-lock.json from the tarball"jenkins-bot2020-08-101-0/+1
|\ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | Remove package-lock.json from the tarballKunal Mehta2020-08-071-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Same rationale for excluding package.json. Change-Id: Ia56c02ac38db29de02c7ea983adc81f9b632a419
* | | | | | | | | | | | | | | Merge "Remove Gruntfile.js from the tarball"jenkins-bot2020-08-101-0/+1
|\| | | | | | | | | | | | | |
| * | | | | | | | | | | | | | Remove Gruntfile.js from the tarballKunal Mehta2020-08-071-0/+1
| | |_|_|_|/ / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We already exclude package.json so having Gruntfile.js is kind of useless since you don't know what versions of packages to install. Change-Id: I15dcb68e45a94c35c3500711eafb6573824dd472
* | | | | | | | | | | | | | Localisation updates from https://translatewiki.net.Translation updater bot2020-08-1031-98/+251
| |_|_|_|/ / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I1f30f66881f842682085d7c81af5fb6967376346
* | | | | | | | | | | | | Merge "skins: Call headElement() after getTemplateData() in SkinMustache"jenkins-bot2020-08-101-2/+6
|\ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | skins: Call headElement() after getTemplateData() in SkinMustacheAntiCompositeNumber2020-08-101-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | OutputPage::headElement calls OutputPage::getRlClient, which should be delayed for as long as practical, as it prevents the addition of any further ResourceLoader modules. One such module is ext.echo.styles.alert, which is added during a hook run during SkinVector::getTemplateData. Fixes regression introduced in 8acef095b9f23674e41ccc008ce00d1e9ef06594 Bug: T259872 Change-Id: Ibe1f07346cb19a7e40b00db3f72a615bb9cde6a5
* | | | | | | | | | | | | | Merge "firejail: Strengthen by copying from Wikimedia's profile"jenkins-bot2020-08-101-0/+28
|\ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | firejail: Strengthen by copying from Wikimedia's profileKunal Mehta2020-08-071-0/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This copies all of the non-Wikimedia specific entries from Wikimedia's firejail profile, incluing disallowing access to /sbin and its variants, important system files and various system utilities. Notably it blocks access to /run which typically has UNIX sockets that allow for sandbox escape. The one entry not copied over is disallowing /home because firejail does that already, and it can cause problems if your development setup is inside /home, but FirejailCommand already handles all of that appropriately. Change-Id: I4fd1d3005f18c249b45c9b9a72dff2bef6542b61
* | | | | | | | | | | | | | | Merge "Migrate l10n_cache and module_deps to abstract schema"jenkins-bot2020-08-099-38/+100
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|/ / / / / / / / |/| | | | | | | | | | | | | |
| * | | | | | | | | | | | | | Migrate l10n_cache and module_deps to abstract schemaAmir Sarabadani2020-08-069-38/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also, fixing two data type drifts in Postgres: - lc_key was varchar (with no binary flag) in MySQL but TEXT in Postgres while PG supports varchar. Changing PG to varchar. - lc_value was BYTEA but the rest of varbinary fields are mapped to TEXT, changing it to TEXT data type. And fixing primary key of these tables in Postgres too as it was a unique index instead. Bug: T198811 Bug: T164898 Bug: T230428 Change-Id: I50305556bd870461d05f98c5272cf1d6a65deb15
* | | | | | | | | | | | | | | Merge "Fix DROP CONSTRAINT for interwiki.iw_prefix PostgreSQL patch"jenkins-bot2020-08-081-2/+2
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|_|/ / / / / / |/| | | | | | | | | | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-22 19:52:31 +0000