aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Inline once-called short private methods to its caller, part 1Amir Sarabadani2023-12-1814-179/+34
| | | | | | | | | This makes the code easier to read to avoid jumps and improves encapsulation by not allowing the rest of the class having access to the logic. Of course, if needed then some code can be refactored out again but for now let's not do YAGNI. Change-Id: Ic37524e386fc04fd67e33768417ff8425f85b0ca
* Merge "ResourceLoader: Fix link in mw.requestIdleCallback docs"jenkins-bot2023-12-141-1/+2
|\
| * ResourceLoader: Fix link in mw.requestIdleCallback docsTimo Tijhof2023-12-141-1/+2
| | | | | | | | | | Bug: T353418 Change-Id: I3ff0c856751e7f71cf574da56acea508e0e02069
* | Merge "DEVELOPERS.md: Add note on Docker Desktop Rosetta setting"jenkins-bot2023-12-141-0/+4
|\ \
| * | DEVELOPERS.md: Add note on Docker Desktop Rosetta settingTheresNoTime2023-12-141-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | Add a note to disable the use of Rosetta if the user encounters a 503 error. https://phabricator.wikimedia.org/P49617 Change-Id: I8257b3767ab92d4b4ebc1201e712fe00b735bdab
* | | Merge "Namespace Site and SiteList"jenkins-bot2023-12-1423-15/+79
|\ \ \
| * | | Namespace Site and SiteListAmir Sarabadani2023-12-1423-15/+79
| | | | | | | | | | | | | | | | | | | | Bug: T353458 Change-Id: I31f7cba42c02701e462eb3ed6bcc3928d438c1ef
* | | | Merge "Replace $wgCommandLineMode checks with MW_ENTRY_POINT in developer code"jenkins-bot2023-12-143-8/+7
|\ \ \ \
| * | | | Replace $wgCommandLineMode checks with MW_ENTRY_POINT in developer codeBartosz Dziewoński2023-12-143-8/+7
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | This code should only be executed in development environments, never in production, so it should be safe to mess with it. Bug: T313841 Change-Id: I8cab7704b244db1432f4266b2e06e03452ffc98f
* | | | Merge "mw.util: introduce isInfinity to parity MW's wfIsInfinity()"jenkins-bot2023-12-145-5/+34
|\ \ \ \ | |_|/ / |/| | |
| * | | mw.util: introduce isInfinity to parity MW's wfIsInfinity()MusikAnimal2023-12-135-5/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In our JS, especially around watchlisting, we use both 'infinity' and 'infinite' as infinity values, depending on if we're talking about the expiry dropdown (which uses 'infinite') or API interaction (which more commonly uses 'infinity'). This patch adds a stable method to test if a string is infinity so that we don't need to worry about which context the value is coming from. Bug: T353389 Change-Id: If53a88b20deb09998281794028704a64d1379f92
* | | | UploadStashException: Remove redundant doc commentsBartosz Dziewoński2023-12-1412-24/+0
| |/ / |/| | | | | | | | Change-Id: I819de8dfc40526544f9bf129495424625fc0cdc9
* | | Merge "Use INFORMATION_SCHEMA instead of SHOW where possible"jenkins-bot2023-12-142-102/+44
|\ \ \
| * | | Use INFORMATION_SCHEMA instead of SHOW where possibleTim Starling2023-12-142-102/+44
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SHOW has some odd conventions and caveats which make the code surrounding it more complicated. Use information_schema instead, with a SelectQueryBuilder. Exclude views from DatabaseMySQL::listTables(), for consistency with the other DBMSes. This is an alternate fix for T45571 and renders listViews() unnecessary. Remove failing unit test for listViews(). I will deprecate listViews() in a followup commit. Change-Id: Id9ab64fc8b09d9d61dc64253b7c9ea5a955ca50b
* | | Merge "Add Guadeloupean Creole to Names.php"jenkins-bot2023-12-143-0/+14
|\ \ \
| * | | Add Guadeloupean Creole to Names.phpJon Harald Søby2023-12-143-0/+14
| | | | | | | | | | | | | | | | | | | | Bug: T353307 Change-Id: I8389b7d02befcd664f121b962ef010bc90b972d3
* | | | Localisation updates from https://translatewiki.net.Translation updater bot2023-12-1417-77/+774
| |/ / |/| | | | | | | | Change-Id: I758e6650451f8a4a0e81ddc7e70ca70d18cd3e3c
* | | Simplify addIdentifierQuotes and its inverseTim Starling2023-12-136-125/+97
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Instead of quoting any possible input as an identifier, validate the input and fail if it contains a special character. This allows us to simplify the implementation of the corresponding unquoting in SQLPlatform::extractTableNameComponents. * Add getIdentifierQuoteChar(), and unify the implementations except for this one detail. * addIdentifierQuotes() was/is not abstract. Remove the incorrect comment about this from DatabaseTest. I tried removing the stub from SQLPlatformTestHelper but there were 170 test failures, so it gets a TODO for now. Change-Id: I711968b17b303bbb5efd2882bc676b695d25ef7f
* | | Merge "mediawiki:string: Document module"jenkins-bot2023-12-132-22/+28
|\ \ \
| * | | mediawiki:string: Document moduleJon Robson2023-12-132-22/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes: * Addresses eslint warnings relating to multiple @return types * Adopt ES6 shorthand function for return values Bug: T352308 Change-Id: I43cb7e8e5f8c9ded46249e5f26a60a314b7d8cb1
* | | | Merge "rdbms: clean up tableName() handling of pre-quoted names"jenkins-bot2023-12-134-69/+164
|\ \ \ \
| * | | | rdbms: clean up tableName() handling of pre-quoted namesAaron Schulz2023-12-134-69/+164
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds a SQLPlatform::extractTableNameComponents() helper method to replace the buggy explode() call in in qualifiedTableComponents(). Make qualifiedTableComponents() handle the job of filtering out empty table name qualifier components. This also avoids the 4-tuple return value where $database and $schema could be flipped depending on the RDBMS type. Remove SQLPlatform::prependDatabaseOrSchema() helper method by putting the quoting log in tableName() directly. Bug: T352316 Change-Id: I8c071cc19d99339484960f737a42287ad626736f
* | | | Merge "Fix declared method name of SiteConfig:mainPageLinkTarget()"jenkins-bot2023-12-131-1/+1
|\ \ \ \
| * | | | Fix declared method name of SiteConfig:mainPageLinkTarget()C. Scott Ananian2023-12-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Parsoid is renaming SiteConfig::mainpage() to SiteConfig::mainPageLinkTarget() (with a parameter type change to match). The core-side implementation of the new method misspelled its name. Change-Id: I22f10ed25a9e4f8ce38c08cdeb10c69a54229a9c
* | | | | Merge "tests: Fix name of class property in ApiQueryImageInfoTest"jenkins-bot2023-12-131-1/+1
|\ \ \ \ \ | |_|_|_|/ |/| | | |
| * | | | tests: Fix name of class property in ApiQueryImageInfoTestUmherirrender2023-12-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Creation of dynamic property ApiQueryImageInfoTest::$tempUser is deprecated in php8.2 Follow-Up: I7986dea5ccd0dc942bf133040c4ac715487f29b9 Change-Id: Ifa2b1fc46a30edb12266d46b71d8916c53397cc0
* | | | | Merge "tests: Skip failing tests on php8.3 (and make pass)"jenkins-bot2023-12-132-0/+8
|\ \ \ \ \
| * | | | | tests: Skip failing tests on php8.3 (and make pass)Umherirrender2023-12-132-0/+8
| | |_|_|/ | |/| | | | | | | | | | | | | Change-Id: I2055d56a185c64b2ee1da6ab2e985b5a8f771352
* / | | | mediawiki.util: Correctly document parseImageUrl return typeJon Robson2023-12-131-11/+15
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently there are two @return annotations meaning this is not correctly documented. eslint flags this as a warning. Instead use a @typedef to describe the return type. Follow up to Ia709de48cbc0f00ff832eb4666e6abcffdb6f710 Bug: T352308 Change-Id: I960a4569335c35b4a60fd9dbc1d1ab7cdcc0cf82
* | | | Merge "build: Raise TestingAccessWrapper from 2.0.0 to 3.0.0"jenkins-bot2023-12-132-1/+2
|\ \ \ \
| * | | | build: Raise TestingAccessWrapper from 2.0.0 to 3.0.0James D. Forrester2023-12-072-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Breaking change is only dropping PHP 7.2 & 7.3 support, which we already don't support here. Full list of changes (as no 'upstream' changelog): d260476 build: Updating ockcyp/covers-validator to 1.3.1 c5f7bf0 build: Updating mediawiki/mediawiki-codesniffer to 34.0.0 27e4b91 Remove unneeded \ with ReflectionException 52d95d0 build: Updating composer dependencies 4502843 Add tests to cover currently uncovered lines 19c8b76 build: Updating composer dependencies 2ecdc9d build: Cleanup and improve .phpcs.xml 98375ff build: Updating mediawiki/mediawiki-codesniffer to 37.0.0 a4813ea build: Updating composer dependencies b62e9d6 build: Updating composer dependencies 9c5f87e build: Updating composer dependencies 7b31aab [BREAKING CHANGE] Drop PHP 7.2 and PHP 7.3 support 89423ac build: Upgrade PHPUnit from ^8.5 to 9.5.28 f100e7f build: Updating mediawiki/mediawiki-codesniffer to 41.0.0 a06a1e5 tests: Make data provider a static method e3c0ef8 build: add phan 975c15c Add TestingAccessWrapper::construct() to use non-public constructors 975e899 Avoid deprecation warning for static properties Bug: T352789 Bug: T287972 Change-Id: Ie4b93e737d98242fbad33f7b690a2412bdce543d Depends-On: Iff3556dbff2cc1d9333d83f09d21765ee83bf1e9
* | | | | Merge "EditPage: move wasPosted() logic to dedicated method"jenkins-bot2023-12-131-156/+164
|\ \ \ \ \ | |_|/ / / |/| | | |
| * | | | EditPage: move wasPosted() logic to dedicated methodMusikAnimal2023-12-121-156/+164
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This merely cleans up the file a bit, and will make reviewing I383b5a9fd2 considerably easier. Change-Id: Ida983d138365aca279a1949b7f92650a5f139dc1
* | | | | Merge "Documentation: Migrate jQuery lengthLimit plugin to JSDoc"jenkins-bot2023-12-132-11/+13
|\ \ \ \ \
| * | | | | Documentation: Migrate jQuery lengthLimit plugin to JSDocAnne Tomasevich2023-12-132-11/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T352308 Change-Id: Ie415603420b818bb3aa20215965d488b538a0931
* | | | | | Merge "Documentation: Migrate mw.experiments docs to JSDoc"jenkins-bot2023-12-132-12/+8
|\ \ \ \ \ \
| * | | | | | Documentation: Migrate mw.experiments docs to JSDocAnne Tomasevich2023-12-132-12/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T352308 Change-Id: I3bccaab232647f2c368758bd6c7e395d9b009bae
* | | | | | | Merge "Remove duplicate closing HTML tag </ul>"jenkins-bot2023-12-131-1/+1
|\ \ \ \ \ \ \
| * | | | | | | Remove duplicate closing HTML tag </ul>Fomafix2023-12-131-1/+1
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | Change-Id: I6a90dcd0ef12bfc2745cae79d20dc5d80d91b744
* | | | | | | Merge "tests: Set rc_log_type in RecentChangeTest for log events"jenkins-bot2023-12-131-0/+4
|\ \ \ \ \ \ \
| * | | | | | | tests: Set rc_log_type in RecentChangeTest for log eventsUmherirrender2023-12-121-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When running tests together with the CheckUser extension there is a database error, for RC_LOG both fields must be not-null Error 1048: Column 'cupe_log_type' cannot be null Function: MediaWiki\CheckUser\Hooks::updateCheckUserData Change-Id: I188df89b75a57aa1cc82c77f5c925bee634501cb
* | | | | | | | Merge "Add `temp` flags to api calls"jenkins-bot2023-12-138-3/+127
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | |
| * | | | | | | Add `temp` flags to api callsSTran2023-12-128-3/+127
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Temporary accounts are now distinct from users or anonymous. Add a flag to reflect that to: - ApiQueryImageInfo - ApiQueryLogEvents - ApiQueryRecentChanges - ApiQueryRevisionsBase Bug: T351636 Change-Id: I7986dea5ccd0dc942bf133040c4ac715487f29b9
* | | | | | | | Merge "PoolCounterConnectionManager: Add support for ipv6"jenkins-bot2023-12-132-4/+65
|\ \ \ \ \ \ \ \
| * | | | | | | | PoolCounterConnectionManager: Add support for ipv6Paladox2023-12-132-4/+65
| | |_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: T350615 Change-Id: Iee6c5506623a370485755e3377b1199dc8ceb0de
* | | | | | | | Merge "Documentation: Fix broken one-line description in mw.util"jenkins-bot2023-12-131-1/+1
|\ \ \ \ \ \ \ \
| * | | | | | | | Documentation: Fix broken one-line description in mw.utilAnne Tomasevich2023-12-131-1/+1
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The description gets truncated after the full stop + space. This patch reformats it so the entire thing will display. Bug: T353285 Change-Id: I43a217ff9867883e4041ef0ceb707a884faf906f
* | | | | | | | Merge "Redesign the installer with Codex"jenkins-bot2023-12-1314-360/+229
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | |
| * | | | | | | Redesign the installer with CodexAmir Sarabadani2023-12-1314-360/+229
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is not perfect, but it's a major improvement compared the existing one. We need to clean up a lot more once it has landed but it's a good start. Bug: T337435 Change-Id: I1f85110e754546c797d3325b8dd6878093790266
* | | | | | | | Merge "Fix typo in maintenance script"jenkins-bot2023-12-131-1/+1
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-24 01:32:05 +0000