| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Bug: T138016
Change-Id: I4824802b2796ee0bb9488d528de1f07ef8c6152f
|
|
|
|
|
|
|
| |
This is the default directory for FileCache (as enabled with $wgUseFileCache).
Used by HTMLFileCache (article views) and ResourceFileCache (load.php).
Change-Id: I8c3ccb734268b0902b693c2c19125f7f858898f1
|
|
|
|
|
|
|
|
|
| |
People and tools sometimes accidentally commit these, let's make it
more difficult to do.
Follow-up to abb4271a. NO ONE SAW THIS EMBARASSING MISTAKE.
Change-Id: If5f427586814c304b30e5783a59f33814bfeaa54
|
|
|
|
|
|
|
| |
People and tools sometimes accidentally commit these, let's make it
more difficult to do.
Change-Id: I05574d46186642940054aaecec055723c7ade8ac
|
|
|
|
|
|
|
|
|
|
|
| |
Require Composer merge plugin to allow easier local Composer dependency
management without composer.json edit conflicts. The configuration
provided will merge Composer configuration directives found in
a `composer.local.json` config file into those specified by MediaWiki's
composer.json file at Composer runtime.
Bug: T67188
Change-Id: I66a19d0154191e536aab37a5e183e4505bf3e9be
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MediaWiki tends to assume installation of phpunit via PEAR.
Distribution of phpunit via PEAR will eventually be discontinued,
in favor of distribution via PHAR or composer. PEAR installation
of phpunit 4.0 essentially distributes a phar.
https://github.com/sebastianbergmann/phpunit/wiki/Release-Announcement-for-PHPUnit-4.0.0
This patch allows phpunit.php to work with a phpunit.phar file,
as long as it's in the include path. --with-phpunitdir can be used
to add a directory to the include path.
With composer install, no options are needed and it works.
Bug: 58881
Change-Id: Ibac9b36bbb9614d990c697a091947a64c8987d1d
|
|
|
|
|
|
| |
Broken after a change in directory structure...
Change-Id: Ibe208302c30483ee9476a176efe8dd88b21d30a5
|
|
|
|
|
|
| |
Run make kss to generate a style guide for mediawiki.ui
Change-Id: Ib2db52a855f7eb924a59eebfff88e23600af78d6
|
|
|
|
|
|
|
| |
One might want to have those in there in a development
environment.
Change-Id: Ie5f4bbc15cb738c9801490e800255470ceb42d79
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was the only SASS in core.
Remove gradient hacks for IE<10 (proprietary filter property) in
vertical-gradient mixin. Buttons look fine without gradients too,
and filter can often signfificantly degrade performance:
http://gomilkyway.com/web/why-site-is-so-slow-on-ie-even-to-scroll-poor-ie-performance/
http://coding.smashingmagazine.com/2010/04/28/css3-solutions-for-internet-explorer/
http://msdn.microsoft.com/en-us/library/ms532847%28VS.85%29.aspx
(look for "performance")
Remove text-shadow for button's text which had no effect on appearance.
Remove obsolete or non-existent vendor-prefixed properties:
* display: -moz-inline-stack (not needed for Firefox 3+)
* -webkit-border-radius, -moz-border-radius (supported for sometime
without a prefix, graceful degradation for old browsers)
* -ms-border-radius, -o-border-radius (never existed)
Remove *vertical-align: auto from IE6/IE7 inline hack. Can't find any
evidence that it's necessary.
Bug: 54485
Change-Id: I81d8d0c9f6705aef8bdb8a28e1154f2de4301235
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Makefile removes this automatically, but compass watch won't do that
for you. Much better to just .gitignore it so we don't have to worry
about it.
See resources/mediawiki.ui/sourcefiles to see what I mean, and see
https://www.mediawiki.org/wiki/Agora/Engineering#Working_with_the_Compass_code
for documentation about the current approach.
Change-Id: Icf7dbc9e19f0615c5fcc88924a17ae695df0ff05
|
|
|
|
| |
Change-Id: Ia7e22c2219040c7137a0f4ddc1dbb8ec1861a2d3
|
|
|
|
| |
Change-Id: I9b5d03443d6b0f536ad887b25bbf86716a212742
|
|
|
|
|
|
|
|
|
| |
In Git (at least in version 1.8.x) entries without leading slash
can be matches in any subdirectory.
Add a / in front of all those that should only be in the root.
Change-Id: I61e2be30ac24c5b369a1d36869fbd027f197bebf
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Adding configuration files for jsduck.
* Fixing our previously undocumented code documentation to comply
with jsduck specifications
.. for the following modules:
- mediawiki
- mediawiki.Title
- mediawiki.util
- mediawiki.notification
- mediawiki.api (and plugins thereof)
- jquery.localize
I've choose these to show as many different examples for
different types of modules and methods that we encounter
in our code base.
Hopefully with this as a start it will be easy for other people
to extend the documentation for most (if not, all) other modules
we have in MediaWiki core.
Change-Id: Ieb8c5d2d2cb4672f1d6abc3f865c6fb1470d8feb
|
|/
|
|
|
|
|
|
|
|
| |
The Composer dependencie manager installs components under /vendor by
default so simply ignore that path. We do not care of tracking the
composer.* files, they will always be local just like LocalSettings.php.
Extensions are properly installed under /extensions/.
Change-Id: I7c50ee11edf2f7b1d71533fc32a75831a384a630
|
|
|
|
|
|
|
| |
git-deploy writes a status file at the root of the working copy. We want
to always ignore it.
Change-Id: I4dbbce669ba4d194c3ce5568733bd27db51fd40e
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were still some files not passing jshint, and for files
that did, we managed to screw 'em up again.
Added more explicit settings in .jshintrc to avoid relying on a
kind of default somewhere. There are too many default-factors:
closest(.jshintrc), ~/.jshintrc, IDE/editor, node-jshint..
Added node_modules/ and extensions/ to .jshintignore.
Previously "$ jshint ." would recurse over all kinds of
unrelated code. Extensions should have their own jshint
dotfiles. When linting from Jenkins this won't be a problem as
those will be ran per repo (so when linting core it will skip extensions and when in an extension dir, the core dotfiles
don't apply as they'll be out of scope).
Some of our modules are really messy and should be refactored
to be less spaghetti-ish and have more descriptive variable
names and more manageable function-level complexity.
But for this commit, I'm keeping it as much as-is as possible,
because its hard/large enough to review as it is.
A few errors are cited below to give an impression of the kind
of warnings I addressed (for cases where the diff isn't
so obvious):
* jquery.hidpi.js: line 110, col 15, Empty block.
* mediawiki.jqueryMsg.js: line 34, col 17, Too many var statements.
* mediawiki.jqueryMsg.js: line 145, col 33, Strings must use singlequote.
* mediawiki.action.edit.js: line 74, col 73, 'selectText' is defined but never used.
* startup.js: line 19, col 22, 'isCompatible' is defined but never used.
* jquery.byteLength.test.js: line 26, col 9, Identifier 'U_00A2' is not in camel case.
* jquery.localize.test.js: line 63, col 29, 'attrs' is defined but never used.
* mediawiki.cldr.test.js: line 72, col 27, 'mw' is not defined.
* mediawiki.jscompat.test.js: line 6, col 17, Strings must use singlequote.
* mediawiki.api.parse.test.js: line 9, col 17, Strings must use singlequote.
* mediawiki.api.parse.test.js: line 7, col 15, 'mw' is not defined.
* mediawiki.api.parse.test.js: line 14, col 24, '$' is not defined.
* mediawiki.api.test.js: line 43, col 28, 'data' is defined but never used.
Other fixes:
* Add closures fix implied global errors ($, mw and more),
and prevents local variables from becoming globals.
* Avoid jQ magic map arg etc. (per code conventions).
* Fix incorrect usage of jQuery methods (prop instead of attr,
prop false instead of removeProp, ..).
* Unquote keys in object literals for consistency, and
enforce single quotes (no magic quotes in javascript, as much
as we might think "\n" and '/n' are really exactly the same).
Chose single quotes over double quotes since that's what most
code already had and what conventions seemed to prefer
(both the old generic ones and the new per-lang ones since
2011/2012).
* Enforce camelCase variable names with jshint per code
conventions.
* $foo.on('x', fn).trigger('x') -> $foo.on('x', fn); fn()
(No event simulation overhead, unless intended of course)
* Incorrect indentation (ignore whitespace in the diff!).
* Avoid proprietary selectors like ':first' when .eq(0)
afterwards is just as possible (significantly faster in
jQuery due to mostly avoiding the Sizzle engine and going
native in modern browsers).
* When at it, convert deprecated jQuery methods to new ones.
Mostly just .delegate(sel, type, fn) -> .on(type, sel, fn).
* Addressed whitespace here and there.
Interesting:
* mediawiki.js: local function "compare" wasn't used anymore
(hasn't been in a while!) removed per jshint warning.
* mediawiki.special.recentchanges.js: Was a mess, only a few
lines of code, rewritten.
Pfew, let's hope it's the last one before we lint from Jenkins!
Change-Id: I23ad60a1d804c542d9b91454aaa20ce7be4ff289
|
|
|
|
| |
Change-Id: I3f7ea6a6ce123aff7f422b3e6f59f38f21c4ff00
|
|
|
|
| |
Change-Id: I3ebecc6d2b8b13e774091e0ba4b7afa882d89e1d
|
|
|
|
|
|
| |
* Follows-up 82b127b3306b3e239df05659ad2eadcc50de83c7.
Change-Id: I57fcc41ad22ec748c8c772aeccd1e9df6d4646f7
|
|
|
|
| |
Change-Id: Ibe72feb189e8f709c9f0ffd113bfcb926a561e8c
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On fenari we've always got:
> Untracked files:
> (use "git add <file>..." to include in what will be committed)
>
> cache/l10n/
> cache/message-timestamp
And on my localhost also several files and stuff extensions have
put in there. Might as well ignore cache entirely instead of
just .cdb files.
Change-Id: I3c594a0f746341687c2a35eed5dc2c2b91e68265
|
|
|
|
| |
Change-Id: Idddfac5af757aa2869a2db25f10ca7ef6f4820a9
|
|
|
|
| |
Change-Id: Ib353db437c5dd5b57e785cc4215b3fb42e9b3420
|
|
|
|
| |
Change-Id: Ia5ca3b8a20de1ba7cb0fec3826138f82dbc578cf
|
|
|
|
|
|
| |
These are temporary files created by Kate, a popular text editor in KDE.
Change-Id: I72e3eca752940e864c257a23014e335f4d181f4a
|
|
|
|
|
|
|
| |
sql.php attempts to generates an history file in the user homedir and
fallback on using maintenance/.mwsql_history
Change-Id: Iad23df30fd00e5d99242d34e7338f9caeedb09e4
|
|
|
|
|
|
| |
Add maintenance/dev/'s sqlite directory and maintenance/eval.php's history file to .gitignore.
Change-Id: I574532dc1d5475fb929cebd1934bd0149ea27039
|
|
|
|
| |
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/109983
|
|
This is the same as the svn:ignore property with the addition of '.svn'
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/107873
|