diff options
| author | Dreamy Jazz <dreamyjazzwikipedia@gmail.com> | 2024-10-08 21:38:00 +0100 |
|---|---|---|
| committer | Dreamy Jazz <dreamyjazzwikipedia@gmail.com> | 2024-10-08 21:51:59 +0100 |
| commit | 5a5d4a8aa1c2fba76204af35eeb9480643e4c1c2 (patch) | |
| tree | 42a7ade1a5df5dcdd5a1579060aaf89804ef7bc3 /maintenance | |
| parent | a725ca8a7fad9a2eb1c8eb9d10cf6a74707f803b (diff) | |
| download | mediawikicore-5a5d4a8aa1c2fba76204af35eeb9480643e4c1c2.tar.gz mediawikicore-5a5d4a8aa1c2fba76204af35eeb9480643e4c1c2.zip | |
Expand tests for rename user maintenance scripts
Why:
* Maintenance scripts in core are mostly untested
* Increasing this test coverage, especially for more critical
scripts, will help avoid bugs and regressions.
What:
* Add tests for renameUsersMatchingPattern.php
* Expand tests for renameUser.php
* Add TestSelectQueryBuilder::assertFieldValues, which is used
to assert against the result of ::fetchFieldValues.
Bug: T371167
Change-Id: I0470c53df7f31ae4891c33aeb5ba6e308bdcdac6
Diffstat (limited to 'maintenance')
| -rw-r--r-- | maintenance/renameUsersMatchingPattern.php | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/maintenance/renameUsersMatchingPattern.php b/maintenance/renameUsersMatchingPattern.php index c2142cb40f36..bf7c8abb6f9b 100644 --- a/maintenance/renameUsersMatchingPattern.php +++ b/maintenance/renameUsersMatchingPattern.php @@ -80,8 +80,7 @@ class RenameUsersMatchingPattern extends Maintenance { $performer = $this->userFactory->newFromName( $this->getOption( 'performer' ) ); } if ( !$performer ) { - $this->error( "Unable to get performer account" ); - return false; + $this->fatalError( "Unable to get performer account" ); } $this->performer = $performer; |