Bump codesniffer to 42.0.0

Most noisily, this enables MediaWiki.Arrays.OneSpaceInlineArray.

Change-Id: I8ab11399c67ce7e3ab1b6249b591452774393428

6 files changed, 7 insertions, 8 deletions

diff --git a/includes/ResourceLoader/VueComponentParser.php b/includes/ResourceLoader/VueComponentParser.php
index 7696f645be2a..cd64a676d751 100644
--- a/includes/ResourceLoader/VueComponentParser.php
+++ b/includes/ResourceLoader/VueComponentParser.php
@@ -33,7 +33,6 @@ use Wikimedia\RemexHtml\Serializer\SerializerNode;
 use Wikimedia\RemexHtml\Tokenizer\Attributes;
 use Wikimedia\RemexHtml\Tokenizer\Tokenizer;
 use Wikimedia\RemexHtml\TreeBuilder\Dispatcher;
-use Wikimedia\RemexHtml\TreeBuilder\Element;
 use Wikimedia\RemexHtml\TreeBuilder\TreeBuilder;
 use Wikimedia\Zest\Zest;
 
diff --git a/includes/changes/ChangesList.php b/includes/changes/ChangesList.php
index c840c5852dcb..8af1479bf837 100644
--- a/includes/changes/ChangesList.php
+++ b/includes/changes/ChangesList.php
@@ -941,7 +941,7 @@ class ChangesList extends ContextSource {
 				$this->getUser()->getName(),
 				$this->getLanguage()->getCode()
 			),
-			fn() => ChangeTags::formatSummaryRow(
+			fn () => ChangeTags::formatSummaryRow(
 				$rc->mAttribs['ts_tags'],
 				'changeslist',
 				$this->getContext()
diff --git a/includes/changes/RCCacheEntryFactory.php b/includes/changes/RCCacheEntryFactory.php
index be972f49d644..47374574f1ba 100644
--- a/includes/changes/RCCacheEntryFactory.php
+++ b/includes/changes/RCCacheEntryFactory.php
@@ -111,7 +111,7 @@ class RCCacheEntryFactory {
 					$this->context->getUser()->getName(),
 					$this->context->getLanguage()->getCode()
 				),
-				static fn() => Linker::userToolLinks(
+				static fn () => Linker::userToolLinks(
 					$cacheEntry->mAttribs['rc_user'],
 					$cacheEntry->mAttribs['rc_user_text'],
 					// Should the contributions link be red if the user has no edits (using default)
@@ -330,7 +330,7 @@ class RCCacheEntryFactory {
 					$this->context->getUser()->getName(),
 					$this->context->getLanguage()->getCode()
 				),
-				static fn() => Linker::userLink(
+				static fn () => Linker::userLink(
 					$cacheEntry->mAttribs['rc_user'],
 					$cacheEntry->mAttribs['rc_user_text'],
 					ExternalUserNames::getLocal( $cacheEntry->mAttribs['rc_user_text'] )
diff --git a/includes/jobqueue/jobs/RecentChangesUpdateJob.php b/includes/jobqueue/jobs/RecentChangesUpdateJob.php
index 34c2f35706c5..2079953f7d2f 100644
--- a/includes/jobqueue/jobs/RecentChangesUpdateJob.php
+++ b/includes/jobqueue/jobs/RecentChangesUpdateJob.php
@@ -232,7 +232,7 @@ class RecentChangesUpdateJob extends Job {
 			->replaceInto( 'querycache_info' )
 			->rows( [
 				'qci_type' => 'activeusers',
-				'qci_timestamp' => $dbw->timestamp( $asOfTimestamp ) , // not always $now
+				'qci_timestamp' => $dbw->timestamp( $asOfTimestamp ), // not always $now
 			] )
 			->uniqueIndexFields( [ 'qci_type' ] )
 			->caller( __METHOD__ )->execute();
diff --git a/includes/libs/virtualrest/ParsoidVirtualRESTService.php b/includes/libs/virtualrest/ParsoidVirtualRESTService.php
index 99f30339d129..f020c0d5eb8c 100644
--- a/includes/libs/virtualrest/ParsoidVirtualRESTService.php
+++ b/includes/libs/virtualrest/ParsoidVirtualRESTService.php
@@ -89,14 +89,14 @@ class ParsoidVirtualRESTService extends VirtualRESTService {
 		foreach ( $reqs as $key => $req ) {
 			$parts = explode( '/', $req['url'] );
 
-			list(
+			[
 				$targetWiki, // 'local'
 				$version, // 'v3' ('v1' for restbase compatibility)
 				$reqType, // 'page' or 'transform'
 				$format, // 'html' or 'wikitext'
 				// $title (optional)
 				// $revision (optional)
-			) = $parts;
+			] = $parts;
 
 			if ( isset( $this->params['restbaseCompat'] ) && $this->params['restbaseCompat'] ) {
 				if ( $version !== 'v1' ) {
diff --git a/includes/specials/pagers/ContribsPager.php b/includes/specials/pagers/ContribsPager.php
index 831c6e0cbf89..2e7536cc45b0 100644
--- a/includes/specials/pagers/ContribsPager.php
+++ b/includes/specials/pagers/ContribsPager.php
@@ -811,7 +811,7 @@ class ContribsPager extends RangeChronologicalPager {
 					$this->getUser()->getName(),
 					$lang->getCode()
 				),
-				fn() => ChangeTags::formatSummaryRow(
+				fn () => ChangeTags::formatSummaryRow(
 					$row->ts_tags,
 					null,
 					$this->getContext()