diff options
author | Krinkle <krinkle@users.mediawiki.org> | 2012-01-29 19:05:25 +0000 |
---|---|---|
committer | Krinkle <krinkle@users.mediawiki.org> | 2012-01-29 19:05:25 +0000 |
commit | c902f9a9e9e4d7b6bf59d9d9cb7b1709c3408b24 (patch) | |
tree | 524c044948630f2a7514b2609de68f26d5722c75 /includes/specials | |
parent | e0e8f92227f6a62a836d167378116680ac6ae9d1 (diff) | |
download | mediawikicore-c902f9a9e9e4d7b6bf59d9d9cb7b1709c3408b24.tar.gz mediawikicore-c902f9a9e9e4d7b6bf59d9d9cb7b1709c3408b24.zip |
[specials] Xml::namespaceSelector > Html::namespaceSelector
* Makes front-end more reliable by not relying on Xml::namespaceSelector to use name="namespace" in it's output, which these forms where then requesting hardcoded from WebRequest
* Poke r109990
Notes
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/110252
Diffstat (limited to 'includes/specials')
-rw-r--r-- | includes/specials/SpecialAllpages.php | 5 | ||||
-rw-r--r-- | includes/specials/SpecialRecentchanges.php | 5 |
2 files changed, 8 insertions, 2 deletions
diff --git a/includes/specials/SpecialAllpages.php b/includes/specials/SpecialAllpages.php index 660e3beb0fec..960a327a051d 100644 --- a/includes/specials/SpecialAllpages.php +++ b/includes/specials/SpecialAllpages.php @@ -127,7 +127,10 @@ class SpecialAllpages extends IncludableSpecialPage { Xml::label( $this->msg( 'namespace' )->text(), 'namespace' ) . " </td> <td class='mw-input'>" . - Xml::namespaceSelector( $namespace, null ) . ' ' . + Html::namespaceSelector( + array( 'selected' => $namespace ), + array( 'name' => 'namespace', 'id' => 'namespace' ) + ) . ' ' . Xml::submitButton( $this->msg( 'allpagessubmit' )->text() ) . " </td> </tr>"; diff --git a/includes/specials/SpecialRecentchanges.php b/includes/specials/SpecialRecentchanges.php index 067a95644f25..06a8a0ce3249 100644 --- a/includes/specials/SpecialRecentchanges.php +++ b/includes/specials/SpecialRecentchanges.php @@ -655,7 +655,10 @@ class SpecialRecentChanges extends IncludableSpecialPage { * @return String */ protected function namespaceFilterForm( FormOptions $opts ) { - $nsSelect = Xml::namespaceSelector( $opts['namespace'], '' ); + $nsSelect = Html::namespaceSelector( + array( 'selected' => $opts['namespace'], 'all' => '' ), + array( 'name' => 'namespace', 'id' => 'namespace' ) + ); $nsLabel = Xml::label( wfMsg( 'namespace' ), 'namespace' ); $invert = Xml::checkLabel( wfMsg( 'invert' ), 'invert', 'nsinvert', |