diff options
| author | jenkins-bot <jenkins-bot@gerrit.wikimedia.org> | 2023-03-10 23:59:57 +0000 |
|---|---|---|
| committer | Gerrit Code Review <gerrit@wikimedia.org> | 2023-03-10 23:59:57 +0000 |
| commit | 4c1ae11a41b313dd6a60bdf305b4a587f4e71af1 (patch) | |
| tree | 94fa3a4ce9a6619c022e01dc669b201f780cbce8 /includes/pager | |
| parent | dcd31ad56ce892819ee19157ea4317469417a672 (diff) | |
| parent | b1a287ca61d732b9dd98b2066ff81cc36f5ea01d (diff) | |
| download | mediawikicore-4c1ae11a41b313dd6a60bdf305b4a587f4e71af1.tar.gz mediawikicore-4c1ae11a41b313dd6a60bdf305b4a587f4e71af1.zip | |
Merge "htmlform: Skip array query parameter on HtmlForm::addHiddenField"
Diffstat (limited to 'includes/pager')
| -rw-r--r-- | includes/pager/TablePager.php | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/includes/pager/TablePager.php b/includes/pager/TablePager.php index 2efd62525cb7..2fd8689234a1 100644 --- a/includes/pager/TablePager.php +++ b/includes/pager/TablePager.php @@ -394,6 +394,7 @@ abstract class TablePager extends IndexPager { * Get \<input type="hidden"\> elements for use in a method="get" form. * Resubmits all defined elements of the query string, except for a * exclusion list, passed in the $noResubmit parameter. + * Also array values are discarded for security reasons (per WebRequest::getVal) * * @param array $noResubmit Parameters from the request query which should not be resubmitted * @return string HTML fragment @@ -406,6 +407,10 @@ abstract class TablePager extends IndexPager { } $s = ''; foreach ( $query as $name => $value ) { + if ( is_array( $value ) ) { + // Per WebRequest::getVal: Array values are discarded for security reasons. + continue; + } $s .= Html::hidden( $name, $value ) . "\n"; } return $s; |