diff options
| author | jenkins-bot <jenkins-bot@gerrit.wikimedia.org> | 2020-06-24 09:29:25 +0000 |
|---|---|---|
| committer | Gerrit Code Review <gerrit@wikimedia.org> | 2020-06-24 09:29:25 +0000 |
| commit | 1dd24c56e85c7bb1c0a12594858073fa625680eb (patch) | |
| tree | bdd43477fd4313312fcfa6901c7f6dcb2cd3e08a /includes/diff | |
| parent | 6c9d6945e9d3556764b505129bc5fca1b46b20b7 (diff) | |
| parent | eb095ad3116a0721ebc872907e3c08fac851a17f (diff) | |
| download | mediawikicore-1dd24c56e85c7bb1c0a12594858073fa625680eb.tar.gz mediawikicore-1dd24c56e85c7bb1c0a12594858073fa625680eb.zip | |
Merge "diff: Remove unneeded false check"
Diffstat (limited to 'includes/diff')
| -rw-r--r-- | includes/diff/DifferenceEngine.php | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php index f0d2dd2ccba9..0e7019f2e880 100644 --- a/includes/diff/DifferenceEngine.php +++ b/includes/diff/DifferenceEngine.php @@ -1235,16 +1235,14 @@ class DifferenceEngine extends ContextSource { // Save to cache for 7 days if ( !$this->hookRunner->onAbortDiffCache( $this ) ) { $stats->updateCount( 'diff_cache.uncacheable', 1 ); - } elseif ( $key !== false && $difftext !== false ) { + } elseif ( $key !== false ) { $stats->updateCount( 'diff_cache.miss', 1 ); $cache->set( $key, $difftext, 7 * 86400 ); } else { $stats->updateCount( 'diff_cache.uncacheable', 1 ); } // localise line numbers and title attribute text - if ( $difftext !== false ) { - $difftext = $this->localiseDiff( $difftext ); - } + $difftext = $this->localiseDiff( $difftext ); return $difftext; } |