Replace unspecific exceptions with InvalidArgumentException

A LogicException is very generic and doesn't mean much. An
InvalidArgumentException is also a LogicException, but more
specific: A method was called (for whatever reason – bad code,
bad user input – we don't know) with an invalid, unsupported
argument. This is exactly what's going on in these cases.

BadMethodCallException does have a confusing name and is often
misused because of this. It's documented as "thrown if a callback
refers to an undefined method or if some arguments are missing".
That's something else and not what's going on in these cases.

Change-Id: Id446227f578ba701e22acd5e530ffb795e76c147

1 files changed, 1 insertions, 1 deletions

diff --git a/includes/api/ApiBase.php b/includes/api/ApiBase.php
index f52fbf2f60d3..607661ffa843 100644
--- a/includes/api/ApiBase.php
+++ b/includes/api/ApiBase.php
@@ -1583,7 +1583,7 @@ abstract class ApiBase extends ContextSource {
 	 */
 	public function dieStatus( StatusValue $status ) {
 		if ( $status->isGood() ) {
-			throw new LogicException( 'Successful status passed to ApiBase::dieStatus' );
+			throw new InvalidArgumentException( 'Successful status passed to ApiBase::dieStatus' );
 		}
 
 		foreach ( self::MESSAGE_CODE_MAP as $msg => [ $apiMsg, $code ] ) {