diff options
author | Bartosz Dziewoński <dziewonski@fastmail.fm> | 2024-11-03 16:16:42 +0100 |
---|---|---|
committer | Bartosz Dziewoński <dziewonski@fastmail.fm> | 2024-11-14 02:44:50 +0100 |
commit | 2f60085f9da63bbea3df68b39c44f9add307de26 (patch) | |
tree | 7a1e61da2ff54830fbeba2a0aecedbc7ba76fd33 /includes/Navigation | |
parent | 72db9047bf68db74489d209910569e0d8ac84981 (diff) | |
download | mediawikicore-2f60085f9da63bbea3df68b39c44f9add307de26.tar.gz mediawikicore-2f60085f9da63bbea3df68b39c44f9add307de26.zip |
Add type hints to detect bool/null message params
Add more precise type hints to every method I could find that takes
message params as arguments, so that Phan will warn if bool or null
is passed, which is deprecated (T378876).
Errors found in this repository thanks to these checks
are fixed in I286a4a51e879bdf61f65c87dc078621c51045bee.
Bug: T378876
Change-Id: I3e0df790ff9db2fa630f82408a7254a359fe61ca
Diffstat (limited to 'includes/Navigation')
-rw-r--r-- | includes/Navigation/PagerNavigationBuilder.php | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/includes/Navigation/PagerNavigationBuilder.php b/includes/Navigation/PagerNavigationBuilder.php index 2c80e5e1331e..eb8ea3cc6937 100644 --- a/includes/Navigation/PagerNavigationBuilder.php +++ b/includes/Navigation/PagerNavigationBuilder.php @@ -9,6 +9,8 @@ use MediaWiki\Page\PageReference; use MediaWiki\Title\Title; use MessageLocalizer; use RuntimeException; +use Wikimedia\Message\MessageParam; +use Wikimedia\Message\MessageSpecifier; /** * Build the navigation for a pager, with links to prev/next page, links to change limits, and @@ -232,8 +234,11 @@ class PagerNavigationBuilder { } /** - * @param mixed $key - * @param mixed ...$params + * @param string|string[]|MessageSpecifier $key Message key, or array of keys, + * or a MessageSpecifier. + * @phpcs:ignore Generic.Files.LineLength + * @param MessageParam|MessageSpecifier|string|int|float|list<MessageParam|MessageSpecifier|string|int|float> ...$params + * See Message::params() * @return Message */ private function msg( $key, ...$params ): Message { |