Per code review: Redo these allowBlah() functions (except allowPasswordChange) into a general allowPropChange(), update Preferences to use this. Checked extensions in SVN using AuthPlugin and none have implemented any of the allow*() functions, so nothing should break.

1 files changed, 6 insertions, 22 deletions

diff --git a/includes/AuthPlugin.php b/includes/AuthPlugin.php
index 29be2def3154..3632dbfd9540 100644
--- a/includes/AuthPlugin.php
+++ b/includes/AuthPlugin.php
@@ -123,38 +123,22 @@ class AuthPlugin {
 	}
 
 	/**
-	 * Can users change their passwords?
-	 *
-	 * @return bool
-	 */
-	public function allowPasswordChange() {
-		return true;
-	}
-	
-	/**
-	 * Can users change their Real Name?
+	 * Allow a property change? Properties are the same as preferences
+	 * and use the same keys. 'Realname' 'Emailaddress' and 'Nickname'
+	 * all reference this.
 	 *
 	 * @return bool
 	 */
-	public function allowRealNameChange() {
+	public function allowPropChange( $prop = '' ) {
 		return true;
 	}
 
 	/**
-	 * Can users change their email address?
-	 *
-	 * @return bool
-	 */
-	public function allowEmailChange() {
-		return true;
-	}
-
-	/**
-	 * Can users change their Nickname?
+	 * Can users change their passwords?
 	 *
 	 * @return bool
 	 */
-	public function allowNickChange() {
+	public function allowPasswordChange() {
 		return true;
 	}