diff options
| author | jenkins-bot <jenkins-bot@gerrit.wikimedia.org> | 2025-03-27 13:48:10 +0000 |
|---|---|---|
| committer | Gerrit Code Review <gerrit@wikimedia.org> | 2025-03-27 13:48:10 +0000 |
| commit | 882a4be34f8c6c22c7ebca19de3c4bc9b2e7151a (patch) | |
| tree | 270a39ce59d511aa207507bf6114438624de8a93 | |
| parent | a0570d4afb24a61d81113d0d15001a27b8971379 (diff) | |
| parent | 12f79b88ffde8bc2fa299e87cd2141c89d641c75 (diff) | |
| download | mediawikicore-882a4be34f8c6c22c7ebca19de3c4bc9b2e7151a.tar.gz mediawikicore-882a4be34f8c6c22c7ebca19de3c4bc9b2e7151a.zip | |
Merge "Make $wgUsersNotifiedOnAllChanges require confirmed emails"
| -rw-r--r-- | RELEASE-NOTES-1.44 | 5 | ||||
| -rw-r--r-- | includes/Notification/Handlers/RecentChangeNotificationHandler.php | 7 |
2 files changed, 5 insertions, 7 deletions
diff --git a/RELEASE-NOTES-1.44 b/RELEASE-NOTES-1.44 index a60be88c4146..ec837f1f16f9 100644 --- a/RELEASE-NOTES-1.44 +++ b/RELEASE-NOTES-1.44 @@ -36,6 +36,11 @@ For notes on 1.43.x and older releases, see HISTORY. MediaWiki 1.26, structured exception data conforming to the PSR-3 logging standard is also available on the 'exception' log channel. (Log channels can be configured using $wgMWLoggerDefaultSpi.) +* $wgUsersNotifiedOnAllChanges now requires the listed users to have confirmed + email addresses, just like other kinds of email notifications do. + You can confirm the email address by logging in as the user and using + "Confirm your email address" in user preferences, or by running a maintenance + script: resetUserEmail.php --no-reset-password <username> <new-email> * … ==== New configuration ==== diff --git a/includes/Notification/Handlers/RecentChangeNotificationHandler.php b/includes/Notification/Handlers/RecentChangeNotificationHandler.php index afa4392a43ec..1f874c8be215 100644 --- a/includes/Notification/Handlers/RecentChangeNotificationHandler.php +++ b/includes/Notification/Handlers/RecentChangeNotificationHandler.php @@ -28,13 +28,6 @@ class RecentChangeNotificationHandler implements NotificationHandler { } public function checkNotificationRequirements( Notification $notification, User $user ): bool { - if ( $notification->getType() === RecentChangeNotification::TYPE ) { - // backwards compatibility, UsersNotifiedOnAllChanges didn't require emails to be confirmed - // @TODO MediaWiki handler should always confirm email before sending any - // notification, no matter what the notification is. - // @see https://phabricator.wikimedia.org/T389608 - return true; - } return $user->isEmailConfirmed(); } |