aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBartosz DziewoƄski <dziewonski@fastmail.fm>2025-03-12 19:35:43 +0100
committerJdlrobson <jrobson@wikimedia.org>2025-03-26 23:53:54 +0000
commit2629e367dbd8156f97feda82ad9a50deccdfce9a (patch)
tree55a0b0a4b38dc34f879bcf5399d6e3e8a5ae8d9c
parent666937d0694ea87f6c8aab1421cfbf0f2458c623 (diff)
downloadmediawikicore-2629e367dbd8156f97feda82ad9a50deccdfce9a.tar.gz
mediawikicore-2629e367dbd8156f97feda82ad9a50deccdfce9a.zip
Set thumbnail image background to @background-color-base-fixed (white)
Bug: T388197 Change-Id: Ie842c3aab71cf354436e273046cde1af3f83d947
-rw-r--r--resources/src/mediawiki.skinning/content.media-common.less3
-rw-r--r--resources/src/mediawiki.skinning/content.media-screen.less2
-rw-r--r--resources/src/mediawiki.skinning/content.thumbnails-screen.less2
3 files changed, 5 insertions, 2 deletions
diff --git a/resources/src/mediawiki.skinning/content.media-common.less b/resources/src/mediawiki.skinning/content.media-common.less
index 7fc8ef62ed11..e7642834a7cf 100644
--- a/resources/src/mediawiki.skinning/content.media-common.less
+++ b/resources/src/mediawiki.skinning/content.media-common.less
@@ -155,6 +155,9 @@ figure[ typeof~='mw:File/Frame' ] {
> figcaption {
display: table-caption;
caption-side: bottom;
+ // Needed because we use table-caption. We want the image caption to have the same background as
+ // the image frame, without having to set it separately in dark mode overrides.
+ background-color: inherit;
line-height: @line-height-thumbcaption;
/**
diff --git a/resources/src/mediawiki.skinning/content.media-screen.less b/resources/src/mediawiki.skinning/content.media-screen.less
index eab1d1ed00d0..e9b291dc2481 100644
--- a/resources/src/mediawiki.skinning/content.media-screen.less
+++ b/resources/src/mediawiki.skinning/content.media-screen.less
@@ -13,13 +13,13 @@ figure[ typeof~='mw:File/Frame' ] {
background-color: @background-color-interactive-subtle;
> :not( figcaption ) .mw-file-element {
+ background-color: @background-color-base-fixed;
border: @border-subtle;
}
> figcaption {
border: @border-subtle;
border-top: 0;
- background-color: @background-color-interactive-subtle;
/* In mw-core the font-size is duplicated, 94% in thumbinner
* and again 94% in thumbcaption. 88.4% for font size of the
diff --git a/resources/src/mediawiki.skinning/content.thumbnails-screen.less b/resources/src/mediawiki.skinning/content.thumbnails-screen.less
index bf53a14f30c9..06e5cdc89789 100644
--- a/resources/src/mediawiki.skinning/content.thumbnails-screen.less
+++ b/resources/src/mediawiki.skinning/content.thumbnails-screen.less
@@ -19,7 +19,7 @@ div.thumbinner {
}
.thumbimage {
- background-color: @background-color-interactive-subtle;
+ background-color: @background-color-base-fixed;
border: 1px solid @border-color-subtle;
}