aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAmir Sarabadani <ladsgroup@gmail.com>2023-09-19 17:49:48 +0200
committerAmir Sarabadani <ladsgroup@gmail.com>2023-09-20 13:32:14 +0200
commite2bc1bb94251cfa789b757ff056bdcc98f0d5c52 (patch)
treeb4cefc09aa02cce53dc11a2b48534519a7ab7adf
parent44a6dd21b3286ad26c1b24ed69ccdc13097e3904 (diff)
downloadmediawikicore-e2bc1bb94251cfa789b757ff056bdcc98f0d5c52.tar.gz
mediawikicore-e2bc1bb94251cfa789b757ff056bdcc98f0d5c52.zip
jobs: Migrate to use SQB in HTMLCacheUpdateJob
And clean it up a bit. Bug: T344971 Change-Id: Ie5b27506e9e728c61f6fd775a2e74eae80dbd7c1
-rw-r--r--includes/jobqueue/jobs/HTMLCacheUpdateJob.php17
1 files changed, 8 insertions, 9 deletions
diff --git a/includes/jobqueue/jobs/HTMLCacheUpdateJob.php b/includes/jobqueue/jobs/HTMLCacheUpdateJob.php
index 8fe83e7f3a68..55e0a0677153 100644
--- a/includes/jobqueue/jobs/HTMLCacheUpdateJob.php
+++ b/includes/jobqueue/jobs/HTMLCacheUpdateJob.php
@@ -158,15 +158,14 @@ class HTMLCacheUpdateJob extends Job {
}
}
// Get the list of affected pages (races only mean something else did the purge)
- $titleArray = TitleArray::newFromResult( $dbw->select(
- 'page',
- array_merge(
- [ 'page_namespace', 'page_title' ],
- $config->get( MainConfigNames::PageLanguageUseDB ) ? [ 'page_lang' ] : []
- ),
- [ 'page_id' => $pageIds, 'page_touched' => $dbw->timestamp( $newTouchedUnix ) ],
- __METHOD__
- ) );
+ $queryBuilder = $dbw->newSelectQueryBuilder()
+ ->select( [ 'page_namespace', 'page_title' ] )
+ ->from( 'page' )
+ ->where( [ 'page_id' => $pageIds, 'page_touched' => $dbw->timestamp( $newTouchedUnix ) ] );
+ if ( $config->get( MainConfigNames::PageLanguageUseDB ) ) {
+ $queryBuilder->field( 'page_lang' );
+ }
+ $titleArray = TitleArray::newFromResult( $queryBuilder->caller( __METHOD__ )->fetchResultSet() );
// Update CDN and file caches
$htmlCache = MediaWikiServices::getInstance()->getHtmlCacheUpdater();