aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRyan Kaldari <kaldari@users.mediawiki.org>2012-03-12 12:43:35 +0000
committerReedy <reedy@wikimedia.org>2012-03-22 22:10:34 +0000
commit9fbf1fa5329d0330238d3e71098908c8be3f19ec (patch)
tree3636cb0ba91811cb51a40d8e6f0cdbfb8921035d
parentd6658019a8bf2f39da40d66ec79c29e8d8249087 (diff)
downloadmediawikicore-9fbf1fa5329d0330238d3e71098908c8be3f19ec.tar.gz
mediawikicore-9fbf1fa5329d0330238d3e71098908c8be3f19ec.zip
fix for bug 34696 - mw.loader.using shouldnt call callback more than once
Notes
Notes: http://mediawiki.org/wiki/Special:Code/MediaWiki/113617
-rw-r--r--resources/mediawiki/mediawiki.js7
1 files changed, 4 insertions, 3 deletions
diff --git a/resources/mediawiki/mediawiki.js b/resources/mediawiki/mediawiki.js
index cf0fdcac8784..121d5399a59c 100644
--- a/resources/mediawiki/mediawiki.js
+++ b/resources/mediawiki/mediawiki.js
@@ -586,11 +586,12 @@ var mw = ( function ( $, undefined ) {
filter( 'ready', jobs[j].dependencies ),
jobs[j].dependencies ) )
{
- if ( $.isFunction( jobs[j].ready ) ) {
- jobs[j].ready();
- }
+ var callback = jobs[j].ready;
jobs.splice( j, 1 );
j -= 1;
+ if ( $.isFunction( callback ) ) {
+ callback();
+ }
}
}
// Execute modules whose dependencies have just been met